* [PATCH] meta-oe: php, given "_append", remove superfluous "+="
@ 2016-08-18 9:37 Robert P. J. Day
2016-08-18 17:40 ` Khem Raj
0 siblings, 1 reply; 6+ messages in thread
From: Robert P. J. Day @ 2016-08-18 9:37 UTC (permalink / raw)
To: OpenEmbedded Development mailing list
Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
---
again, not compile-tested since it seems obvious
diff --git a/meta-oe/recipes-devtools/php/php.inc b/meta-oe/recipes-devtools/php/php.inc
index ee7a143..23de2b1 100644
--- a/meta-oe/recipes-devtools/php/php.inc
+++ b/meta-oe/recipes-devtools/php/php.inc
@@ -15,7 +15,7 @@ SRC_URI = "http://php.net/distributions/php-${PV}.tar.bz2 \
file://0001-acinclude-use-pkgconfig-for-libxml2-config.patch \
"
-SRC_URI_append_class-target += " \
+SRC_URI_append_class-target = " \
file://iconv.patch \
file://imap-fix-autofoo.patch \
file://pear-makefile.patch \
--
========================================================================
Robert P. J. Day Ottawa, Ontario, CANADA
http://crashcourse.ca
Twitter: http://twitter.com/rpjday
LinkedIn: http://ca.linkedin.com/in/rpjday
========================================================================
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] meta-oe: php, given "_append", remove superfluous "+="
2016-08-18 9:37 [PATCH] meta-oe: php, given "_append", remove superfluous "+=" Robert P. J. Day
@ 2016-08-18 17:40 ` Khem Raj
2016-08-18 18:08 ` Robert P. J. Day
2016-08-18 18:09 ` Robert P. J. Day
0 siblings, 2 replies; 6+ messages in thread
From: Khem Raj @ 2016-08-18 17:40 UTC (permalink / raw)
To: openembedded-devel
[-- Attachment #1: Type: text/plain, Size: 1560 bytes --]
> On Aug 18, 2016, at 2:37 AM, Robert P. J. Day <rpjday@crashcourse.ca> wrote:
>
>
> Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
>
> ---
>
> again, not compile-tested since it seems obvious
>
> diff --git a/meta-oe/recipes-devtools/php/php.inc b/meta-oe/recipes-devtools/php/php.inc
> index ee7a143..23de2b1 100644
> --- a/meta-oe/recipes-devtools/php/php.inc
> +++ b/meta-oe/recipes-devtools/php/php.inc
> @@ -15,7 +15,7 @@ SRC_URI = "http://php.net/distributions/php-${PV}.tar.bz2 \
> file://0001-acinclude-use-pkgconfig-for-libxml2-config.patch \
> "
>
> -SRC_URI_append_class-target += " \
> +SRC_URI_append_class-target = “ \
nitpick: You do not need a space here since its already added after newline
> file://iconv.patch \
> file://imap-fix-autofoo.patch \
> file://pear-makefile.patch \
>
> --
>
> ========================================================================
> Robert P. J. Day Ottawa, Ontario, CANADA
> http://crashcourse.ca
>
> Twitter: http://twitter.com/rpjday
> LinkedIn: http://ca.linkedin.com/in/rpjday
> ========================================================================
>
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
[-- Attachment #2: Message signed with OpenPGP using GPGMail --]
[-- Type: application/pgp-signature, Size: 211 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] meta-oe: php, given "_append", remove superfluous "+="
2016-08-18 17:40 ` Khem Raj
@ 2016-08-18 18:08 ` Robert P. J. Day
2016-08-18 18:09 ` Robert P. J. Day
1 sibling, 0 replies; 6+ messages in thread
From: Robert P. J. Day @ 2016-08-18 18:08 UTC (permalink / raw)
To: openembedded-devel
[-- Attachment #1: Type: text/plain, Size: 1445 bytes --]
On Thu, 18 Aug 2016, Khem Raj wrote:
>
> > On Aug 18, 2016, at 2:37 AM, Robert P. J. Day <rpjday@crashcourse.ca> wrote:
> >
> >
> > Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
> >
> > ---
> >
> > again, not compile-tested since it seems obvious
> >
> > diff --git a/meta-oe/recipes-devtools/php/php.inc b/meta-oe/recipes-devtools/php/php.inc
> > index ee7a143..23de2b1 100644
> > --- a/meta-oe/recipes-devtools/php/php.inc
> > +++ b/meta-oe/recipes-devtools/php/php.inc
> > @@ -15,7 +15,7 @@ SRC_URI = "http://php.net/distributions/php-${PV}.tar.bz2 \
> > file://0001-acinclude-use-pkgconfig-for-libxml2-config.patch \
> > "
> >
> > -SRC_URI_append_class-target += " \
> > +SRC_URI_append_class-target = “ \
>
> nitpick: You do not need a space here since its already added after newline
>
> > file://iconv.patch \
> > file://imap-fix-autofoo.patch \
> > file://pear-makefile.patch \
> >
ah, quite so.
rday
--
========================================================================
Robert P. J. Day Ottawa, Ontario, CANADA
http://crashcourse.ca
Twitter: http://twitter.com/rpjday
LinkedIn: http://ca.linkedin.com/in/rpjday
========================================================================
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] meta-oe: php, given "_append", remove superfluous "+="
2016-08-18 17:40 ` Khem Raj
2016-08-18 18:08 ` Robert P. J. Day
@ 2016-08-18 18:09 ` Robert P. J. Day
2016-08-18 18:21 ` Martin Jansa
1 sibling, 1 reply; 6+ messages in thread
From: Robert P. J. Day @ 2016-08-18 18:09 UTC (permalink / raw)
To: openembedded-devel
[-- Attachment #1: Type: text/plain, Size: 1426 bytes --]
On Thu, 18 Aug 2016, Khem Raj wrote:
>
> > On Aug 18, 2016, at 2:37 AM, Robert P. J. Day <rpjday@crashcourse.ca> wrote:
> >
> >
> > Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
> >
> > ---
> >
> > again, not compile-tested since it seems obvious
> >
> > diff --git a/meta-oe/recipes-devtools/php/php.inc b/meta-oe/recipes-devtools/php/php.inc
> > index ee7a143..23de2b1 100644
> > --- a/meta-oe/recipes-devtools/php/php.inc
> > +++ b/meta-oe/recipes-devtools/php/php.inc
> > @@ -15,7 +15,7 @@ SRC_URI = "http://php.net/distributions/php-${PV}.tar.bz2 \
> > file://0001-acinclude-use-pkgconfig-for-libxml2-config.patch \
> > "
> >
> > -SRC_URI_append_class-target += " \
> > +SRC_URI_append_class-target = “ \
>
> nitpick: You do not need a space here since its already added after newline
since i did that more than once, i'll resubmit those patches. if i'm
going to be annoyingly nitpicky, i might as well do it correctly.
rday
--
========================================================================
Robert P. J. Day Ottawa, Ontario, CANADA
http://crashcourse.ca
Twitter: http://twitter.com/rpjday
LinkedIn: http://ca.linkedin.com/in/rpjday
========================================================================
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] meta-oe: php, given "_append", remove superfluous "+="
2016-08-18 18:09 ` Robert P. J. Day
@ 2016-08-18 18:21 ` Martin Jansa
2016-08-18 18:30 ` Robert P. J. Day
0 siblings, 1 reply; 6+ messages in thread
From: Martin Jansa @ 2016-08-18 18:21 UTC (permalink / raw)
To: openembedded-devel
Don't resend, it's already in master-next (all 4 squashed into one) and I
would keep the space before \ because we always use space before \ even
when it's not really necessary.
On Thu, Aug 18, 2016 at 8:09 PM, Robert P. J. Day <rpjday@crashcourse.ca>
wrote:
> On Thu, 18 Aug 2016, Khem Raj wrote:
>
> >
> > > On Aug 18, 2016, at 2:37 AM, Robert P. J. Day <rpjday@crashcourse.ca>
> wrote:
> > >
> > >
> > > Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
> > >
> > > ---
> > >
> > > again, not compile-tested since it seems obvious
> > >
> > > diff --git a/meta-oe/recipes-devtools/php/php.inc
> b/meta-oe/recipes-devtools/php/php.inc
> > > index ee7a143..23de2b1 100644
> > > --- a/meta-oe/recipes-devtools/php/php.inc
> > > +++ b/meta-oe/recipes-devtools/php/php.inc
> > > @@ -15,7 +15,7 @@ SRC_URI = "http://php.net/distributions/
> php-${PV}.tar.bz2 \
> > > file://0001-acinclude-use-pkgconfig-for-libxml2-config.patch
> \
> > > "
> > >
> > > -SRC_URI_append_class-target += " \
> > > +SRC_URI_append_class-target = “ \
> >
> > nitpick: You do not need a space here since its already added after
> newline
>
> since i did that more than once, i'll resubmit those patches. if i'm
> going to be annoyingly nitpicky, i might as well do it correctly.
>
> rday
>
> --
>
> ========================================================================
> Robert P. J. Day Ottawa, Ontario, CANADA
> http://crashcourse.ca
>
> Twitter: http://twitter.com/rpjday
> LinkedIn: http://ca.linkedin.com/in/rpjday
> ========================================================================
>
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] meta-oe: php, given "_append", remove superfluous "+="
2016-08-18 18:21 ` Martin Jansa
@ 2016-08-18 18:30 ` Robert P. J. Day
0 siblings, 0 replies; 6+ messages in thread
From: Robert P. J. Day @ 2016-08-18 18:30 UTC (permalink / raw)
To: openembedded-devel
On Thu, 18 Aug 2016, Martin Jansa wrote:
> Don't resend, it's already in master-next (all 4 squashed into one) and I
> would keep the space before \ because we always use space before \ even
> when it's not really necessary.
that's what i thought, which is why i left it there. good to know,
thanks. time to start writing a style guide, methinks.
rday
--
========================================================================
Robert P. J. Day Ottawa, Ontario, CANADA
http://crashcourse.ca
Twitter: http://twitter.com/rpjday
LinkedIn: http://ca.linkedin.com/in/rpjday
========================================================================
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-08-18 18:30 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-18 9:37 [PATCH] meta-oe: php, given "_append", remove superfluous "+=" Robert P. J. Day
2016-08-18 17:40 ` Khem Raj
2016-08-18 18:08 ` Robert P. J. Day
2016-08-18 18:09 ` Robert P. J. Day
2016-08-18 18:21 ` Martin Jansa
2016-08-18 18:30 ` Robert P. J. Day
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.