[Qemu-devel] [PATCH] scsi: megasas: check request object in MegasasCmd

* [Qemu-devel] [PATCH] scsi: megasas: check request object in MegasasCmd
@ 2017-05-10 11:13 P J P
  2017-05-10 14:51 ` Paolo Bonzini
  0 siblings, 1 reply; 3+ messages in thread
From: P J P @ 2017-05-10 11:13 UTC (permalink / raw)
  To: Qemu Developers; +Cc: Paolo Bonzini, Zhangyanyu, Prasad J Pandit

From: Prasad J Pandit <pjp@fedoraproject.org>

When processing completed commands, if SCSIRequest object
'cmd->req' was null, it could lead to null pointer dereference
in megasas_complete_command. Add check to avoid it.

Reported-by: Zhangyanyu <zyy4013@stu.ouc.edu.cn>
Signed-off-by: Prasad J Pandit <pjp@fedoraproject.org>
---
 hw/scsi/megasas.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/hw/scsi/megasas.c b/hw/scsi/megasas.c
index 84b8caf..25e3541 100644
--- a/hw/scsi/megasas.c
+++ b/hw/scsi/megasas.c
@@ -580,9 +580,11 @@ static void megasas_complete_command(MegasasCmd *cmd)
     cmd->iov_size = 0;
     cmd->iov_offset = 0;
 
-    cmd->req->hba_private = NULL;
-    scsi_req_unref(cmd->req);
-    cmd->req = NULL;
+    if (cmd->req) {
+        cmd->req->hba_private = NULL;
+        scsi_req_unref(cmd->req);
+        cmd->req = NULL;
+    }
 
     megasas_unmap_frame(cmd->state, cmd);
     megasas_complete_frame(cmd->state, cmd->context);
-- 
2.9.3

^ permalink raw reply related	[flat|nested] 3+ messages in thread