* [PATCH] pkcs7: fix check for self-signed certificate
@ 2017-11-27 7:19 ` Eric Biggers
0 siblings, 0 replies; 4+ messages in thread
From: Eric Biggers @ 2017-11-27 7:19 UTC (permalink / raw)
To: keyrings, David Howells; +Cc: linux-crypto, Eric Biggers
From: Eric Biggers <ebiggers@google.com>
pkcs7_validate_trust_one() used 'x509->next == x509' to identify a
self-signed certificate. That's wrong; ->next is simply the link in the
linked list of certificates in the PKCS#7 message. It should be
checking ->signer instead. Fix it.
Fortunately this didn't actually matter because when we re-visited
'x509' on the next iteration via 'x509->signer', it was already seen and
not verified, so we returned -ENOKEY anyway.
Signed-off-by: Eric Biggers <ebiggers@google.com>
---
crypto/asymmetric_keys/pkcs7_trust.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/crypto/asymmetric_keys/pkcs7_trust.c b/crypto/asymmetric_keys/pkcs7_trust.c
index f6a009d88a33..1f4e25f10049 100644
--- a/crypto/asymmetric_keys/pkcs7_trust.c
+++ b/crypto/asymmetric_keys/pkcs7_trust.c
@@ -69,7 +69,7 @@ static int pkcs7_validate_trust_one(struct pkcs7_message *pkcs7,
/* Self-signed certificates form roots of their own, and if we
* don't know them, then we can't accept them.
*/
- if (x509->next == x509) {
+ if (x509->signer == x509) {
kleave(" = -ENOKEY [unknown self-signed]");
return -ENOKEY;
}
--
2.15.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH] pkcs7: fix check for self-signed certificate
@ 2017-11-27 7:19 ` Eric Biggers
0 siblings, 0 replies; 4+ messages in thread
From: Eric Biggers @ 2017-11-27 7:19 UTC (permalink / raw)
To: keyrings, David Howells; +Cc: linux-crypto, Eric Biggers
From: Eric Biggers <ebiggers@google.com>
pkcs7_validate_trust_one() used 'x509->next = x509' to identify a
self-signed certificate. That's wrong; ->next is simply the link in the
linked list of certificates in the PKCS#7 message. It should be
checking ->signer instead. Fix it.
Fortunately this didn't actually matter because when we re-visited
'x509' on the next iteration via 'x509->signer', it was already seen and
not verified, so we returned -ENOKEY anyway.
Signed-off-by: Eric Biggers <ebiggers@google.com>
---
crypto/asymmetric_keys/pkcs7_trust.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/crypto/asymmetric_keys/pkcs7_trust.c b/crypto/asymmetric_keys/pkcs7_trust.c
index f6a009d88a33..1f4e25f10049 100644
--- a/crypto/asymmetric_keys/pkcs7_trust.c
+++ b/crypto/asymmetric_keys/pkcs7_trust.c
@@ -69,7 +69,7 @@ static int pkcs7_validate_trust_one(struct pkcs7_message *pkcs7,
/* Self-signed certificates form roots of their own, and if we
* don't know them, then we can't accept them.
*/
- if (x509->next = x509) {
+ if (x509->signer = x509) {
kleave(" = -ENOKEY [unknown self-signed]");
return -ENOKEY;
}
--
2.15.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] pkcs7: fix check for self-signed certificate
2017-11-27 7:19 ` Eric Biggers
@ 2017-11-27 9:54 ` James Morris
-1 siblings, 0 replies; 4+ messages in thread
From: James Morris @ 2017-11-27 9:54 UTC (permalink / raw)
To: Eric Biggers; +Cc: keyrings, David Howells, linux-crypto, Eric Biggers
On Sun, 26 Nov 2017, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@google.com>
>
> pkcs7_validate_trust_one() used 'x509->next == x509' to identify a
> self-signed certificate. That's wrong; ->next is simply the link in the
> linked list of certificates in the PKCS#7 message. It should be
> checking ->signer instead. Fix it.
>
> Fortunately this didn't actually matter because when we re-visited
> 'x509' on the next iteration via 'x509->signer', it was already seen and
> not verified, so we returned -ENOKEY anyway.
>
> Signed-off-by: Eric Biggers <ebiggers@google.com>
> ---
> crypto/asymmetric_keys/pkcs7_trust.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/crypto/asymmetric_keys/pkcs7_trust.c b/crypto/asymmetric_keys/pkcs7_trust.c
> index f6a009d88a33..1f4e25f10049 100644
> --- a/crypto/asymmetric_keys/pkcs7_trust.c
> +++ b/crypto/asymmetric_keys/pkcs7_trust.c
> @@ -69,7 +69,7 @@ static int pkcs7_validate_trust_one(struct pkcs7_message *pkcs7,
> /* Self-signed certificates form roots of their own, and if we
> * don't know them, then we can't accept them.
> */
> - if (x509->next == x509) {
> + if (x509->signer == x509) {
> kleave(" = -ENOKEY [unknown self-signed]");
> return -ENOKEY;
> }
> --
Reviewed-by: James Morris <james.l.morris@oracle.com>
--
James Morris
<james.l.morris@oracle.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] pkcs7: fix check for self-signed certificate
@ 2017-11-27 9:54 ` James Morris
0 siblings, 0 replies; 4+ messages in thread
From: James Morris @ 2017-11-27 9:54 UTC (permalink / raw)
To: Eric Biggers; +Cc: keyrings, David Howells, linux-crypto, Eric Biggers
On Sun, 26 Nov 2017, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@google.com>
>
> pkcs7_validate_trust_one() used 'x509->next = x509' to identify a
> self-signed certificate. That's wrong; ->next is simply the link in the
> linked list of certificates in the PKCS#7 message. It should be
> checking ->signer instead. Fix it.
>
> Fortunately this didn't actually matter because when we re-visited
> 'x509' on the next iteration via 'x509->signer', it was already seen and
> not verified, so we returned -ENOKEY anyway.
>
> Signed-off-by: Eric Biggers <ebiggers@google.com>
> ---
> crypto/asymmetric_keys/pkcs7_trust.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/crypto/asymmetric_keys/pkcs7_trust.c b/crypto/asymmetric_keys/pkcs7_trust.c
> index f6a009d88a33..1f4e25f10049 100644
> --- a/crypto/asymmetric_keys/pkcs7_trust.c
> +++ b/crypto/asymmetric_keys/pkcs7_trust.c
> @@ -69,7 +69,7 @@ static int pkcs7_validate_trust_one(struct pkcs7_message *pkcs7,
> /* Self-signed certificates form roots of their own, and if we
> * don't know them, then we can't accept them.
> */
> - if (x509->next = x509) {
> + if (x509->signer = x509) {
> kleave(" = -ENOKEY [unknown self-signed]");
> return -ENOKEY;
> }
> --
Reviewed-by: James Morris <james.l.morris@oracle.com>
--
James Morris
<james.l.morris@oracle.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-11-27 9:55 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-27 7:19 [PATCH] pkcs7: fix check for self-signed certificate Eric Biggers
2017-11-27 7:19 ` Eric Biggers
2017-11-27 9:54 ` James Morris
2017-11-27 9:54 ` James Morris
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.