[PATCH] -xen-attach is needed for pvh boot with qemu-xen

[PATCH] -xen-attach is needed for pvh boot with qemu-xen

[Michael Young]

Currently the boot of a pvh guest using the qemu-xen device model fails
with the error
xen emulation not implemented (yet)
in the qemu-dm log file. This patch adds the missing -xen-attach
argument.

Signed-off-by: Michael Young <m.a.young@durham.ac.uk>
---
  tools/libxl/libxl_dm.c | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tools/libxl/libxl_dm.c b/tools/libxl/libxl_dm.c
index a2ea95a9be..3a839d5c1e 100644
--- a/tools/libxl/libxl_dm.c
+++ b/tools/libxl/libxl_dm.c
@@ -1021,7 +1021,8 @@ static int libxl__build_device_model_args_new(libxl__gc *gc,
       */
      flexarray_append(dm_args, "-no-user-config");

-    if (b_info->type == LIBXL_DOMAIN_TYPE_PV) {
+    if ((b_info->type == LIBXL_DOMAIN_TYPE_PV) ||
+        (b_info->type == LIBXL_DOMAIN_TYPE_PVH)) {
          flexarray_append(dm_args, "-xen-attach");
      }

-- 
2.14.3

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [PATCH] -xen-attach is needed for pvh boot with qemu-xen

[Roger Pau Monné]

On Sun, Jan 14, 2018 at 09:12:51PM +0000, Michael Young wrote:
> Currently the boot of a pvh guest using the qemu-xen device model fails
> with the error
> xen emulation not implemented (yet)
> in the qemu-dm log file. This patch adds the missing -xen-attach
> argument.
> 
> Signed-off-by: Michael Young <m.a.young@durham.ac.uk>
> ---
>  tools/libxl/libxl_dm.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/libxl/libxl_dm.c b/tools/libxl/libxl_dm.c
> index a2ea95a9be..3a839d5c1e 100644
> --- a/tools/libxl/libxl_dm.c
> +++ b/tools/libxl/libxl_dm.c
> @@ -1021,7 +1021,8 @@ static int libxl__build_device_model_args_new(libxl__gc *gc,
>       */
>      flexarray_append(dm_args, "-no-user-config");
> 
> -    if (b_info->type == LIBXL_DOMAIN_TYPE_PV) {
> +    if ((b_info->type == LIBXL_DOMAIN_TYPE_PV) ||
> +        (b_info->type == LIBXL_DOMAIN_TYPE_PVH)) {

Better write this as b_info->type != LIBXL_DOMAIN_TYPE_HVM.

With that fixed:

Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>

And sorry for that, I could bet I've tried that.

Thanks, Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel