* [PATCH] sha1-file.c: Correct $GITDIR to $GIT_DIR
@ 2018-06-03 12:22 Robert P. J. Day
2018-06-03 14:29 ` SZEDER Gábor
0 siblings, 1 reply; 2+ messages in thread
From: Robert P. J. Day @ 2018-06-03 12:22 UTC (permalink / raw)
To: Git Mailing list
Fix single misspelling of $GITDIR to correct $GIT_DIR.
Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
---
only occurrence in entire code base that i ran across, so i figured
might as well fix it.
diff --git a/sha1-file.c b/sha1-file.c
index 555e780f4..695e5c627 100644
--- a/sha1-file.c
+++ b/sha1-file.c
@@ -610,7 +610,7 @@ void add_to_alternates_memory(const char *reference)
/*
* Compute the exact path an alternate is at and returns it. In case of
* error NULL is returned and the human readable error is added to `err`
- * `path` may be relative and should point to $GITDIR.
+ * `path` may be relative and should point to $GIT_DIR.
* `err` must not be null.
*/
char *compute_alternate_path(const char *path, struct strbuf *err)
--
========================================================================
Robert P. J. Day Ottawa, Ontario, CANADA
http://crashcourse.ca/dokuwiki
Twitter: http://twitter.com/rpjday
LinkedIn: http://ca.linkedin.com/in/rpjday
========================================================================
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] sha1-file.c: Correct $GITDIR to $GIT_DIR
2018-06-03 12:22 [PATCH] sha1-file.c: Correct $GITDIR to $GIT_DIR Robert P. J. Day
@ 2018-06-03 14:29 ` SZEDER Gábor
0 siblings, 0 replies; 2+ messages in thread
From: SZEDER Gábor @ 2018-06-03 14:29 UTC (permalink / raw)
To: Robert P. J. Day; +Cc: SZEDER Gábor, Git Mailing list
Could you please add "in a comment" to the end of the subject line?
So it will be immediately clear to future readers of 'git log
--oneline' that this is not a bugfix.
> Fix single misspelling of $GITDIR to correct $GIT_DIR.
>
> Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
>
> ---
>
> only occurrence in entire code base that i ran across, so i figured
> might as well fix it.
>
> diff --git a/sha1-file.c b/sha1-file.c
> index 555e780f4..695e5c627 100644
> --- a/sha1-file.c
> +++ b/sha1-file.c
> @@ -610,7 +610,7 @@ void add_to_alternates_memory(const char *reference)
> /*
> * Compute the exact path an alternate is at and returns it. In case of
> * error NULL is returned and the human readable error is added to `err`
> - * `path` may be relative and should point to $GITDIR.
> + * `path` may be relative and should point to $GIT_DIR.
> * `err` must not be null.
> */
> char *compute_alternate_path(const char *path, struct strbuf *err)
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-06-03 14:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-06-03 12:22 [PATCH] sha1-file.c: Correct $GITDIR to $GIT_DIR Robert P. J. Day
2018-06-03 14:29 ` SZEDER Gábor
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.