All of lore.kernel.org
 help / color / mirror / Atom feed
From: James Simmons <jsimmons@infradead.org>
To: lustre-devel@lists.lustre.org
Subject: [lustre-devel] [PATCH 4/9] lustre: rename: DNE2 should return -EXDEV upon remote rename
Date: Mon, 26 Nov 2018 01:31:32 +0000 (GMT)	[thread overview]
Message-ID: <alpine.LFD.2.21.1811260130360.32255@casper.infradead.org> (raw)
In-Reply-To: <154295732797.2850.16990175697450002727.stgit@noble>



On Fri, 23 Nov 2018, NeilBrown wrote:

> From: Lai Siyao <lai.siyao@intel.com>
> 
> DNE2 MDS should return -EXDEV upon remote rename, so that old
> client can do rename with copy and delete, instead of fail
> with -EREMOTE.

Let me guess you were debugging the migration failures and fould this :-)
I was doing the same thing.

Reviewed-by: James Simmons <jsimmons@infradead.org>
 
> Signed-off-by: Lai Siyao <lai.siyao@intel.com>
> Change-Id: I68e8e99259065922f31bee5343be309380715674
> WC-bug-id: https://jira.whamcloud.com/browse/LU-6660
> Reviewed-on: http://review.whamcloud.com/15323
> Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
> Reviewed-by: wangdi <di.wang@intel.com>
> Reviewed-by: Fan Yong <fan.yong@intel.com>
> Signed-off-by: NeilBrown <neilb@suse.com>
> ---
>  drivers/staging/lustre/lustre/lmv/lmv_obd.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/lustre/lustre/lmv/lmv_obd.c b/drivers/staging/lustre/lustre/lmv/lmv_obd.c
> index 32bb9fca88c9..7e4ffeb15a63 100644
> --- a/drivers/staging/lustre/lustre/lmv/lmv_obd.c
> +++ b/drivers/staging/lustre/lustre/lmv/lmv_obd.c
> @@ -1945,7 +1945,7 @@ static int lmv_rename(struct obd_export *exp, struct md_op_data *op_data,
>  	}
>  
>  	rc = md_rename(target_exp, op_data, old, oldlen, new, newlen, request);
> -	if (rc && rc != -EREMOTE)
> +	if (rc && rc != -EXDEV)
>  		return rc;
>  
>  	body = req_capsule_server_get(&(*request)->rq_pill, &RMF_MDT_BODY);
> 
> 
> 

  reply	other threads:[~2018-11-26  1:31 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-23  7:15 [lustre-devel] [PATCH 0/9] Assorted lustre patches - mostly from OpenSFS NeilBrown
2018-11-23  7:15 ` [lustre-devel] [PATCH 2/9] lustre: remove EIOCBRETRY handling NeilBrown
2018-11-26  1:30   ` James Simmons
2018-11-23  7:15 ` [lustre-devel] [PATCH 1/9] lustre: obdclass: fix formating of connection flags NeilBrown
2018-11-26  1:30   ` James Simmons
2018-11-23  7:15 ` [lustre-devel] [PATCH 3/9] lustre: ptlrpc: use smp unsafe at_init only for initialization NeilBrown
2018-11-26  1:32   ` James Simmons
2018-11-23  7:15 ` [lustre-devel] [PATCH 4/9] lustre: rename: DNE2 should return -EXDEV upon remote rename NeilBrown
2018-11-26  1:31   ` James Simmons [this message]
2018-11-26  3:00     ` NeilBrown
2018-11-23  7:15 ` [lustre-devel] [PATCH 9/9] lustre: statahead: add smp_mb() to serialize ops NeilBrown
2018-11-26  2:10   ` James Simmons
2018-11-23  7:15 ` [lustre-devel] [PATCH 8/9] lustre: statahead: skip agl for the file in restoring NeilBrown
2018-11-26  2:09   ` James Simmons
2018-11-26  2:09   ` James Simmons
2018-11-23  7:15 ` [lustre-devel] [PATCH 5/9] lustre: llite: clear LLIF_FILE_RESTORING when done NeilBrown
2018-11-26  1:34   ` James Simmons
2018-11-23  7:15 ` [lustre-devel] [PATCH 6/9] lustre: obdclass: health_check to report unhealthy upon LBUG NeilBrown
2018-11-26  1:46   ` James Simmons
2018-11-26  1:46   ` James Simmons
2018-11-27  2:32     ` NeilBrown
2018-11-23  7:15 ` [lustre-devel] [PATCH 7/9] lustre: lnet: Stop MLX5 triggering a dump_cqe NeilBrown
2018-11-26  1:49   ` James Simmons
2018-11-27  2:21     ` NeilBrown
2018-11-26  3:47 ` [lustre-devel] [PATCH 0/9] Assorted lustre patches - mostly from OpenSFS James Simmons

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.2.21.1811260130360.32255@casper.infradead.org \
    --to=jsimmons@infradead.org \
    --cc=lustre-devel@lists.lustre.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.