All of lore.kernel.org
 help / color / mirror / Atom feed
From: James Simmons <jsimmons@infradead.org>
To: lustre-devel@lists.lustre.org
Subject: [lustre-devel] [PATCH 7/9] lustre: lnet: Stop MLX5 triggering a dump_cqe
Date: Mon, 26 Nov 2018 01:49:01 +0000 (GMT)	[thread overview]
Message-ID: <alpine.LFD.2.21.1811260146540.32255@casper.infradead.org> (raw)
In-Reply-To: <154295732806.2850.603181458106225374.stgit@noble>


> From: Doug Oucharek <doug.s.oucharek@intel.com>
> 
> We have found that MLX5 will trigger a dump_cqe if we don't
> invalidate the rkey on a newly allocated MR for FastReg usage.
> 
> This fix just tags the MR as invalid on its creation if we are
> using FastReg and that will force it to do an invalidate of the
> rkey on first usage.

I pushed this one already, see https://lkml.org/lkml/2018/3/16/1410.
Dan felt this was more a infiniband layer bug that needed to be fixed.
It could be fixed already upstream or if it is not once this problem
is reported we will need to work the rdma group to fix it.
 
> Signed-off-by: Doug Oucharek <doug.s.oucharek@intel.com>
> WC-bug-id: https://jira.whamcloud.com/browse/LU-8752
> Reviewed-on: https://review.whamcloud.com/24306
> Reviewed-by: Dmitry Eremin <dmitry.eremin@intel.com>
> Reviewed-by: Amir Shehata <amir.shehata@intel.com>
> Reviewed-by: James Simmons <uja.ornl@yahoo.com>
> Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
> Signed-off-by: NeilBrown <neilb@suse.com>
> ---
>  .../staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c    |    7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c b/drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c
> index ecdf4dee533d..a5eada8ee354 100644
> --- a/drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c
> +++ b/drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c
> @@ -1483,7 +1483,12 @@ static int kiblnd_alloc_freg_pool(struct kib_fmr_poolset *fps,
>  			goto out_middle;
>  		}
>  
> -		frd->frd_valid = true;
> +		/*
> +		 * There appears to be a bug in MLX5 code where you must
> +		 * invalidate the rkey of a new FastReg pool before first
> +		 * using it. Thus, I am marking the FRD invalid here.
> +		 */
> +		frd->frd_valid = false;
>  
>  		list_add_tail(&frd->frd_list, &fpo->fast_reg.fpo_pool_list);
>  		fpo->fast_reg.fpo_pool_size++;
> 
> 
> 

  reply	other threads:[~2018-11-26  1:49 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-23  7:15 [lustre-devel] [PATCH 0/9] Assorted lustre patches - mostly from OpenSFS NeilBrown
2018-11-23  7:15 ` [lustre-devel] [PATCH 2/9] lustre: remove EIOCBRETRY handling NeilBrown
2018-11-26  1:30   ` James Simmons
2018-11-23  7:15 ` [lustre-devel] [PATCH 1/9] lustre: obdclass: fix formating of connection flags NeilBrown
2018-11-26  1:30   ` James Simmons
2018-11-23  7:15 ` [lustre-devel] [PATCH 3/9] lustre: ptlrpc: use smp unsafe at_init only for initialization NeilBrown
2018-11-26  1:32   ` James Simmons
2018-11-23  7:15 ` [lustre-devel] [PATCH 4/9] lustre: rename: DNE2 should return -EXDEV upon remote rename NeilBrown
2018-11-26  1:31   ` James Simmons
2018-11-26  3:00     ` NeilBrown
2018-11-23  7:15 ` [lustre-devel] [PATCH 9/9] lustre: statahead: add smp_mb() to serialize ops NeilBrown
2018-11-26  2:10   ` James Simmons
2018-11-23  7:15 ` [lustre-devel] [PATCH 8/9] lustre: statahead: skip agl for the file in restoring NeilBrown
2018-11-26  2:09   ` James Simmons
2018-11-26  2:09   ` James Simmons
2018-11-23  7:15 ` [lustre-devel] [PATCH 5/9] lustre: llite: clear LLIF_FILE_RESTORING when done NeilBrown
2018-11-26  1:34   ` James Simmons
2018-11-23  7:15 ` [lustre-devel] [PATCH 6/9] lustre: obdclass: health_check to report unhealthy upon LBUG NeilBrown
2018-11-26  1:46   ` James Simmons
2018-11-26  1:46   ` James Simmons
2018-11-27  2:32     ` NeilBrown
2018-11-23  7:15 ` [lustre-devel] [PATCH 7/9] lustre: lnet: Stop MLX5 triggering a dump_cqe NeilBrown
2018-11-26  1:49   ` James Simmons [this message]
2018-11-27  2:21     ` NeilBrown
2018-11-26  3:47 ` [lustre-devel] [PATCH 0/9] Assorted lustre patches - mostly from OpenSFS James Simmons

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.2.21.1811260146540.32255@casper.infradead.org \
    --to=jsimmons@infradead.org \
    --cc=lustre-devel@lists.lustre.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.