All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jiri Kosina <jkosina-AlSwsSmVLrQ@public.gmane.org>
To: Oliver Neukum <oliver-GvhC2dPhHPQdnm+yROfE0A@public.gmane.org>
Cc: Jiri Slaby <jslaby-AlSwsSmVLrQ@public.gmane.org>,
	linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	USB list <linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Dmitry Torokhov
	<dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Subject: Re: [patch]cleanup of hiddev
Date: Mon, 15 Dec 2008 17:01:07 +0100 (CET)	[thread overview]
Message-ID: <alpine.LNX.1.10.0812151659340.21089@jikos.suse.cz> (raw)
In-Reply-To: <200812091319.59054.oliver-GvhC2dPhHPQdnm+yROfE0A@public.gmane.org>

On Tue, 9 Dec 2008, Oliver Neukum wrote:

> commit f05614115c77fae393b3a262780f8f13ff485173
> Author: Oliver Neukum <oneukum-l3A5Bk7waGM@public.gmane.org>
> Date:   Tue Dec 9 13:09:56 2008 +0100
> 
>     cleanup of hiddev
>     
>     - thread safety
>     - fix race between ioctl and disconnect
>     - race in open
>     - error checking
>     - O_NONBLOCK handled

Hi Oliver,

I have finally gone through the patch, and I think it is OK. I'd prefer 
taking the individual cleanups as individual patches though, if you have 
it split in your tree.

Or at least more descriptive changelog, explaining the bugs fixed in 
deeper detail, would be nice to have.

Thanks!

-- 
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2008-12-15 16:01 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-09 12:19 [patch]cleanup of hiddev Oliver Neukum
     [not found] ` <200812091319.59054.oliver-GvhC2dPhHPQdnm+yROfE0A@public.gmane.org>
2008-12-15 16:01   ` Jiri Kosina [this message]
2008-12-16  6:13 Oliver Neukum

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LNX.1.10.0812151659340.21089@jikos.suse.cz \
    --to=jkosina-alswssmvlrq@public.gmane.org \
    --cc=dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=jslaby-AlSwsSmVLrQ@public.gmane.org \
    --cc=linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=oliver-GvhC2dPhHPQdnm+yROfE0A@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.