* [PATCH trivial] drivers/hid: the support for Hanwang tablet
@ 2010-08-11 3:48 Xing Wei
2010-08-11 7:33 ` [PATCH] " Jiri Kosina
0 siblings, 1 reply; 4+ messages in thread
From: Xing Wei @ 2010-08-11 3:48 UTC (permalink / raw)
To: jkosina; +Cc: linux-input, linux-kernel
From: Xing Wei <weixing@hanwang.com.cn>
This patch is the support for tablet of BeiJing HanwangTechnology Co, Ltd.
The main purpose is to make the device taken over by our driver.
The driver code will be submitted later.
Signed-off-by: Xing Wei <weixing@hanwang.com.cn>
---
This is our first time to submit the patch for linux.We'll really appreciate the comment and advice.
diff -uprN -X linux-2.6.35-vanilla/Documentation/dontdiff linux-2.6.35-vanilla/drivers/hid/hid-core.c devel/linux-2.6.35/drivers/hid/hid-core.c
--- linux-2.6.35-vanilla/drivers/hid/hid-core.c 2010-08-02 06:11:14.000000000 +0800
+++ devel/linux-2.6.35/drivers/hid/hid-core.c 2010-08-11 18:20:13.832088816 +0800
@@ -1759,6 +1759,11 @@ static bool hid_ignore(struct hid_device
hdev->product <= USB_DEVICE_ID_SOUNDGRAPH_IMON_LAST)
return true;
break;
+ case USB_VENDOR_ID_HANWANG:
+ if (hdev->product >= USB_DEVICE_ID_HANWANG_TABLET_FIRST &&
+ hdev->product <= USB_DEVICE_ID_HANWANG_TABLET_LAST)
+ return true;
+ break;
}
if (hdev->type == HID_TYPE_USBMOUSE &&
diff -uprN -X linux-2.6.35-vanilla/Documentation/dontdiff linux-2.6.35-vanilla/drivers/hid/hid-ids.h devel/linux-2.6.35/drivers/hid/hid-ids.h
--- linux-2.6.35-vanilla/drivers/hid/hid-ids.h 2010-08-02 06:11:14.000000000 +0800
+++ devel/linux-2.6.35/drivers/hid/hid-ids.h 2010-08-11 18:17:32.967089161 +0800
@@ -526,5 +526,8 @@
#define USB_DEVICE_ID_KYE_ERGO_525V 0x0087
#define USB_DEVICE_ID_KYE_GPEN_560 0x5003
+#define USB_VENDOR_ID_HANWANG 0x0b57
+#define USB_DEVICE_ID_HANWANG_TABLET_LAST 0x8fff
+#define USB_DEVICE_ID_HANWANG_TABLET_FIRST 0x5000
#endif
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drivers/hid: the support for Hanwang tablet
2010-08-11 3:48 [PATCH trivial] drivers/hid: the support for Hanwang tablet Xing Wei
@ 2010-08-11 7:33 ` Jiri Kosina
2010-08-11 9:27 ` Xing Wei
0 siblings, 1 reply; 4+ messages in thread
From: Jiri Kosina @ 2010-08-11 7:33 UTC (permalink / raw)
To: Xing Wei; +Cc: linux-input, linux-kernel
On Wed, 11 Aug 2010, Xing Wei wrote:
> From: Xing Wei <weixing@hanwang.com.cn>
>
> This patch is the support for tablet of BeiJing HanwangTechnology Co, Ltd.
> The main purpose is to make the device taken over by our driver.
> The driver code will be submitted later.
>
> Signed-off-by: Xing Wei <weixing@hanwang.com.cn>
>
> ---
> This is our first time to submit the patch for linux.We'll really appreciate the comment and advice.
>
> diff -uprN -X linux-2.6.35-vanilla/Documentation/dontdiff linux-2.6.35-vanilla/drivers/hid/hid-core.c devel/linux-2.6.35/drivers/hid/hid-core.c
> --- linux-2.6.35-vanilla/drivers/hid/hid-core.c 2010-08-02 06:11:14.000000000 +0800
> +++ devel/linux-2.6.35/drivers/hid/hid-core.c 2010-08-11 18:20:13.832088816 +0800
> @@ -1759,6 +1759,11 @@ static bool hid_ignore(struct hid_device
> hdev->product <= USB_DEVICE_ID_SOUNDGRAPH_IMON_LAST)
> return true;
> break;
> + case USB_VENDOR_ID_HANWANG:
> + if (hdev->product >= USB_DEVICE_ID_HANWANG_TABLET_FIRST &&
> + hdev->product <= USB_DEVICE_ID_HANWANG_TABLET_LAST)
> + return true;
> + break;
> }
>
> if (hdev->type == HID_TYPE_USBMOUSE &&
> diff -uprN -X linux-2.6.35-vanilla/Documentation/dontdiff linux-2.6.35-vanilla/drivers/hid/hid-ids.h devel/linux-2.6.35/drivers/hid/hid-ids.h
> --- linux-2.6.35-vanilla/drivers/hid/hid-ids.h 2010-08-02 06:11:14.000000000 +0800
> +++ devel/linux-2.6.35/drivers/hid/hid-ids.h 2010-08-11 18:17:32.967089161 +0800
> @@ -526,5 +526,8 @@
> #define USB_DEVICE_ID_KYE_ERGO_525V 0x0087
> #define USB_DEVICE_ID_KYE_GPEN_560 0x5003
>
> +#define USB_VENDOR_ID_HANWANG 0x0b57
> +#define USB_DEVICE_ID_HANWANG_TABLET_LAST 0x8fff
> +#define USB_DEVICE_ID_HANWANG_TABLET_FIRST 0x5000
The patch is fine (I'd only suggest swapping 'LAST' and 'FIRST' lines here
to keep proper ordering), but I will be applying it only together with the
driver once you submit it, as it doesn't make sense stand-alone.
The driver is not HID-based (i.e. not using hid bus), but completely
standalone, right?
--
Jiri Kosina
SUSE Labs, Novell Inc.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Re: [PATCH] drivers/hid: the support for Hanwang tablet
2010-08-11 7:33 ` [PATCH] " Jiri Kosina
@ 2010-08-11 9:27 ` Xing Wei
0 siblings, 0 replies; 4+ messages in thread
From: Xing Wei @ 2010-08-11 9:27 UTC (permalink / raw)
To: Jiri Kosina; +Cc: linux-input, linux-kernel
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="gb2312", Size: 2741 bytes --]
ok,i'll fix it and submit it with driver later.
The driver is just using usb bus.
-------------------------------------------------------------
·¢¼þÈË£ºJiri Kosina
·¢ËÍÈÕÆÚ£º2010-08-11 15:34:49
ÊÕ¼þÈË£ºXing Wei
³ËÍ£ºlinux-input; linux-kernel
Ö÷Ì⣺Re: [PATCH] drivers/hid: the support for Hanwang tablet
On Wed, 11 Aug 2010, Xing Wei wrote:
> From: Xing Wei <weixing@hanwang.com.cn>
>
> This patch is the support for tablet of BeiJing HanwangTechnology Co, Ltd.
> The main purpose is to make the device taken over by our driver.
> The driver code will be submitted later.
>
> Signed-off-by: Xing Wei <weixing@hanwang.com.cn>
>
> ---
> This is our first time to submit the patch for linux.We'll really appreciate the comment and advice.
>
> diff -uprN -X linux-2.6.35-vanilla/Documentation/dontdiff linux-2.6.35-vanilla/drivers/hid/hid-core.c devel/linux-2.6.35/drivers/hid/hid-core.c
> --- linux-2.6.35-vanilla/drivers/hid/hid-core.c 2010-08-02 06:11:14.000000000 +0800
> +++ devel/linux-2.6.35/drivers/hid/hid-core.c 2010-08-11 18:20:13.832088816 +0800
> @@ -1759,6 +1759,11 @@ static bool hid_ignore(struct hid_device
> hdev->product <= USB_DEVICE_ID_SOUNDGRAPH_IMON_LAST)
> return true;
> break;
> + case USB_VENDOR_ID_HANWANG:
> + if (hdev->product >= USB_DEVICE_ID_HANWANG_TABLET_FIRST &&
> + hdev->product <= USB_DEVICE_ID_HANWANG_TABLET_LAST)
> + return true;
> + break;
> }
>
> if (hdev->type == HID_TYPE_USBMOUSE &&
> diff -uprN -X linux-2.6.35-vanilla/Documentation/dontdiff linux-2.6.35-vanilla/drivers/hid/hid-ids.h devel/linux-2.6.35/drivers/hid/hid-ids.h
> --- linux-2.6.35-vanilla/drivers/hid/hid-ids.h 2010-08-02 06:11:14.000000000 +0800
> +++ devel/linux-2.6.35/drivers/hid/hid-ids.h 2010-08-11 18:17:32.967089161 +0800
> @@ -526,5 +526,8 @@
> #define USB_DEVICE_ID_KYE_ERGO_525V 0x0087
> #define USB_DEVICE_ID_KYE_GPEN_560 0x5003
>
> +#define USB_VENDOR_ID_HANWANG 0x0b57
> +#define USB_DEVICE_ID_HANWANG_TABLET_LAST 0x8fff
> +#define USB_DEVICE_ID_HANWANG_TABLET_FIRST 0x5000
The patch is fine (I'd only suggest swapping 'LAST' and 'FIRST' lines here
to keep proper ordering), but I will be applying it only together with the
driver once you submit it, as it doesn't make sense stand-alone.
The driver is not HID-based (i.e. not using hid bus), but completely
standalone, right?
--
Jiri Kosina
SUSE Labs, Novell Inc.
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
ÿôèº{.nÇ+‰·Ÿ®‰†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a¢f£¢·hšïêÿ‘êçz_è®\x03(階ŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨èÚ&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: Re: [PATCH] drivers/hid: the support for Hanwang tablet
@ 2010-08-11 9:27 ` Xing Wei
0 siblings, 0 replies; 4+ messages in thread
From: Xing Wei @ 2010-08-11 9:27 UTC (permalink / raw)
To: Jiri Kosina; +Cc: linux-input, linux-kernel
ok,i'll fix it and submit it with driver later.
The driver is just using usb bus.
-------------------------------------------------------------
发件人：Jiri Kosina
发送日期：2010-08-11 15:34:49
收件人：Xing Wei
抄送：linux-input; linux-kernel
主题：Re: [PATCH] drivers/hid: the support for Hanwang tablet
On Wed, 11 Aug 2010, Xing Wei wrote:
> From: Xing Wei <weixing@hanwang.com.cn>
>
> This patch is the support for tablet of BeiJing HanwangTechnology Co, Ltd.
> The main purpose is to make the device taken over by our driver.
> The driver code will be submitted later.
>
> Signed-off-by: Xing Wei <weixing@hanwang.com.cn>
>
> ---
> This is our first time to submit the patch for linux.We'll really appreciate the comment and advice.
>
> diff -uprN -X linux-2.6.35-vanilla/Documentation/dontdiff linux-2.6.35-vanilla/drivers/hid/hid-core.c devel/linux-2.6.35/drivers/hid/hid-core.c
> --- linux-2.6.35-vanilla/drivers/hid/hid-core.c 2010-08-02 06:11:14.000000000 +0800
> +++ devel/linux-2.6.35/drivers/hid/hid-core.c 2010-08-11 18:20:13.832088816 +0800
> @@ -1759,6 +1759,11 @@ static bool hid_ignore(struct hid_device
> hdev->product <= USB_DEVICE_ID_SOUNDGRAPH_IMON_LAST)
> return true;
> break;
> + case USB_VENDOR_ID_HANWANG:
> + if (hdev->product >= USB_DEVICE_ID_HANWANG_TABLET_FIRST &&
> + hdev->product <= USB_DEVICE_ID_HANWANG_TABLET_LAST)
> + return true;
> + break;
> }
>
> if (hdev->type == HID_TYPE_USBMOUSE &&
> diff -uprN -X linux-2.6.35-vanilla/Documentation/dontdiff linux-2.6.35-vanilla/drivers/hid/hid-ids.h devel/linux-2.6.35/drivers/hid/hid-ids.h
> --- linux-2.6.35-vanilla/drivers/hid/hid-ids.h 2010-08-02 06:11:14.000000000 +0800
> +++ devel/linux-2.6.35/drivers/hid/hid-ids.h 2010-08-11 18:17:32.967089161 +0800
> @@ -526,5 +526,8 @@
> #define USB_DEVICE_ID_KYE_ERGO_525V 0x0087
> #define USB_DEVICE_ID_KYE_GPEN_560 0x5003
>
> +#define USB_VENDOR_ID_HANWANG 0x0b57
> +#define USB_DEVICE_ID_HANWANG_TABLET_LAST 0x8fff
> +#define USB_DEVICE_ID_HANWANG_TABLET_FIRST 0x5000
The patch is fine (I'd only suggest swapping 'LAST' and 'FIRST' lines here
to keep proper ordering), but I will be applying it only together with the
driver once you submit it, as it doesn't make sense stand-alone.
The driver is not HID-based (i.e. not using hid bus), but completely
standalone, right?
--
Jiri Kosina
SUSE Labs, Novell Inc.
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-08-11 9:28 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-08-11 3:48 [PATCH trivial] drivers/hid: the support for Hanwang tablet Xing Wei
2010-08-11 7:33 ` [PATCH] " Jiri Kosina
2010-08-11 9:27 ` Xing Wei
2010-08-11 9:27 ` Xing Wei
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.