All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jiri Kosina <jkosina@suse.cz>
To: Joe Perches <joe@perches.com>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>,
	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 08/13] fs/seq_file.c: Remove unnecessary casts of private_data
Date: Thu, 23 Sep 2010 13:29:18 +0200 (CEST)	[thread overview]
Message-ID: <alpine.LNX.2.00.1009231328250.26813@pobox.suse.cz> (raw)
In-Reply-To: <8193d8be62a122210ba93506501bdf62d4081592.1283650107.git.joe@perches.com>

On Sat, 4 Sep 2010, Joe Perches wrote:

> Signed-off-by: Joe Perches <joe@perches.com>
> ---
>  fs/seq_file.c |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/fs/seq_file.c b/fs/seq_file.c
> index e1f437b..0e7cb13 100644
> --- a/fs/seq_file.c
> +++ b/fs/seq_file.c
> @@ -131,7 +131,7 @@ Eoverflow:
>   */
>  ssize_t seq_read(struct file *file, char __user *buf, size_t size, loff_t *ppos)
>  {
> -	struct seq_file *m = (struct seq_file *)file->private_data;
> +	struct seq_file *m = file->private_data;
>  	size_t copied = 0;
>  	loff_t pos;
>  	size_t n;
> @@ -280,7 +280,7 @@ EXPORT_SYMBOL(seq_read);
>   */
>  loff_t seq_lseek(struct file *file, loff_t offset, int origin)
>  {
> -	struct seq_file *m = (struct seq_file *)file->private_data;
> +	struct seq_file *m = file->private_data;
>  	loff_t retval = -EINVAL;
>  
>  	mutex_lock(&m->lock);
> @@ -324,7 +324,7 @@ EXPORT_SYMBOL(seq_lseek);
>   */
>  int seq_release(struct inode *inode, struct file *file)
>  {
> -	struct seq_file *m = (struct seq_file *)file->private_data;
> +	struct seq_file *m = file->private_data;
>  	kfree(m->buf);
>  	kfree(m);
>  	return 0;

Doesn't seem to be present in linux-next as of today. I am going to fold 
it into trivial queue, if anyone has any objections, shout now.

-- 
Jiri Kosina
SUSE Labs, Novell Inc.

  reply	other threads:[~2010-09-23 11:29 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-05  1:52 [PATCH 00/13] trivial: Remove unnecessary casts of private_data Joe Perches
2010-09-05  1:52 ` Joe Perches
2010-09-05  1:52 ` [PATCH 01/13] drivers/gpu/drm: " Joe Perches
2010-09-05  1:52   ` Joe Perches
2010-09-23 11:36   ` Jiri Kosina
2010-09-05  1:52 ` [PATCH 02/13] drivers/infiniband: " Joe Perches
     [not found]   ` <a13edeb14cc926b71e21daff892acbe2d76313ab.1283650107.git.joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
2010-09-07 18:24     ` Ralph Campbell
2010-09-07 18:24       ` Ralph Campbell
     [not found]       ` <1283883869.32259.13.camel-/vjeY7uYZjrPXfVEPVhPGq6RkeBMCJyt@public.gmane.org>
2010-09-23 11:38         ` Jiri Kosina
2010-09-23 11:38           ` Jiri Kosina
2010-10-06 21:44     ` Roland Dreier
2010-10-06 21:44       ` Roland Dreier
2010-09-05  1:52 ` [PATCH 03/13] drivers/net/wireless/iwlwifi: " Joe Perches
2010-09-05  1:52 ` [PATCH 04/13] drivers/s390: " Joe Perches
2010-09-23 11:42   ` Jiri Kosina
2010-09-05  1:52 ` [PATCH 05/13] drivers/scsi: " Joe Perches
2010-09-23 11:45   ` Jiri Kosina
2010-09-05  1:52 ` [PATCH 06/13] drivers/staging/lirc: " Joe Perches
2010-09-05  1:52 ` [PATCH 07/13] fs/ecryptfs: " Joe Perches
2010-09-23 11:31   ` Jiri Kosina
2010-09-05  1:52 ` [PATCH 08/13] fs/seq_file.c: " Joe Perches
2010-09-23 11:29   ` Jiri Kosina [this message]
2010-09-05  1:52 ` [PATCH 09/13] kernel/pm_qos_params.c: " Joe Perches
2010-09-23 11:34   ` Jiri Kosina
2010-09-05  1:52 ` [PATCH 10/13] kernel/trace: " Joe Perches
2010-09-23 11:37   ` Jiri Kosina
2010-09-05  1:52 ` [PATCH 11/13] net/ipv4: " Joe Perches
2010-09-07  1:30   ` David Miller
2010-09-07  1:47     ` David Miller
2010-09-07  5:01       ` [PATCH net-next] include/net/raw.h: Convert raw_seq_private macro to inline Joe Perches
2010-09-07 15:37         ` Nick Bowler
2010-09-07 15:55           ` [PATCH V2 " Joe Perches
2010-09-08 20:42             ` David Miller
2010-09-05  1:52 ` [PATCH 12/13] net/sunrpc/rpc_pipe.c: Remove unnecessary casts of private_data Joe Perches
2010-09-23 11:40   ` Jiri Kosina
2010-09-23 11:40     ` Jiri Kosina
2010-09-05  1:52 ` [PATCH 13/13] sound: " Joe Perches
2010-09-07  6:10   ` Takashi Iwai
2010-09-07  6:10     ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LNX.2.00.1009231328250.26813@pobox.suse.cz \
    --to=jkosina@suse.cz \
    --cc=joe@perches.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.