From: Jiri Kosina <jkosina@suse.cz>
To: Joe Perches <joe@perches.com>
Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
linux390@de.ibm.com, linux-s390@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 04/13] drivers/s390: Remove unnecessary casts of private_data
Date: Thu, 23 Sep 2010 13:42:01 +0200 (CEST) [thread overview]
Message-ID: <alpine.LNX.2.00.1009231341490.26813@pobox.suse.cz> (raw)
In-Reply-To: <ffd65b5efc206c3bb180addeeab41a26f15991a7.1283650107.git.joe@perches.com>
On Sat, 4 Sep 2010, Joe Perches wrote:
> Signed-off-by: Joe Perches <joe@perches.com>
> ---
> drivers/s390/char/vmcp.c | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/s390/char/vmcp.c b/drivers/s390/char/vmcp.c
> index 04e532e..19a14d9 100644
> --- a/drivers/s390/char/vmcp.c
> +++ b/drivers/s390/char/vmcp.c
> @@ -47,7 +47,7 @@ static int vmcp_release(struct inode *inode, struct file *file)
> {
> struct vmcp_session *session;
>
> - session = (struct vmcp_session *)file->private_data;
> + session = file->private_data;
> file->private_data = NULL;
> free_pages((unsigned long)session->response, get_order(session->bufsize));
> kfree(session);
> @@ -94,7 +94,7 @@ vmcp_write(struct file *file, const char __user *buff, size_t count,
> return -EFAULT;
> }
> cmd[count] = '\0';
> - session = (struct vmcp_session *)file->private_data;
> + session = file->private_data;
> if (mutex_lock_interruptible(&session->mutex)) {
> kfree(cmd);
> return -ERESTARTSYS;
> @@ -136,7 +136,7 @@ static long vmcp_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
> int __user *argp;
> int temp;
>
> - session = (struct vmcp_session *)file->private_data;
> + session = file->private_data;
> if (is_compat_task())
> argp = compat_ptr(arg);
> else
Not present in linux-next as of today. Applied, thanks.
--
Jiri Kosina
SUSE Labs, Novell Inc.
next prev parent reply other threads:[~2010-09-23 11:42 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-05 1:52 [PATCH 00/13] trivial: Remove unnecessary casts of private_data Joe Perches
2010-09-05 1:52 ` Joe Perches
2010-09-05 1:52 ` [PATCH 01/13] drivers/gpu/drm: " Joe Perches
2010-09-05 1:52 ` Joe Perches
2010-09-23 11:36 ` Jiri Kosina
2010-09-05 1:52 ` [PATCH 02/13] drivers/infiniband: " Joe Perches
[not found] ` <a13edeb14cc926b71e21daff892acbe2d76313ab.1283650107.git.joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
2010-09-07 18:24 ` Ralph Campbell
2010-09-07 18:24 ` Ralph Campbell
[not found] ` <1283883869.32259.13.camel-/vjeY7uYZjrPXfVEPVhPGq6RkeBMCJyt@public.gmane.org>
2010-09-23 11:38 ` Jiri Kosina
2010-09-23 11:38 ` Jiri Kosina
2010-10-06 21:44 ` Roland Dreier
2010-10-06 21:44 ` Roland Dreier
2010-09-05 1:52 ` [PATCH 03/13] drivers/net/wireless/iwlwifi: " Joe Perches
2010-09-05 1:52 ` [PATCH 04/13] drivers/s390: " Joe Perches
2010-09-23 11:42 ` Jiri Kosina [this message]
2010-09-05 1:52 ` [PATCH 05/13] drivers/scsi: " Joe Perches
2010-09-23 11:45 ` Jiri Kosina
2010-09-05 1:52 ` [PATCH 06/13] drivers/staging/lirc: " Joe Perches
2010-09-05 1:52 ` [PATCH 07/13] fs/ecryptfs: " Joe Perches
2010-09-23 11:31 ` Jiri Kosina
2010-09-05 1:52 ` [PATCH 08/13] fs/seq_file.c: " Joe Perches
2010-09-23 11:29 ` Jiri Kosina
2010-09-05 1:52 ` [PATCH 09/13] kernel/pm_qos_params.c: " Joe Perches
2010-09-23 11:34 ` Jiri Kosina
2010-09-05 1:52 ` [PATCH 10/13] kernel/trace: " Joe Perches
2010-09-23 11:37 ` Jiri Kosina
2010-09-05 1:52 ` [PATCH 11/13] net/ipv4: " Joe Perches
2010-09-07 1:30 ` David Miller
2010-09-07 1:47 ` David Miller
2010-09-07 5:01 ` [PATCH net-next] include/net/raw.h: Convert raw_seq_private macro to inline Joe Perches
2010-09-07 15:37 ` Nick Bowler
2010-09-07 15:55 ` [PATCH V2 " Joe Perches
2010-09-08 20:42 ` David Miller
2010-09-05 1:52 ` [PATCH 12/13] net/sunrpc/rpc_pipe.c: Remove unnecessary casts of private_data Joe Perches
2010-09-23 11:40 ` Jiri Kosina
2010-09-23 11:40 ` Jiri Kosina
2010-09-05 1:52 ` [PATCH 13/13] sound: " Joe Perches
2010-09-07 6:10 ` Takashi Iwai
2010-09-07 6:10 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.00.1009231341490.26813@pobox.suse.cz \
--to=jkosina@suse.cz \
--cc=heiko.carstens@de.ibm.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux390@de.ibm.com \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.