[PATCH 05/17][trivial] drivers/message/, i2o: Remove unnecessary casts of void ptr returning alloc function return values

[PATCH 05/17][trivial] drivers/message/, i2o: Remove unnecessary casts of void ptr returning alloc function return values

[Jesper Juhl]

Hi,

The [vk][cmz]alloc(_node) family of functions return void pointers which
it's completely unnecessary/pointless to cast to other pointer types since
that happens implicitly.

This patch removes such casts from drivers/message/


Signed-off-by: Jesper Juhl <jj@chaosbits.net>
---
 i2o_config.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/message/i2o/i2o_config.c b/drivers/message/i2o/i2o_config.c
index 7d3cc57..098de2b 100644
--- a/drivers/message/i2o/i2o_config.c
+++ b/drivers/message/i2o/i2o_config.c
@@ -1044,8 +1044,7 @@ static long i2o_cfg_ioctl(struct file *fp, unsigned int cmd, unsigned long arg)
 
 static int cfg_open(struct inode *inode, struct file *file)
 {
-	struct i2o_cfg_info *tmp =
-	    (struct i2o_cfg_info *)kmalloc(sizeof(struct i2o_cfg_info),
+	struct i2o_cfg_info *tmp = kmalloc(sizeof(struct i2o_cfg_info),
 					   GFP_KERNEL);
 	unsigned long flags;
 


-- 
Jesper Juhl <jj@chaosbits.net>             http://www.chaosbits.net/
Don't top-post  http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please.

Re: [PATCH 05/17][trivial] drivers/message/, i2o: Remove unnecessary casts of void ptr returning alloc function return values

[Jiri Kosina]

On Tue, 9 Nov 2010, Jesper Juhl wrote:

> The [vk][cmz]alloc(_node) family of functions return void pointers which
> it's completely unnecessary/pointless to cast to other pointer types since
> that happens implicitly.
> 
> This patch removes such casts from drivers/message/
> 
> 
> Signed-off-by: Jesper Juhl <jj@chaosbits.net>
> ---
>  i2o_config.c |    3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/message/i2o/i2o_config.c b/drivers/message/i2o/i2o_config.c
> index 7d3cc57..098de2b 100644
> --- a/drivers/message/i2o/i2o_config.c
> +++ b/drivers/message/i2o/i2o_config.c
> @@ -1044,8 +1044,7 @@ static long i2o_cfg_ioctl(struct file *fp, unsigned int cmd, unsigned long arg)
>  
>  static int cfg_open(struct inode *inode, struct file *file)
>  {
> -	struct i2o_cfg_info *tmp =
> -	    (struct i2o_cfg_info *)kmalloc(sizeof(struct i2o_cfg_info),
> +	struct i2o_cfg_info *tmp = kmalloc(sizeof(struct i2o_cfg_info),
>  					   GFP_KERNEL);
>  	unsigned long flags;

Not present in linux-next as of today. Applied, thanks Jesper.

-- 
Jiri Kosina
SUSE Labs, Novell Inc.