* [PATCH] MMC, USHC: Don't double include usb.h in ushc.c
@ 2011-01-24 20:59 Jesper Juhl
2011-01-24 21:02 ` Chris Ball
0 siblings, 1 reply; 5+ messages in thread
From: Jesper Juhl @ 2011-01-24 20:59 UTC (permalink / raw)
To: linux-mmc; +Cc: linux-kernel, David Vrabel, Axel Lin, Chris Ball, trivial
We include linux/usb.h twice in drivers/mmc/host/ushc.c - once is enough.
Signed-off-by: Jesper Juhl <jj@chaosbits.net>
---
ushc.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/mmc/host/ushc.c b/drivers/mmc/host/ushc.c
index f8f65df..f08f944 100644
--- a/drivers/mmc/host/ushc.c
+++ b/drivers/mmc/host/ushc.c
@@ -19,7 +19,6 @@
#include <linux/module.h>
#include <linux/usb.h>
#include <linux/kernel.h>
-#include <linux/usb.h>
#include <linux/slab.h>
#include <linux/dma-mapping.h>
#include <linux/mmc/host.h>
--
Jesper Juhl <jj@chaosbits.net> http://www.chaosbits.net/
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please.
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] MMC, USHC: Don't double include usb.h in ushc.c
2011-01-24 20:59 [PATCH] MMC, USHC: Don't double include usb.h in ushc.c Jesper Juhl
@ 2011-01-24 21:02 ` Chris Ball
2011-01-24 21:05 ` Jesper Juhl
0 siblings, 1 reply; 5+ messages in thread
From: Chris Ball @ 2011-01-24 21:02 UTC (permalink / raw)
To: Jesper Juhl; +Cc: linux-mmc, linux-kernel, David Vrabel, Axel Lin, trivial
Jesper,
On Mon, Jan 24, 2011 at 09:59:25PM +0100, Jesper Juhl wrote:
> We include linux/usb.h twice in drivers/mmc/host/ushc.c - once is enough.
>
> Signed-off-by: Jesper Juhl <jj@chaosbits.net>
> ---
> ushc.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/mmc/host/ushc.c b/drivers/mmc/host/ushc.c
> index f8f65df..f08f944 100644
> --- a/drivers/mmc/host/ushc.c
> +++ b/drivers/mmc/host/ushc.c
> @@ -19,7 +19,6 @@
> #include <linux/module.h>
> #include <linux/usb.h>
> #include <linux/kernel.h>
> -#include <linux/usb.h>
> #include <linux/slab.h>
> #include <linux/dma-mapping.h>
> #include <linux/mmc/host.h>
>
I've already replied to you ACKing this patch, and pushed it to mmc-next.
Thanks,
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] MMC, USHC: Don't double include usb.h in ushc.c
2011-01-24 21:02 ` Chris Ball
@ 2011-01-24 21:05 ` Jesper Juhl
2011-01-24 21:06 ` Chris Ball
0 siblings, 1 reply; 5+ messages in thread
From: Jesper Juhl @ 2011-01-24 21:05 UTC (permalink / raw)
To: Chris Ball; +Cc: linux-mmc, linux-kernel, David Vrabel, Axel Lin, trivial
On Mon, 24 Jan 2011, Chris Ball wrote:
> Jesper,
>
> On Mon, Jan 24, 2011 at 09:59:25PM +0100, Jesper Juhl wrote:
> > We include linux/usb.h twice in drivers/mmc/host/ushc.c - once is enough.
> >
> > Signed-off-by: Jesper Juhl <jj@chaosbits.net>
> > ---
> > ushc.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/mmc/host/ushc.c b/drivers/mmc/host/ushc.c
> > index f8f65df..f08f944 100644
> > --- a/drivers/mmc/host/ushc.c
> > +++ b/drivers/mmc/host/ushc.c
> > @@ -19,7 +19,6 @@
> > #include <linux/module.h>
> > #include <linux/usb.h>
> > #include <linux/kernel.h>
> > -#include <linux/usb.h>
> > #include <linux/slab.h>
> > #include <linux/dma-mapping.h>
> > #include <linux/mmc/host.h>
> >
>
> I've already replied to you ACKing this patch, and pushed it to mmc-next.
>
Odd, I don't see that in my mailbox :-( But then I've had a few incidents
of being bling in that regard lately, so it's probably my fault. Sorry.
--
Jesper Juhl <jj@chaosbits.net> http://www.chaosbits.net/
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] MMC, USHC: Don't double include usb.h in ushc.c
2011-01-24 21:05 ` Jesper Juhl
@ 2011-01-24 21:06 ` Chris Ball
2011-01-24 21:14 ` Jesper Juhl
0 siblings, 1 reply; 5+ messages in thread
From: Chris Ball @ 2011-01-24 21:06 UTC (permalink / raw)
To: Jesper Juhl; +Cc: linux-mmc, linux-kernel, David Vrabel, Axel Lin, trivial
Hi,
On Mon, Jan 24, 2011 at 10:05:05PM +0100, Jesper Juhl wrote:
> > I've already replied to you ACKing this patch, and pushed it to mmc-next.
> >
> Odd, I don't see that in my mailbox :-( But then I've had a few incidents
> of being bling in that regard lately, so it's probably my fault. Sorry.
It's okay. Here's an archive of the thread:
https://patchwork.kernel.org/patch/469621/
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] MMC, USHC: Don't double include usb.h in ushc.c
2011-01-24 21:06 ` Chris Ball
@ 2011-01-24 21:14 ` Jesper Juhl
0 siblings, 0 replies; 5+ messages in thread
From: Jesper Juhl @ 2011-01-24 21:14 UTC (permalink / raw)
To: Chris Ball; +Cc: linux-mmc, linux-kernel, David Vrabel, Axel Lin, trivial
On Mon, 24 Jan 2011, Chris Ball wrote:
> Hi,
>
> On Mon, Jan 24, 2011 at 10:05:05PM +0100, Jesper Juhl wrote:
> > > I've already replied to you ACKing this patch, and pushed it to mmc-next.
> > >
> > Odd, I don't see that in my mailbox :-( But then I've had a few incidents
> > of being bling in that regard lately, so it's probably my fault. Sorry.
>
> It's okay. Here's an archive of the thread:
> https://patchwork.kernel.org/patch/469621/
>
Argh, reading it again I clearly remember that mail exchange. Must have
deleted it from my mailbox by accident.
--
Jesper Juhl <jj@chaosbits.net> http://www.chaosbits.net/
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2011-01-24 21:13 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-01-24 20:59 [PATCH] MMC, USHC: Don't double include usb.h in ushc.c Jesper Juhl
2011-01-24 21:02 ` Chris Ball
2011-01-24 21:05 ` Jesper Juhl
2011-01-24 21:06 ` Chris Ball
2011-01-24 21:14 ` Jesper Juhl
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.