All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH -next] HID: steelseries: use module_hid_driver() to simplify the code
@ 2013-03-15 15:07 Wei Yongjun
  2013-03-18  9:53 ` Jiri Kosina
  0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2013-03-15 15:07 UTC (permalink / raw)
  To: jkosina; +Cc: yongjun_wei, linux-input

From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>

module_hid_driver() makes the code simpler by eliminating
boilerplate code..

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
---
 drivers/hid/hid-steelseries.c | 13 +------------
 1 file changed, 1 insertion(+), 12 deletions(-)

diff --git a/drivers/hid/hid-steelseries.c b/drivers/hid/hid-steelseries.c
index 98e66ac..9b0efb0 100644
--- a/drivers/hid/hid-steelseries.c
+++ b/drivers/hid/hid-steelseries.c
@@ -377,16 +377,5 @@ static struct hid_driver steelseries_srws1_driver = {
 	.report_fixup = steelseries_srws1_report_fixup
 };
 
-static int __init steelseries_srws1_init(void)
-{
-	return hid_register_driver(&steelseries_srws1_driver);
-}
-
-static void __exit steelseries_srws1_exit(void)
-{
-	hid_unregister_driver(&steelseries_srws1_driver);
-}
-
-module_init(steelseries_srws1_init);
-module_exit(steelseries_srws1_exit);
+module_hid_driver(steelseries_srws1_driver);
 MODULE_LICENSE("GPL");


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH -next] HID: steelseries: use module_hid_driver() to simplify the code
  2013-03-15 15:07 [PATCH -next] HID: steelseries: use module_hid_driver() to simplify the code Wei Yongjun
@ 2013-03-18  9:53 ` Jiri Kosina
  0 siblings, 0 replies; 2+ messages in thread
From: Jiri Kosina @ 2013-03-18  9:53 UTC (permalink / raw)
  To: Wei Yongjun; +Cc: yongjun_wei, linux-input

On Fri, 15 Mar 2013, Wei Yongjun wrote:

> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> 
> module_hid_driver() makes the code simpler by eliminating
> boilerplate code..
> 
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> ---
>  drivers/hid/hid-steelseries.c | 13 +------------
>  1 file changed, 1 insertion(+), 12 deletions(-)
> 
> diff --git a/drivers/hid/hid-steelseries.c b/drivers/hid/hid-steelseries.c
> index 98e66ac..9b0efb0 100644
> --- a/drivers/hid/hid-steelseries.c
> +++ b/drivers/hid/hid-steelseries.c
> @@ -377,16 +377,5 @@ static struct hid_driver steelseries_srws1_driver = {
>  	.report_fixup = steelseries_srws1_report_fixup
>  };
>  
> -static int __init steelseries_srws1_init(void)
> -{
> -	return hid_register_driver(&steelseries_srws1_driver);
> -}
> -
> -static void __exit steelseries_srws1_exit(void)
> -{
> -	hid_unregister_driver(&steelseries_srws1_driver);
> -}
> -
> -module_init(steelseries_srws1_init);
> -module_exit(steelseries_srws1_exit);
> +module_hid_driver(steelseries_srws1_driver);
>  MODULE_LICENSE("GPL");

Applied, thanks.

-- 
Jiri Kosina
SUSE Labs

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-03-18  9:53 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-03-15 15:07 [PATCH -next] HID: steelseries: use module_hid_driver() to simplify the code Wei Yongjun
2013-03-18  9:53 ` Jiri Kosina

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.