* [PATCH] Input: wacom - Fix compiler warning if !CONFIG_PM
@ 2014-08-09 17:07 Geert Uytterhoeven
2014-08-09 20:39 ` Jiri Kosina
0 siblings, 1 reply; 7+ messages in thread
From: Geert Uytterhoeven @ 2014-08-09 17:07 UTC (permalink / raw)
To: Jiri Kosina; +Cc: linux-input, linux-kernel, Geert Uytterhoeven
If CONFIG_PM is not set:
drivers/hid/wacom_sys.c:1436: warning: ‘wacom_reset_resume’ defined but
not used
Protect the unused functions by #ifdef CONFIG_PM to fix this.
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
drivers/hid/wacom_sys.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/hid/wacom_sys.c b/drivers/hid/wacom_sys.c
index 3e388ec31da8..f0db7eca9023 100644
--- a/drivers/hid/wacom_sys.c
+++ b/drivers/hid/wacom_sys.c
@@ -1416,6 +1416,7 @@ static void wacom_remove(struct hid_device *hdev)
kfree(wacom);
}
+#ifdef CONFIG_PM
static int wacom_resume(struct hid_device *hdev)
{
struct wacom *wacom = hid_get_drvdata(hdev);
@@ -1436,6 +1437,7 @@ static int wacom_reset_resume(struct hid_device *hdev)
{
return wacom_resume(hdev);
}
+#endif /* CONFIG_PM */
static struct hid_driver wacom_driver = {
.name = "wacom",
--
1.9.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] Input: wacom - Fix compiler warning if !CONFIG_PM
2014-08-09 17:07 [PATCH] Input: wacom - Fix compiler warning if !CONFIG_PM Geert Uytterhoeven
@ 2014-08-09 20:39 ` Jiri Kosina
0 siblings, 0 replies; 7+ messages in thread
From: Jiri Kosina @ 2014-08-09 20:39 UTC (permalink / raw)
To: Geert Uytterhoeven, Dmitry Torokhov
Cc: linux-input, linux-kernel, Benjamin Tissoires
On Sat, 9 Aug 2014, Geert Uytterhoeven wrote:
> If CONFIG_PM is not set:
>
> drivers/hid/wacom_sys.c:1436: warning: ‘wacom_reset_resume’ defined but
> not used
>
> Protect the unused functions by #ifdef CONFIG_PM to fix this.
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Thanks Geert.
hid-wacom is in a sort of temporary mode of operation, being moved from
Input to HID driver.
Adding Benjamin and Dmitry to CC, as this will likely still go through
Dmitry's queue.
> ---
> drivers/hid/wacom_sys.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/hid/wacom_sys.c b/drivers/hid/wacom_sys.c
> index 3e388ec31da8..f0db7eca9023 100644
> --- a/drivers/hid/wacom_sys.c
> +++ b/drivers/hid/wacom_sys.c
> @@ -1416,6 +1416,7 @@ static void wacom_remove(struct hid_device *hdev)
> kfree(wacom);
> }
>
> +#ifdef CONFIG_PM
> static int wacom_resume(struct hid_device *hdev)
> {
> struct wacom *wacom = hid_get_drvdata(hdev);
> @@ -1436,6 +1437,7 @@ static int wacom_reset_resume(struct hid_device *hdev)
> {
> return wacom_resume(hdev);
> }
> +#endif /* CONFIG_PM */
>
> static struct hid_driver wacom_driver = {
> .name = "wacom",
> --
> 1.9.1
>
--
Jiri Kosina
SUSE Labs
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] Input: wacom - Fix compiler warning if !CONFIG_PM
@ 2014-08-09 20:39 ` Jiri Kosina
0 siblings, 0 replies; 7+ messages in thread
From: Jiri Kosina @ 2014-08-09 20:39 UTC (permalink / raw)
To: Geert Uytterhoeven, Dmitry Torokhov
Cc: linux-input, linux-kernel, Benjamin Tissoires
On Sat, 9 Aug 2014, Geert Uytterhoeven wrote:
> If CONFIG_PM is not set:
>
> drivers/hid/wacom_sys.c:1436: warning: ‘wacom_reset_resume’ defined but
> not used
>
> Protect the unused functions by #ifdef CONFIG_PM to fix this.
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Thanks Geert.
hid-wacom is in a sort of temporary mode of operation, being moved from
Input to HID driver.
Adding Benjamin and Dmitry to CC, as this will likely still go through
Dmitry's queue.
> ---
> drivers/hid/wacom_sys.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/hid/wacom_sys.c b/drivers/hid/wacom_sys.c
> index 3e388ec31da8..f0db7eca9023 100644
> --- a/drivers/hid/wacom_sys.c
> +++ b/drivers/hid/wacom_sys.c
> @@ -1416,6 +1416,7 @@ static void wacom_remove(struct hid_device *hdev)
> kfree(wacom);
> }
>
> +#ifdef CONFIG_PM
> static int wacom_resume(struct hid_device *hdev)
> {
> struct wacom *wacom = hid_get_drvdata(hdev);
> @@ -1436,6 +1437,7 @@ static int wacom_reset_resume(struct hid_device *hdev)
> {
> return wacom_resume(hdev);
> }
> +#endif /* CONFIG_PM */
>
> static struct hid_driver wacom_driver = {
> .name = "wacom",
> --
> 1.9.1
>
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] Input: wacom - Fix compiler warning if !CONFIG_PM
2014-08-09 20:39 ` Jiri Kosina
@ 2014-08-11 14:42 ` Benjamin Tissoires
-1 siblings, 0 replies; 7+ messages in thread
From: Benjamin Tissoires @ 2014-08-11 14:42 UTC (permalink / raw)
To: Jiri Kosina
Cc: Geert Uytterhoeven, Dmitry Torokhov, linux-input, linux-kernel
On Aug 09 2014 or thereabouts, Jiri Kosina wrote:
> On Sat, 9 Aug 2014, Geert Uytterhoeven wrote:
>
> > If CONFIG_PM is not set:
> >
> > drivers/hid/wacom_sys.c:1436: warning: ‘wacom_reset_resume’ defined but
> > not used
> >
> > Protect the unused functions by #ifdef CONFIG_PM to fix this.
> >
> > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
>
> Thanks Geert.
>
> hid-wacom is in a sort of temporary mode of operation, being moved from
> Input to HID driver.
>
> Adding Benjamin and Dmitry to CC, as this will likely still go through
> Dmitry's queue.
>
Thanks for fixing this Geert.
Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cheers,
Benjamin
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] Input: wacom - Fix compiler warning if !CONFIG_PM
@ 2014-08-11 14:42 ` Benjamin Tissoires
0 siblings, 0 replies; 7+ messages in thread
From: Benjamin Tissoires @ 2014-08-11 14:42 UTC (permalink / raw)
To: Jiri Kosina
Cc: Geert Uytterhoeven, Dmitry Torokhov, linux-input, linux-kernel
On Aug 09 2014 or thereabouts, Jiri Kosina wrote:
> On Sat, 9 Aug 2014, Geert Uytterhoeven wrote:
>
> > If CONFIG_PM is not set:
> >
> > drivers/hid/wacom_sys.c:1436: warning: ‘wacom_reset_resume’ defined but
> > not used
> >
> > Protect the unused functions by #ifdef CONFIG_PM to fix this.
> >
> > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
>
> Thanks Geert.
>
> hid-wacom is in a sort of temporary mode of operation, being moved from
> Input to HID driver.
>
> Adding Benjamin and Dmitry to CC, as this will likely still go through
> Dmitry's queue.
>
Thanks for fixing this Geert.
Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cheers,
Benjamin
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] Input: wacom - Fix compiler warning if !CONFIG_PM
2014-08-11 14:42 ` Benjamin Tissoires
@ 2014-08-12 17:00 ` Dmitry Torokhov
-1 siblings, 0 replies; 7+ messages in thread
From: Dmitry Torokhov @ 2014-08-12 17:00 UTC (permalink / raw)
To: Benjamin Tissoires
Cc: Jiri Kosina, Geert Uytterhoeven, linux-input, linux-kernel
On Mon, Aug 11, 2014 at 10:42:38AM -0400, Benjamin Tissoires wrote:
> On Aug 09 2014 or thereabouts, Jiri Kosina wrote:
> > On Sat, 9 Aug 2014, Geert Uytterhoeven wrote:
> >
> > > If CONFIG_PM is not set:
> > >
> > > drivers/hid/wacom_sys.c:1436: warning: ‘wacom_reset_resume’ defined but
> > > not used
> > >
> > > Protect the unused functions by #ifdef CONFIG_PM to fix this.
> > >
> > > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> >
> > Thanks Geert.
> >
> > hid-wacom is in a sort of temporary mode of operation, being moved from
> > Input to HID driver.
> >
> > Adding Benjamin and Dmitry to CC, as this will likely still go through
> > Dmitry's queue.
> >
>
> Thanks for fixing this Geert.
>
> Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Applied, thank you.
--
Dmitry
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] Input: wacom - Fix compiler warning if !CONFIG_PM
@ 2014-08-12 17:00 ` Dmitry Torokhov
0 siblings, 0 replies; 7+ messages in thread
From: Dmitry Torokhov @ 2014-08-12 17:00 UTC (permalink / raw)
To: Benjamin Tissoires
Cc: Jiri Kosina, Geert Uytterhoeven, linux-input, linux-kernel
On Mon, Aug 11, 2014 at 10:42:38AM -0400, Benjamin Tissoires wrote:
> On Aug 09 2014 or thereabouts, Jiri Kosina wrote:
> > On Sat, 9 Aug 2014, Geert Uytterhoeven wrote:
> >
> > > If CONFIG_PM is not set:
> > >
> > > drivers/hid/wacom_sys.c:1436: warning: ‘wacom_reset_resume’ defined but
> > > not used
> > >
> > > Protect the unused functions by #ifdef CONFIG_PM to fix this.
> > >
> > > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> >
> > Thanks Geert.
> >
> > hid-wacom is in a sort of temporary mode of operation, being moved from
> > Input to HID driver.
> >
> > Adding Benjamin and Dmitry to CC, as this will likely still go through
> > Dmitry's queue.
> >
>
> Thanks for fixing this Geert.
>
> Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Applied, thank you.
--
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2014-08-12 17:00 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-08-09 17:07 [PATCH] Input: wacom - Fix compiler warning if !CONFIG_PM Geert Uytterhoeven
2014-08-09 20:39 ` Jiri Kosina
2014-08-09 20:39 ` Jiri Kosina
2014-08-11 14:42 ` Benjamin Tissoires
2014-08-11 14:42 ` Benjamin Tissoires
2014-08-12 17:00 ` Dmitry Torokhov
2014-08-12 17:00 ` Dmitry Torokhov
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.