* [PATCH] livepatch: fix uninitialized return value
@ 2015-01-20 22:07 Josh Poimboeuf
2015-01-21 8:33 ` Miroslav Benes
2015-01-21 14:24 ` Jiri Kosina
0 siblings, 2 replies; 3+ messages in thread
From: Josh Poimboeuf @ 2015-01-20 22:07 UTC (permalink / raw)
To: Seth Jennings, Jiri Kosina, Vojtech Pavlik; +Cc: live-patching, linux-kernel
Fix a potentially uninitialized return value.
Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
---
kernel/livepatch/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/livepatch/core.c b/kernel/livepatch/core.c
index bc05d39..9adf86b 100644
--- a/kernel/livepatch/core.c
+++ b/kernel/livepatch/core.c
@@ -410,7 +410,7 @@ static int klp_enable_func(struct klp_func *func)
func->state = KLP_ENABLED;
- return ret;
+ return 0;
err:
list_del_rcu(&func->stack_node);
--
2.1.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] livepatch: fix uninitialized return value
2015-01-20 22:07 [PATCH] livepatch: fix uninitialized return value Josh Poimboeuf
@ 2015-01-21 8:33 ` Miroslav Benes
2015-01-21 14:24 ` Jiri Kosina
1 sibling, 0 replies; 3+ messages in thread
From: Miroslav Benes @ 2015-01-21 8:33 UTC (permalink / raw)
To: Josh Poimboeuf
Cc: Seth Jennings, Jiri Kosina, Vojtech Pavlik, live-patching, linux-kernel
On Tue, 20 Jan 2015, Josh Poimboeuf wrote:
> Fix a potentially uninitialized return value.
>
> Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
Reviewed-by: Miroslav Benes <mbenes@suse.cz>
> ---
> kernel/livepatch/core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/livepatch/core.c b/kernel/livepatch/core.c
> index bc05d39..9adf86b 100644
> --- a/kernel/livepatch/core.c
> +++ b/kernel/livepatch/core.c
> @@ -410,7 +410,7 @@ static int klp_enable_func(struct klp_func *func)
>
> func->state = KLP_ENABLED;
>
> - return ret;
> + return 0;
>
> err:
> list_del_rcu(&func->stack_node);
> --
> 2.1.0
>
> --
> To unsubscribe from this list: send the line "unsubscribe live-patching" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
Miroslav Benes
SUSE Labs
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] livepatch: fix uninitialized return value
2015-01-20 22:07 [PATCH] livepatch: fix uninitialized return value Josh Poimboeuf
2015-01-21 8:33 ` Miroslav Benes
@ 2015-01-21 14:24 ` Jiri Kosina
1 sibling, 0 replies; 3+ messages in thread
From: Jiri Kosina @ 2015-01-21 14:24 UTC (permalink / raw)
To: Josh Poimboeuf; +Cc: Seth Jennings, Vojtech Pavlik, live-patching, linux-kernel
On Tue, 20 Jan 2015, Josh Poimboeuf wrote:
> Fix a potentially uninitialized return value.
>
> Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
Applied and pushed out, thanks.
> ---
> kernel/livepatch/core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/livepatch/core.c b/kernel/livepatch/core.c
> index bc05d39..9adf86b 100644
> --- a/kernel/livepatch/core.c
> +++ b/kernel/livepatch/core.c
> @@ -410,7 +410,7 @@ static int klp_enable_func(struct klp_func *func)
>
> func->state = KLP_ENABLED;
>
> - return ret;
> + return 0;
>
> err:
> list_del_rcu(&func->stack_node);
--
Jiri Kosina
SUSE Labs
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-01-21 14:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-01-20 22:07 [PATCH] livepatch: fix uninitialized return value Josh Poimboeuf
2015-01-21 8:33 ` Miroslav Benes
2015-01-21 14:24 ` Jiri Kosina
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.