All of lore.kernel.org
 help / color / mirror / Atom feed
From: Keith Busch <keith.busch@intel.com>
To: Laszlo Ersek <lersek@redhat.com>
Cc: Keith Busch <keith.busch@intel.com>,
	"Anbazhagan, Baraneedharan" <anbazhagan@hp.com>,
	edk2-devel@lists.sourceforge.net, Feng Tian <feng.tian@intel.com>,
	qemu devel list <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [edk2] NVMe question
Date: Tue, 2 Jun 2015 19:11:28 +0000 (UTC)	[thread overview]
Message-ID: <alpine.LNX.2.00.1506021904310.15930@localhost.lm.intel.com> (raw)
In-Reply-To: <556D5F36.1050907@redhat.com>

Hi,

On Tue, 2 Jun 2015, Laszlo Ersek wrote:
> removed the nonzero initialization of Cc.Iosqes (submission queue size?)
> and Cc.Iocqes (completion queue size?) in function
> NvmeEnableController(). And the removal of these field initializations
> seems to cause the early sanity check in QEMU's nvme_start_ctrl() to
> fail -- my guess at least.
>
> The question is now if QEMU is right (according to the NVMe spec) to
> require those fields, or if edk2 is right not to initialize them.

The host driver definitely needs to initialize these for the device to
understand the queue's entry sizes. Without proper values, it would have
no idea how much memory a queue occupies. If you have a real device that
ignores these, it's breaking spec.

  reply	other threads:[~2015-06-02 19:12 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <8530272280D33D4095B8F02BA1B57BAC3AFD753D@G9W0345.americas.hpqcorp.net>
     [not found] ` <7F1BAD85ADEA444D97065A60D2E97EE501D6A4BB@SHSMSX101.ccr.corp.intel.com>
     [not found]   ` <8530272280D33D4095B8F02BA1B57BAC3AFD9AB1@G9W0345.americas.hpqcorp.net>
     [not found]     ` <7F1BAD85ADEA444D97065A60D2E97EE501D6AB7C@SHSMSX101.ccr.corp.intel.com>
2015-06-02  7:45       ` [Qemu-devel] [edk2] NVMe question Laszlo Ersek
2015-06-02 19:11         ` Keith Busch [this message]
2015-06-03  0:21           ` Tian, Feng
2015-06-03 14:46             ` Busch, Keith
2015-06-04  2:04               ` Tian, Feng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LNX.2.00.1506021904310.15930@localhost.lm.intel.com \
    --to=keith.busch@intel.com \
    --cc=anbazhagan@hp.com \
    --cc=edk2-devel@lists.sourceforge.net \
    --cc=feng.tian@intel.com \
    --cc=lersek@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.