All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] xfs: clear PF_NOFREEZE for xfsaild kthread
@ 2015-10-26  6:53 ` Jiri Kosina
  0 siblings, 0 replies; 4+ messages in thread
From: Jiri Kosina @ 2015-10-26  6:53 UTC (permalink / raw)
  To: Dave Chinner, Christoph Hellwig; +Cc: xfs, linux-kernel

From: Jiri Kosina <jkosina@suse.cz>

Since xfsaild has been converted to kthread in 0030807c, it calls 
try_to_freeze() during every AIL push iteration. It however doesn't set 
itself as freezable, and therefore this try_to_freeze() will never do 
anything.

Before (hopefully eventually) kthread freezing gets converted to fileystem 
freezing, we'd rather mark xfsaild freezable (as it can generate I/O 
during suspend).

Signed-off-by: Jiri Kosina <jkosina@suse.cz>
---
 fs/xfs/xfs_trans_ail.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/fs/xfs/xfs_trans_ail.c b/fs/xfs/xfs_trans_ail.c
index 1098cf4..06d1a29 100644
--- a/fs/xfs/xfs_trans_ail.c
+++ b/fs/xfs/xfs_trans_ail.c
@@ -497,6 +497,7 @@ xfsaild(
 	long		tout = 0;	/* milliseconds */
 
 	current->flags |= PF_MEMALLOC;
+	set_freezable();
 
 	while (!kthread_should_stop()) {
 		if (tout && tout <= 20)
-- 
Jiri Kosina
SUSE Labs


^ permalink raw reply related	[flat|nested] 4+ messages in thread
* [PATCH] xfs: clear PF_NOFREEZE for xfsaild kthread
@ 2015-10-26  6:53 ` Jiri Kosina
  0 siblings, 0 replies; 4+ messages in thread
From: Jiri Kosina @ 2015-10-26  6:53 UTC (permalink / raw)
  To: Dave Chinner, Christoph Hellwig; +Cc: linux-kernel, xfs

From: Jiri Kosina <jkosina@suse.cz>

Since xfsaild has been converted to kthread in 0030807c, it calls 
try_to_freeze() during every AIL push iteration. It however doesn't set 
itself as freezable, and therefore this try_to_freeze() will never do 
anything.

Before (hopefully eventually) kthread freezing gets converted to fileystem 
freezing, we'd rather mark xfsaild freezable (as it can generate I/O 
during suspend).

Signed-off-by: Jiri Kosina <jkosina@suse.cz>
---
 fs/xfs/xfs_trans_ail.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/fs/xfs/xfs_trans_ail.c b/fs/xfs/xfs_trans_ail.c
index 1098cf4..06d1a29 100644
--- a/fs/xfs/xfs_trans_ail.c
+++ b/fs/xfs/xfs_trans_ail.c
@@ -497,6 +497,7 @@ xfsaild(
 	long		tout = 0;	/* milliseconds */
 
 	current->flags |= PF_MEMALLOC;
+	set_freezable();
 
 	while (!kthread_should_stop()) {
 		if (tout && tout <= 20)
-- 
Jiri Kosina
SUSE Labs

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH] xfs: clear PF_NOFREEZE for xfsaild kthread
  2015-10-26  6:53 ` Jiri Kosina
@ 2015-10-26 14:08   ` Brian Foster
  -1 siblings, 0 replies; 4+ messages in thread
From: Brian Foster @ 2015-10-26 14:08 UTC (permalink / raw)
  To: Jiri Kosina; +Cc: Dave Chinner, Christoph Hellwig, linux-kernel, xfs

On Mon, Oct 26, 2015 at 03:53:40PM +0900, Jiri Kosina wrote:
> From: Jiri Kosina <jkosina@suse.cz>
> 
> Since xfsaild has been converted to kthread in 0030807c, it calls 
> try_to_freeze() during every AIL push iteration. It however doesn't set 
> itself as freezable, and therefore this try_to_freeze() will never do 
> anything.
> 
> Before (hopefully eventually) kthread freezing gets converted to fileystem 
> freezing, we'd rather mark xfsaild freezable (as it can generate I/O 
> during suspend).
> 
> Signed-off-by: Jiri Kosina <jkosina@suse.cz>
> ---

Looks fine to me:

Reviewed-by: Brian Foster <bfoster@redhat.com>

>  fs/xfs/xfs_trans_ail.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/fs/xfs/xfs_trans_ail.c b/fs/xfs/xfs_trans_ail.c
> index 1098cf4..06d1a29 100644
> --- a/fs/xfs/xfs_trans_ail.c
> +++ b/fs/xfs/xfs_trans_ail.c
> @@ -497,6 +497,7 @@ xfsaild(
>  	long		tout = 0;	/* milliseconds */
>  
>  	current->flags |= PF_MEMALLOC;
> +	set_freezable();
>  
>  	while (!kthread_should_stop()) {
>  		if (tout && tout <= 20)
> -- 
> Jiri Kosina
> SUSE Labs
> 
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] xfs: clear PF_NOFREEZE for xfsaild kthread
@ 2015-10-26 14:08   ` Brian Foster
  0 siblings, 0 replies; 4+ messages in thread
From: Brian Foster @ 2015-10-26 14:08 UTC (permalink / raw)
  To: Jiri Kosina; +Cc: xfs, Christoph Hellwig, linux-kernel

On Mon, Oct 26, 2015 at 03:53:40PM +0900, Jiri Kosina wrote:
> From: Jiri Kosina <jkosina@suse.cz>
> 
> Since xfsaild has been converted to kthread in 0030807c, it calls 
> try_to_freeze() during every AIL push iteration. It however doesn't set 
> itself as freezable, and therefore this try_to_freeze() will never do 
> anything.
> 
> Before (hopefully eventually) kthread freezing gets converted to fileystem 
> freezing, we'd rather mark xfsaild freezable (as it can generate I/O 
> during suspend).
> 
> Signed-off-by: Jiri Kosina <jkosina@suse.cz>
> ---

Looks fine to me:

Reviewed-by: Brian Foster <bfoster@redhat.com>

>  fs/xfs/xfs_trans_ail.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/fs/xfs/xfs_trans_ail.c b/fs/xfs/xfs_trans_ail.c
> index 1098cf4..06d1a29 100644
> --- a/fs/xfs/xfs_trans_ail.c
> +++ b/fs/xfs/xfs_trans_ail.c
> @@ -497,6 +497,7 @@ xfsaild(
>  	long		tout = 0;	/* milliseconds */
>  
>  	current->flags |= PF_MEMALLOC;
> +	set_freezable();
>  
>  	while (!kthread_should_stop()) {
>  		if (tout && tout <= 20)
> -- 
> Jiri Kosina
> SUSE Labs
> 
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-10-26 14:09 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-10-26  6:53 [PATCH] xfs: clear PF_NOFREEZE for xfsaild kthread Jiri Kosina
2015-10-26  6:53 ` Jiri Kosina
2015-10-26 14:08 ` Brian Foster
2015-10-26 14:08   ` Brian Foster

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.