Re: [PATCH] HID: Check whether if the hidraw is NULL pointer before release.

Re: [PATCH] HID: Check whether if the hidraw is NULL pointer before release.

[Jiri Kosina]

On Tue, 2 Feb 2016, shenpengru@gmail.com wrote:

> From: shenpengru <shenpengru@xiaomi.com>
> 
> The logic of service which operate hidraw device in user-space may
> not correct, sometimes it may release hidraw dev for more than once.
> In order to prevent this situation, we need to make the driver more
> robust.

Hmm .. how would you call close(fd) twice on the same descriptor and let 
it pass fput()?

I'd like to better understand how we ended up in this situation. Could you 
please provide more details?

Thanks a lot,

-- 
Jiri Kosina
SUSE Labs

Re: [PATCH] HID: Check whether if the hidraw is null pointer before release.

[Jiri Kosina]

On Mon, 1 Feb 2016, shenpengru@gmail.com wrote:

> From: shenpengru <shenpengru@xiaomi.com>

Changelog needs to go here.

Namely -- what bug is being fixed, what effects does it cause and how is 
it possible to trigger it (under which circumstances can we end up with 
null pointer there).

Thanks,

-- 
Jiri Kosina
SUSE Labs