[PATCH] livepatch: robustify klp_register_patch() API error checking

* [PATCH] livepatch: robustify klp_register_patch() API error checking
       [not found] <20160404203426.GA8200@mwanda>
@ 2016-04-07 16:06 ` Jiri Kosina
  2016-04-07 18:04   ` Josh Poimboeuf
                     ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Jiri Kosina @ 2016-04-07 16:06 UTC (permalink / raw)
  To: Dan Carpenter
  Cc: jeyu, Josh Poimboeuf, Miroslav Benes, Petr Mladek, live-patching,
	linux-kernel

From: Jiri Kosina <jkosina@suse.cz>

Commit 425595a7fc20 ("livepatch: reuse module loader code to write 
relocations") adds a possibility of dereferncing pointers supplied by the 
consumer of the livepatch API before sanity (NULL) checking them (patch 
and patch->mod).

Spotted by smatch tool.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
---
 kernel/livepatch/core.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/kernel/livepatch/core.c b/kernel/livepatch/core.c
index eb5db6e..28c37fa 100644
--- a/kernel/livepatch/core.c
+++ b/kernel/livepatch/core.c
@@ -876,6 +876,9 @@ int klp_register_patch(struct klp_patch *patch)
 {
 	int ret;
 
+	if (!patch || !patch->mod)
+		return -EINVAL;
+
 	if (!is_livepatch_module(patch->mod)) {
 		pr_err("module %s is not marked as a livepatch module",
 		       patch->mod->name);
@@ -885,9 +888,6 @@ int klp_register_patch(struct klp_patch *patch)
 	if (!klp_initialized())
 		return -ENODEV;
 
-	if (!patch || !patch->mod)
-		return -EINVAL;
-
 	/*
 	 * A reference is taken on the patch module to prevent it from being
 	 * unloaded.  Right now, we don't allow patch modules to unload since

-- 
Jiri Kosina
SUSE Labs

^ permalink raw reply related	[flat|nested] 4+ messages in thread