* [PATCH] scsi: g_NCR5380: add HAS_IOPORT_MAP dependency
@ 2016-10-18 15:18 Arnd Bergmann
2016-10-18 22:27 ` Finn Thain
2016-10-19 1:10 ` Martin K. Petersen
0 siblings, 2 replies; 3+ messages in thread
From: Arnd Bergmann @ 2016-10-18 15:18 UTC (permalink / raw)
To: James E.J. Bottomley, Martin K. Petersen
Cc: Ondrej Zary, Finn Thain, Arnd Bergmann, Hannes Reinecke,
Hannes Reinicke, linux-scsi, linux-kernel
The driver was changed to call ioport_map, which breaks platforms that
cannot provide this function:
drivers/scsi/g_NCR5380.o: In function `generic_NCR5380_init_one.constprop.0':
g_NCR5380.c:(.text.generic_NCR5380_init_one.constprop.0+0x388): undefined reference to `ioport_map'
This adds a Kconfig dependency.
Fixes: 04c40f82ccc5 ("scsi: g_NCR5380: Merge g_NCR5380 and g_NCR5380_mmio drivers")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/scsi/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig
index 98451fe031a4..3b416c9efe5e 100644
--- a/drivers/scsi/Kconfig
+++ b/drivers/scsi/Kconfig
@@ -744,7 +744,7 @@ config SCSI_ISCI
config SCSI_GENERIC_NCR5380
tristate "Generic NCR5380/53c400 SCSI ISA card support"
- depends on ISA && SCSI
+ depends on ISA && SCSI && HAS_IOPORT_MAP
select SCSI_SPI_ATTRS
---help---
This is a driver for old ISA card SCSI controllers based on a
--
2.9.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] scsi: g_NCR5380: add HAS_IOPORT_MAP dependency
2016-10-18 15:18 [PATCH] scsi: g_NCR5380: add HAS_IOPORT_MAP dependency Arnd Bergmann
@ 2016-10-18 22:27 ` Finn Thain
2016-10-19 1:10 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Finn Thain @ 2016-10-18 22:27 UTC (permalink / raw)
To: Arnd Bergmann
Cc: James E.J. Bottomley, Martin K. Petersen, Ondrej Zary,
Hannes Reinecke, Hannes Reinicke, linux-scsi, linux-kernel
On Tue, 18 Oct 2016, Arnd Bergmann wrote:
> The driver was changed to call ioport_map, which breaks platforms that
> cannot provide this function:
>
> drivers/scsi/g_NCR5380.o: In function `generic_NCR5380_init_one.constprop.0':
> g_NCR5380.c:(.text.generic_NCR5380_init_one.constprop.0+0x388): undefined reference to `ioport_map'
>
> This adds a Kconfig dependency.
>
> Fixes: 04c40f82ccc5 ("scsi: g_NCR5380: Merge g_NCR5380 and g_NCR5380_mmio drivers")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Finn Thain <fthain@telegraphics.com.au>
> ---
> drivers/scsi/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig
> index 98451fe031a4..3b416c9efe5e 100644
> --- a/drivers/scsi/Kconfig
> +++ b/drivers/scsi/Kconfig
> @@ -744,7 +744,7 @@ config SCSI_ISCI
>
> config SCSI_GENERIC_NCR5380
> tristate "Generic NCR5380/53c400 SCSI ISA card support"
> - depends on ISA && SCSI
> + depends on ISA && SCSI && HAS_IOPORT_MAP
> select SCSI_SPI_ATTRS
> ---help---
> This is a driver for old ISA card SCSI controllers based on a
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] scsi: g_NCR5380: add HAS_IOPORT_MAP dependency
2016-10-18 15:18 [PATCH] scsi: g_NCR5380: add HAS_IOPORT_MAP dependency Arnd Bergmann
2016-10-18 22:27 ` Finn Thain
@ 2016-10-19 1:10 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2016-10-19 1:10 UTC (permalink / raw)
To: Arnd Bergmann
Cc: James E.J. Bottomley, Martin K. Petersen, Ondrej Zary,
Finn Thain, Hannes Reinecke, Hannes Reinicke, linux-scsi,
linux-kernel
>>>>> "Arnd" == Arnd Bergmann <arnd@arndb.de> writes:
Arnd> The driver was changed to call ioport_map, which breaks platforms
Arnd> that cannot provide this function:
Applied to 4.10/scsi-queue.
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-10-19 1:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-10-18 15:18 [PATCH] scsi: g_NCR5380: add HAS_IOPORT_MAP dependency Arnd Bergmann
2016-10-18 22:27 ` Finn Thain
2016-10-19 1:10 ` Martin K. Petersen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.