From: Jiri Kosina <jikos@kernel.org>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Jamal Hadi Salim <jhs@mojatatu.com>, Phil Sutter <phil@nwl.cc>,
Cong Wang <xiyou.wangcong@gmail.com>,
Daniel Borkmann <daniel@iogearbox.net>,
"David S. Miller" <davem@davemloft.net>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH] net: sched: make default fifo qdiscs appear in the dump
Date: Fri, 21 Oct 2016 14:56:33 +0200 (CEST) [thread overview]
Message-ID: <alpine.LNX.2.00.1610211450440.31629@cbobk.fhfr.pm> (raw)
In-Reply-To: <1477049817.7065.56.camel@edumazet-glaptop3.roam.corp.google.com>
On Fri, 21 Oct 2016, Eric Dumazet wrote:
> Some of us are dealing with huge HTB hierarchies, so adding default fifo
> in the dump will add more data pumped from the kernel.
>
> BwE [1] for instance dumps qdisc/classes every 5 seconds.
>
> I guess we'll need to not pull this patch in our kernels.
Okay, so I probably misunderstood you here:
https://marc.info/?l=linux-kernel&m=146073234818214&w=2
as I thought that as long as we move towards the hashtable, you wouldn't
have any issues with this.
I'd really like to unhide the default qdiscs, it makes little sense to be
inconsistent in this way.
Random shot into darkness -- how about making this a
CONFIG/sysctl-selectable?
Thanks,
--
Jiri Kosina
SUSE Labs
next prev parent reply other threads:[~2016-10-21 12:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-21 8:45 [PATCH] net: sched: make default fifo qdiscs appear in the dump Jiri Kosina
2016-10-21 11:36 ` Eric Dumazet
2016-10-21 12:56 ` Jiri Kosina [this message]
2016-10-21 13:14 ` Eric Dumazet
2016-10-21 15:03 ` David Miller
2016-10-21 15:45 ` Eric Dumazet
2016-10-21 14:59 ` David Miller
2016-10-21 14:55 ` David Miller
2016-10-21 15:27 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.00.1610211450440.31629@cbobk.fhfr.pm \
--to=jikos@kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=jhs@mojatatu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=phil@nwl.cc \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.