Re: Patch "PCI: endpoint: Fix kernel panic after put_device()" has been added to the 4.14-stable tree

Re: Patch "PCI: endpoint: Fix kernel panic after put_device()" has been added to the 4.14-stable tree

[Rolf Evers-Fischer]

On Wed, May 2, 2018 at 1:49 AM <gregkh@linuxfoundation.org> wrote:

> This is a note to let you know that I've just added the patch titled

>     PCI: endpoint: Fix kernel panic after put_device()

> to the 4.14-stable tree which can be found at:
    
> http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

> The filename of the patch is:
>      pci-endpoint-fix-kernel-panic-after-put_device.patch
> and it can be found in the queue-4.14 subdirectory.

> If you, or anyone else, feels it should not be added to the stable tree,
> please let <stable@vger.kernel.org> know about it.


This patch is the 2nd one of a series of patches. If you want to add it
to the stable tree without the first patch, you must add a

+		kfree(func_name);

before returning from the function.

The upstream commit of the first patch is
36cc14ac14c0d49d33820a82dab52a7edc802fef PCI: endpoint: Simplify name
allocation for EPF device

Kind regards,
 Rolf

> From foo@baz Tue May  1 16:18:20 PDT 2018

> From: Rolf Evers-Fischer <rolf.evers.fischer@aptiv.com>
> Date: Wed, 28 Feb 2018 18:32:19 +0100
> Subject: PCI: endpoint: Fix kernel panic after put_device()

> From: Rolf Evers-Fischer <rolf.evers.fischer@aptiv.com>

> [ Upstream commit 9eef6a5c3b0bf90eb292d462ea267bcb6ad1c334 ]

> 'put_device()' calls the relase function 'pci_epf_dev_release()',
> which already frees 'epf->name' and 'epf'.

> Therefore we must not free them again after 'put_device()'.

> Fixes: 5e8cb4033807 ("PCI: endpoint: Add EP core layer to enable EP 
> controller and EP functions")

> Signed-off-by: Rolf Evers-Fischer <rolf.evers.fischer@aptiv.com>
> Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
> Acked-by: Kishon Vijay Abraham I <kishon@ti.com>
> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
>  drivers/pci/endpoint/pci-epf-core.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

> --- a/drivers/pci/endpoint/pci-epf-core.c
> +++ b/drivers/pci/endpoint/pci-epf-core.c
> @@ -254,7 +254,7 @@ struct pci_epf *pci_epf_create(const cha
 
>  put_dev:
>          put_device(dev);
> -       kfree(epf->name);
> +       return ERR_PTR(ret);
 
>  free_func_name:
>          kfree(func_name);


> Patches currently in stable-queue which might be from 
> rolf.evers.fischer@aptiv.com are

> queue-4.14/pci-endpoint-fix-kernel-panic-after-put_device.patch

Re: Patch "PCI: endpoint: Fix kernel panic after put_device()" has been added to the 4.14-stable tree

[Greg KH]

On Wed, May 02, 2018 at 01:36:32PM +0200, Rolf Evers-Fischer wrote:
> 
> On Wed, May 2, 2018 at 1:49 AM <gregkh@linuxfoundation.org> wrote:
> 
> > This is a note to let you know that I've just added the patch titled
> 
> >     PCI: endpoint: Fix kernel panic after put_device()
> 
> > to the 4.14-stable tree which can be found at:
>     
> > http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
> 
> > The filename of the patch is:
> >      pci-endpoint-fix-kernel-panic-after-put_device.patch
> > and it can be found in the queue-4.14 subdirectory.
> 
> > If you, or anyone else, feels it should not be added to the stable tree,
> > please let <stable@vger.kernel.org> know about it.
> 
> 
> This patch is the 2nd one of a series of patches. If you want to add it
> to the stable tree without the first patch, you must add a
> 
> +		kfree(func_name);
> 
> before returning from the function.
> 
> The upstream commit of the first patch is
> 36cc14ac14c0d49d33820a82dab52a7edc802fef PCI: endpoint: Simplify name
> allocation for EPF device

Also dropped here, thanks for letting me know.

greg k-h