Re: [Intel-gfx] [PATCH 12/17] drm/i915/pmu: prefer struct drm_device based logging

[Wambui Karuga <wambui.karugax@gmail.com>]

On Thu, 2 Apr 2020, Jani Nikula wrote:

> Prefer struct drm_device based logging over struct device based logging.
>
> No functional changes.
>
> Cc: Wambui Karuga <wambui.karugax@gmail.com>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>

Reviewed-by: Wambui Karuga <wambui.karugax@gmail.com>

> ---
> drivers/gpu/drm/i915/i915_pmu.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_pmu.c b/drivers/gpu/drm/i915/i915_pmu.c
> index 2c062534eac1..230e9256ab30 100644
> --- a/drivers/gpu/drm/i915/i915_pmu.c
> +++ b/drivers/gpu/drm/i915/i915_pmu.c
> @@ -1115,7 +1115,7 @@ void i915_pmu_register(struct drm_i915_private *i915)
> 	int ret = -ENOMEM;
>
> 	if (INTEL_GEN(i915) <= 2) {
> -		dev_info(i915->drm.dev, "PMU not supported for this GPU.");
> +		drm_info(&i915->drm, "PMU not supported for this GPU.");
> 		return;
> 	}
>
> @@ -1178,7 +1178,7 @@ void i915_pmu_register(struct drm_i915_private *i915)
> 	if (!is_igp(i915))
> 		kfree(pmu->name);
> err:
> -	dev_notice(i915->drm.dev, "Failed to register PMU!\n");
> +	drm_notice(&i915->drm, "Failed to register PMU!\n");
> }
>
> void i915_pmu_unregister(struct drm_i915_private *i915)
> -- 
> 2.20.1
>
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx