* Re: [PATCH] selinux: fix parallel compile error [not found] <1281389665-22152-1-git-send-email-paul.gortmaker@windriver.com> @ 2010-09-14 22:19 ` James Morris [not found] ` <20100915134429.GA17032@windriver.com> 0 siblings, 1 reply; 4+ messages in thread From: James Morris @ 2010-09-14 22:19 UTC (permalink / raw) To: Paul Gortmaker; +Cc: sds, eparis, selinux On Mon, 9 Aug 2010, Paul Gortmaker wrote: > Selinux has an autogenerated file, "flask.h" which is included by > two other selinux files. The current makefile has a single dependency > on the first object file in the selinux-y list, assuming that will get > flask.h generated before anyone looks for it, but that assumption breaks > down in a "make -jN" situation and you get: > > selinux/selinuxfs.c:35: fatal error: flask.h: No such file or directory > compilation terminated. > remake[9]: *** [security/selinux/selinuxfs.o] Error 1 > > Since flask.h is included by security.h which in turn is included > nearly everywhere, make the dependency apply to all of the selinux-y > list of objs. > > Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> Applied to git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/security-testing-2.6#next -- James Morris <jmorris@namei.org> -- This message was distributed to subscribers of the selinux mailing list. If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with the words "unsubscribe selinux" without quotes as the message. ^ permalink raw reply [flat|nested] 4+ messages in thread
[parent not found: <20100915134429.GA17032@windriver.com>]
* Re: [PATCH] selinux: fix parallel compile error [not found] ` <20100915134429.GA17032@windriver.com> @ 2010-09-15 22:24 ` James Morris 2010-09-16 0:14 ` Paul Gortmaker 0 siblings, 1 reply; 4+ messages in thread From: James Morris @ 2010-09-15 22:24 UTC (permalink / raw) To: Paul Gortmaker; +Cc: sds, eparis, selinux On Wed, 15 Sep 2010, Paul Gortmaker wrote: > Thanks for applying this earlier patch. I found that there still > is a (now smaller) corner case to trigger this because of the ss subdir, > which is why I resent a slightly different patch to you last week. > This updated patch does a better job of showing and fixing the problem. > > http://www.spinics.net/linux/fedora/linux-security-module/msg09277.html > > Let me know if you would like a delta patch, instead of rewinding > and replacing the older one with this one. Please send a delta patch, otherwise, it will mess up the git history. -- James Morris <jmorris@namei.org> -- This message was distributed to subscribers of the selinux mailing list. If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with the words "unsubscribe selinux" without quotes as the message. ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] selinux: fix parallel compile error 2010-09-15 22:24 ` James Morris @ 2010-09-16 0:14 ` Paul Gortmaker 2010-09-16 22:30 ` James Morris 0 siblings, 1 reply; 4+ messages in thread From: Paul Gortmaker @ 2010-09-16 0:14 UTC (permalink / raw) To: James Morris; +Cc: sds, eparis, selinux [Re: [PATCH] selinux: fix parallel compile error] On 16/09/2010 (Thu 08:24) James Morris wrote: > On Wed, 15 Sep 2010, Paul Gortmaker wrote: > > > Thanks for applying this earlier patch. I found that there still > > is a (now smaller) corner case to trigger this because of the ss subdir, > > which is why I resent a slightly different patch to you last week. > > This updated patch does a better job of showing and fixing the problem. > > > > http://www.spinics.net/linux/fedora/linux-security-module/msg09277.html > > > > Let me know if you would like a delta patch, instead of rewinding > > and replacing the older one with this one. > > Please send a delta patch, otherwise, it will mess up the git history. No problem. Inline below. My patch #2 would have needed to have been updated anyway, since the addition of ss/status.c wasn't in the tree I'd originally created it on. Thanks, Paul. --- ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] selinux: fix parallel compile error 2010-09-16 0:14 ` Paul Gortmaker @ 2010-09-16 22:30 ` James Morris 0 siblings, 0 replies; 4+ messages in thread From: James Morris @ 2010-09-16 22:30 UTC (permalink / raw) To: Paul Gortmaker; +Cc: sds, eparis, selinux On Wed, 15 Sep 2010, Paul Gortmaker wrote: > With this change, compiling of all selinux files is dependent on > completion of the header file generation, and this test case with > the "sleep 30" now confirms it is functioning as expected. > > Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> > --- > security/selinux/Makefile | 17 ++++++----------- > security/selinux/ss/Makefile | 9 --------- > 2 files changed, 6 insertions(+), 20 deletions(-) > delete mode 100644 security/selinux/ss/Makefile Applied to git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/security-testing-2.6#next -- James Morris <jmorris@namei.org> -- This message was distributed to subscribers of the selinux mailing list. If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with the words "unsubscribe selinux" without quotes as the message. ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-09-16 22:30 UTC | newest] Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- [not found] <1281389665-22152-1-git-send-email-paul.gortmaker@windriver.com> 2010-09-14 22:19 ` [PATCH] selinux: fix parallel compile error James Morris [not found] ` <20100915134429.GA17032@windriver.com> 2010-09-15 22:24 ` James Morris 2010-09-16 0:14 ` Paul Gortmaker 2010-09-16 22:30 ` James Morris
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.