* [PATCH] tomoyo: remove tomoyo_gc_thread()->daemonize()
@ 2011-08-16 18:34 Oleg Nesterov
2011-08-16 19:36 ` Tejun Heo
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Oleg Nesterov @ 2011-08-16 18:34 UTC (permalink / raw)
To: Andrew Morton, Kentaro Takeda, Tetsuo Handa
Cc: Matt Fleming, Tejun Heo, linux-kernel
daemonize() is only needed when a user-space task does kernel_thread().
tomoyo_gc_thread() is kthread_create()'ed and thus it doesn't need
the soon-to-be-deprecated daemonize().
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
---
security/tomoyo/gc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- 3.1/security/tomoyo/gc.c~1_daemonize_tomoyo 2011-08-12 16:02:18.000000000 +0200
+++ 3.1/security/tomoyo/gc.c 2011-08-16 20:18:52.000000000 +0200
@@ -660,7 +660,7 @@ static int tomoyo_gc_thread(void *unused
static DEFINE_MUTEX(tomoyo_gc_mutex);
if (!mutex_trylock(&tomoyo_gc_mutex))
goto out;
- daemonize("GC for TOMOYO");
+
do {
tomoyo_collect_entry();
if (list_empty(&tomoyo_gc_list))
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] tomoyo: remove tomoyo_gc_thread()->daemonize()
2011-08-16 18:34 [PATCH] tomoyo: remove tomoyo_gc_thread()->daemonize() Oleg Nesterov
@ 2011-08-16 19:36 ` Tejun Heo
2011-08-16 21:31 ` Matt Fleming
2011-08-16 23:49 ` James Morris
2 siblings, 0 replies; 4+ messages in thread
From: Tejun Heo @ 2011-08-16 19:36 UTC (permalink / raw)
To: Oleg Nesterov
Cc: Andrew Morton, Kentaro Takeda, Tetsuo Handa, Matt Fleming, linux-kernel
On Tue, Aug 16, 2011 at 08:34:05PM +0200, Oleg Nesterov wrote:
> daemonize() is only needed when a user-space task does kernel_thread().
>
> tomoyo_gc_thread() is kthread_create()'ed and thus it doesn't need
> the soon-to-be-deprecated daemonize().
>
> Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Acked-by: Tejun Heo <tj@kernel.org>
--
tejun
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] tomoyo: remove tomoyo_gc_thread()->daemonize()
2011-08-16 18:34 [PATCH] tomoyo: remove tomoyo_gc_thread()->daemonize() Oleg Nesterov
2011-08-16 19:36 ` Tejun Heo
@ 2011-08-16 21:31 ` Matt Fleming
2011-08-16 23:49 ` James Morris
2 siblings, 0 replies; 4+ messages in thread
From: Matt Fleming @ 2011-08-16 21:31 UTC (permalink / raw)
To: Oleg Nesterov
Cc: Andrew Morton, Kentaro Takeda, Tetsuo Handa, Tejun Heo, linux-kernel
On Tue, 2011-08-16 at 20:34 +0200, Oleg Nesterov wrote:
> daemonize() is only needed when a user-space task does kernel_thread().
>
> tomoyo_gc_thread() is kthread_create()'ed and thus it doesn't need
> the soon-to-be-deprecated daemonize().
>
> Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Acked-by: Matt Fleming <matt.fleming@intel.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] tomoyo: remove tomoyo_gc_thread()->daemonize()
2011-08-16 18:34 [PATCH] tomoyo: remove tomoyo_gc_thread()->daemonize() Oleg Nesterov
2011-08-16 19:36 ` Tejun Heo
2011-08-16 21:31 ` Matt Fleming
@ 2011-08-16 23:49 ` James Morris
2 siblings, 0 replies; 4+ messages in thread
From: James Morris @ 2011-08-16 23:49 UTC (permalink / raw)
To: Oleg Nesterov
Cc: Andrew Morton, Kentaro Takeda, Tetsuo Handa, Matt Fleming,
Tejun Heo, linux-kernel
On Tue, 16 Aug 2011, Oleg Nesterov wrote:
> daemonize() is only needed when a user-space task does kernel_thread().
>
> tomoyo_gc_thread() is kthread_create()'ed and thus it doesn't need
> the soon-to-be-deprecated daemonize().
>
> Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Applied to
git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/security-testing-2.6#next
--
James Morris
<jmorris@namei.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-08-16 23:55 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-08-16 18:34 [PATCH] tomoyo: remove tomoyo_gc_thread()->daemonize() Oleg Nesterov
2011-08-16 19:36 ` Tejun Heo
2011-08-16 21:31 ` Matt Fleming
2011-08-16 23:49 ` James Morris
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.