All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] dm-block-manager: stacktrace cleanup
@ 2015-11-24  0:12 Mikulas Patocka
  0 siblings, 0 replies; only message in thread
From: Mikulas Patocka @ 2015-11-24  0:12 UTC (permalink / raw)
  To: Mike Snitzer, Edward Thornber; +Cc: dm-devel

A small code cleanup. There is no need to record stack trace and
immediatelly print it. We have a function dump_stack() that prints the
current stack.

Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>

Index: linux-4.4-rc2/drivers/md/persistent-data/dm-block-manager.c
===================================================================
--- linux-4.4-rc2.orig/drivers/md/persistent-data/dm-block-manager.c
+++ linux-4.4-rc2/drivers/md/persistent-data/dm-block-manager.c
@@ -97,10 +97,6 @@ static void __del_holder(struct block_lo
 static int __check_holder(struct block_lock *lock)
 {
 	unsigned i;
-#ifdef CONFIG_DM_DEBUG_BLOCK_STACK_TRACING
-	static struct stack_trace t;
-	static stack_entries entries;
-#endif
 
 	for (i = 0; i < MAX_HOLDERS; i++) {
 		if (lock->holders[i] == current) {
@@ -110,12 +106,7 @@ static int __check_holder(struct block_l
 			print_stack_trace(lock->traces + i, 4);
 
 			DMERR("subsequent acquisition attempted here:");
-			t.nr_entries = 0;
-			t.max_entries = MAX_STACK;
-			t.entries = entries;
-			t.skip = 3;
-			save_stack_trace(&t);
-			print_stack_trace(&t, 4);
+			dump_stack();
 #endif
 			return -EINVAL;
 		}

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2015-11-24  0:12 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-11-24  0:12 [PATCH] dm-block-manager: stacktrace cleanup Mikulas Patocka

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.