From: Mikulas Patocka <mpatocka@redhat.com> To: Michal Hocko <mhocko@suse.com> Cc: Vlastimil Babka <vbabka@suse.cz>, Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>, Johannes Weiner <hannes@cmpxchg.org>, Mel Gorman <mgorman@suse.de>, Dave Hansen <dave.hansen@intel.com>, Andrew Morton <akpm@linux-foundation.org>, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH] mm: respect the __GFP_NOWARN flag when warning about stalls Date: Mon, 11 Sep 2017 02:52:53 -0400 (EDT) [thread overview] Message-ID: <alpine.LRH.2.02.1709110231010.3666@file01.intranet.prod.int.rdu2.redhat.com> (raw) I am occasionally getting these warnings in khugepaged. It is an old machine with 550MHz CPU and 512 MB RAM. Note that khugepaged has nice value 19, so when the machine is loaded with some work, khugepaged is stalled and this stall produces warning in the allocator. khugepaged does allocations with __GFP_NOWARN, but the flag __GFP_NOWARN is masked off when calling warn_alloc. This patch removes the masking of __GFP_NOWARN, so that the warning is suppressed. khugepaged: page allocation stalls for 10273ms, order:10, mode:0x4340ca(__GFP_HIGHMEM|__GFP_IO|__GFP_FS|__GFP_COMP|__GFP_NOMEMALLOC|__GFP_HARDWALL|__GFP_MOVABLE|__GFP_DIRECT_RECLAIM), nodemask=(null) CPU: 0 PID: 3936 Comm: khugepaged Not tainted 4.12.3 #1 Hardware name: System Manufacturer Product Name/VA-503A, BIOS 4.51 PG 08/02/00 Call Trace: ? warn_alloc+0xb9/0x140 ? __alloc_pages_nodemask+0x724/0x880 ? arch_irq_stat_cpu+0x1/0x40 ? detach_if_pending+0x80/0x80 ? khugepaged+0x10a/0x1d40 ? pick_next_task_fair+0xd2/0x180 ? wait_woken+0x60/0x60 ? kthread+0xcf/0x100 ? release_pte_page+0x40/0x40 ? kthread_create_on_node+0x40/0x40 ? ret_from_fork+0x19/0x30 Signed-off-by: Mikulas Patocka <mpatocka@redhat.com> Cc: stable@vger.kernel.org Fixes: 63f53dea0c98 ("mm: warn about allocations which stall for too long") --- mm/page_alloc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: linux-2.6/mm/page_alloc.c =================================================================== --- linux-2.6.orig/mm/page_alloc.c +++ linux-2.6/mm/page_alloc.c @@ -3923,7 +3923,7 @@ retry: /* Make sure we know about allocations which stall for too long */ if (time_after(jiffies, alloc_start + stall_timeout)) { - warn_alloc(gfp_mask & ~__GFP_NOWARN, ac->nodemask, + warn_alloc(gfp_mask, ac->nodemask, "page allocation stalls for %ums, order:%u", jiffies_to_msecs(jiffies-alloc_start), order); stall_timeout += 10 * HZ;
WARNING: multiple messages have this Message-ID (diff)
From: Mikulas Patocka <mpatocka@redhat.com> To: Michal Hocko <mhocko@suse.com> Cc: Vlastimil Babka <vbabka@suse.cz>, Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>, Johannes Weiner <hannes@cmpxchg.org>, Mel Gorman <mgorman@suse.de>, Dave Hansen <dave.hansen@intel.com>, Andrew Morton <akpm@linux-foundation.org>, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH] mm: respect the __GFP_NOWARN flag when warning about stalls Date: Mon, 11 Sep 2017 02:52:53 -0400 (EDT) [thread overview] Message-ID: <alpine.LRH.2.02.1709110231010.3666@file01.intranet.prod.int.rdu2.redhat.com> (raw) I am occasionally getting these warnings in khugepaged. It is an old machine with 550MHz CPU and 512 MB RAM. Note that khugepaged has nice value 19, so when the machine is loaded with some work, khugepaged is stalled and this stall produces warning in the allocator. khugepaged does allocations with __GFP_NOWARN, but the flag __GFP_NOWARN is masked off when calling warn_alloc. This patch removes the masking of __GFP_NOWARN, so that the warning is suppressed. khugepaged: page allocation stalls for 10273ms, order:10, mode:0x4340ca(__GFP_HIGHMEM|__GFP_IO|__GFP_FS|__GFP_COMP|__GFP_NOMEMALLOC|__GFP_HARDWALL|__GFP_MOVABLE|__GFP_DIRECT_RECLAIM), nodemask=(null) CPU: 0 PID: 3936 Comm: khugepaged Not tainted 4.12.3 #1 Hardware name: System Manufacturer Product Name/VA-503A, BIOS 4.51 PG 08/02/00 Call Trace: ? warn_alloc+0xb9/0x140 ? __alloc_pages_nodemask+0x724/0x880 ? arch_irq_stat_cpu+0x1/0x40 ? detach_if_pending+0x80/0x80 ? khugepaged+0x10a/0x1d40 ? pick_next_task_fair+0xd2/0x180 ? wait_woken+0x60/0x60 ? kthread+0xcf/0x100 ? release_pte_page+0x40/0x40 ? kthread_create_on_node+0x40/0x40 ? ret_from_fork+0x19/0x30 Signed-off-by: Mikulas Patocka <mpatocka@redhat.com> Cc: stable@vger.kernel.org Fixes: 63f53dea0c98 ("mm: warn about allocations which stall for too long") --- mm/page_alloc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: linux-2.6/mm/page_alloc.c =================================================================== --- linux-2.6.orig/mm/page_alloc.c +++ linux-2.6/mm/page_alloc.c @@ -3923,7 +3923,7 @@ retry: /* Make sure we know about allocations which stall for too long */ if (time_after(jiffies, alloc_start + stall_timeout)) { - warn_alloc(gfp_mask & ~__GFP_NOWARN, ac->nodemask, + warn_alloc(gfp_mask, ac->nodemask, "page allocation stalls for %ums, order:%u", jiffies_to_msecs(jiffies-alloc_start), order); stall_timeout += 10 * HZ; -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next reply other threads:[~2017-09-11 6:52 UTC|newest] Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-09-11 6:52 Mikulas Patocka [this message] 2017-09-11 6:52 ` [PATCH] mm: respect the __GFP_NOWARN flag when warning about stalls Mikulas Patocka 2017-09-11 8:26 ` Michal Hocko 2017-09-11 8:26 ` Michal Hocko 2017-09-11 23:36 ` Mikulas Patocka 2017-09-11 23:36 ` Mikulas Patocka 2017-09-12 7:14 ` Vlastimil Babka 2017-09-12 7:14 ` Vlastimil Babka 2017-09-13 14:52 ` Shakeel Butt 2017-09-13 14:52 ` Shakeel Butt 2017-09-13 11:54 ` Michal Hocko 2017-09-13 11:54 ` Michal Hocko 2017-09-13 13:54 ` Tetsuo Handa 2017-09-13 13:54 ` Tetsuo Handa 2017-09-13 14:03 ` Vlastimil Babka 2017-09-13 14:03 ` Vlastimil Babka 2017-09-13 14:14 ` Tetsuo Handa 2017-09-13 14:14 ` Tetsuo Handa 2017-09-13 14:35 ` Michal Hocko 2017-09-13 14:35 ` Michal Hocko
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=alpine.LRH.2.02.1709110231010.3666@file01.intranet.prod.int.rdu2.redhat.com \ --to=mpatocka@redhat.com \ --cc=akpm@linux-foundation.org \ --cc=dave.hansen@intel.com \ --cc=hannes@cmpxchg.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=mgorman@suse.de \ --cc=mhocko@suse.com \ --cc=penguin-kernel@I-love.SAKURA.ne.jp \ --cc=vbabka@suse.cz \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.