From: Mikulas Patocka <mpatocka@redhat.com>
To: Sudhakar Panneerselvam <sudhakar.panneerselvam@oracle.com>
Cc: agk@redhat.com, snitzer@redhat.com, dm-devel@redhat.com,
dm-crypt@saout.de, Damien.LeMoal@wdc.com,
Shirley Ma <shirley.ma@oracle.com>,
ssudhakarp@gmail.com,
Martin Petersen <martin.petersen@oracle.com>
Subject: Re: [dm-crypt] [dm-devel] [RFC PATCH 0/2] dm crypt: Allow unaligned buffer lengths for skcipher devices
Date: Thu, 24 Sep 2020 08:40:25 -0400 (EDT) [thread overview]
Message-ID: <alpine.LRH.2.02.2009240834020.11084@file01.intranet.prod.int.rdu2.redhat.com> (raw)
In-Reply-To: <3be1ea32-b6a8-41ef-a9ba-ed691434d068@default>
On Wed, 23 Sep 2020, Sudhakar Panneerselvam wrote:
> Could someone review this patch set, please?
>
> Thanks
> Sudhakar
Hi
I'd like to ask - what sector size do you use in dm-crypt? Could the issue
be fixed just by using the smallest possible 512-byte sectors?
What I/O method does qemu use? Is it direct i/o + aio? What is unaligned -
the base address? Or length? Or the sector number? Could you use strace on
qemu and show an example of an I/O that fails due to alignment?
Mikulas
WARNING: multiple messages have this Message-ID (diff)
From: Mikulas Patocka <mpatocka@redhat.com>
To: Sudhakar Panneerselvam <sudhakar.panneerselvam@oracle.com>
Cc: Damien.LeMoal@wdc.com, ssudhakarp@gmail.com, snitzer@redhat.com,
dm-crypt@saout.de, dm-devel@redhat.com,
Shirley Ma <shirley.ma@oracle.com>,
Martin Petersen <martin.petersen@oracle.com>,
agk@redhat.com
Subject: Re: [RFC PATCH 0/2] dm crypt: Allow unaligned buffer lengths for skcipher devices
Date: Thu, 24 Sep 2020 08:40:25 -0400 (EDT) [thread overview]
Message-ID: <alpine.LRH.2.02.2009240834020.11084@file01.intranet.prod.int.rdu2.redhat.com> (raw)
In-Reply-To: <3be1ea32-b6a8-41ef-a9ba-ed691434d068@default>
On Wed, 23 Sep 2020, Sudhakar Panneerselvam wrote:
> Could someone review this patch set, please?
>
> Thanks
> Sudhakar
Hi
I'd like to ask - what sector size do you use in dm-crypt? Could the issue
be fixed just by using the smallest possible 512-byte sectors?
What I/O method does qemu use? Is it direct i/o + aio? What is unaligned -
the base address? Or length? Or the sector number? Could you use strace on
qemu and show an example of an I/O that fails due to alignment?
Mikulas
next prev parent reply other threads:[~2020-09-24 12:47 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-16 18:40 [RFC PATCH 0/2] dm crypt: Allow unaligned buffer lengths for skcipher devices Sudhakar Panneerselvam
2020-09-16 18:40 ` [RFC PATCH 1/2] dm crypt: Allow unaligned bio " Sudhakar Panneerselvam
2020-09-16 18:40 ` [RFC PATCH 2/2] dm crypt: Handle unaligned bio buffer lengths for lmk and tcw Sudhakar Panneerselvam
2020-09-23 17:01 ` [dm-crypt] [dm-devel] [RFC PATCH 0/2] dm crypt: Allow unaligned buffer lengths for skcipher devices Sudhakar Panneerselvam
2020-09-23 17:01 ` Sudhakar Panneerselvam
2020-09-24 1:27 ` [dm-crypt] " Mike Snitzer
2020-09-24 1:27 ` Mike Snitzer
2020-09-24 5:14 ` [dm-crypt] [dm-devel] " Eric Biggers
2020-09-24 5:14 ` Eric Biggers
2020-09-24 8:15 ` [dm-crypt] [dm-devel] " Milan Broz
2020-09-24 8:15 ` Milan Broz
2020-09-24 16:55 ` [dm-crypt] [dm-devel] " Sudhakar Panneerselvam
2020-09-24 16:55 ` Sudhakar Panneerselvam
2020-09-24 16:44 ` [dm-crypt] [dm-devel] " Sudhakar Panneerselvam
2020-09-24 16:44 ` Sudhakar Panneerselvam
2020-09-24 17:26 ` [dm-crypt] [dm-devel] " Mikulas Patocka
2020-09-24 17:26 ` Mikulas Patocka
2020-09-24 17:38 ` [dm-crypt] [dm-devel] " Sudhakar Panneerselvam
2020-09-24 17:38 ` Sudhakar Panneerselvam
2020-09-24 17:50 ` [dm-crypt] [dm-devel] " Mikulas Patocka
2020-09-24 17:50 ` Mikulas Patocka
2020-09-24 18:11 ` [dm-crypt] [dm-devel] " Sudhakar Panneerselvam
2020-09-24 18:11 ` Sudhakar Panneerselvam
2020-09-24 18:44 ` [dm-crypt] [dm-devel] " Mikulas Patocka
2020-09-24 18:44 ` Mikulas Patocka
2020-09-24 19:13 ` [dm-crypt] [dm-devel] " Sudhakar Panneerselvam
2020-09-24 19:13 ` Sudhakar Panneerselvam
2020-09-25 1:09 ` [dm-crypt] [dm-devel] " Damien Le Moal
2020-09-25 1:09 ` Damien Le Moal
2020-09-25 20:15 ` Mike Snitzer
2020-09-25 20:15 ` Mike Snitzer
2020-09-25 20:15 ` [dm-crypt] " Mike Snitzer
2020-09-24 12:47 ` Mikulas Patocka
2020-09-24 12:47 ` Mikulas Patocka
2020-09-24 15:58 ` [dm-crypt] " Sudhakar Panneerselvam
2020-09-24 15:58 ` Sudhakar Panneerselvam
2020-09-24 12:40 ` Mikulas Patocka [this message]
2020-09-24 12:40 ` Mikulas Patocka
2020-09-24 17:12 ` [dm-crypt] [dm-devel] " Sudhakar Panneerselvam
2020-09-24 17:12 ` Sudhakar Panneerselvam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LRH.2.02.2009240834020.11084@file01.intranet.prod.int.rdu2.redhat.com \
--to=mpatocka@redhat.com \
--cc=Damien.LeMoal@wdc.com \
--cc=agk@redhat.com \
--cc=dm-crypt@saout.de \
--cc=dm-devel@redhat.com \
--cc=martin.petersen@oracle.com \
--cc=shirley.ma@oracle.com \
--cc=snitzer@redhat.com \
--cc=ssudhakarp@gmail.com \
--cc=sudhakar.panneerselvam@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.