From: Mikulas Patocka <mpatocka@redhat.com>
To: Jeff Moyer <jmoyer@redhat.com>
Cc: JeffleXu <jefflexu@linux.alibaba.com>,
Mike Snitzer <msnitzer@redhat.com>,
Heinz Mauelshagen <heinzm@redhat.com>,
axboe@kernel.dk, caspar@linux.alibaba.com,
io-uring@vger.kernel.org, linux-block@vger.kernel.org,
joseph.qi@linux.alibaba.com, dm-devel@redhat.com, hch@lst.de
Subject: Re: [dm-devel] [PATCH 4/4] dm: support I/O polling
Date: Thu, 4 Mar 2021 10:12:39 -0500 (EST) [thread overview]
Message-ID: <alpine.LRH.2.02.2103041008440.31824@file01.intranet.prod.int.rdu2.redhat.com> (raw)
In-Reply-To: <x49o8fzklnx.fsf@segfault.boston.devel.redhat.com>
On Thu, 4 Mar 2021, Jeff Moyer wrote:
> Hi, Mikulas,
>
> Mikulas Patocka <mpatocka@redhat.com> writes:
>
> > On Wed, 3 Mar 2021, JeffleXu wrote:
> >
> >>
> >>
> >> On 3/3/21 3:05 AM, Mikulas Patocka wrote:
> >>
> >> > Support I/O polling if submit_bio_noacct_mq_direct returned non-empty
> >> > cookie.
> >> >
> >> > Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
> >> >
> >> > ---
> >> > drivers/md/dm.c | 5 +++++
> >> > 1 file changed, 5 insertions(+)
> >> >
> >> > Index: linux-2.6/drivers/md/dm.c
> >> > ===================================================================
> >> > --- linux-2.6.orig/drivers/md/dm.c 2021-03-02 19:26:34.000000000 +0100
> >> > +++ linux-2.6/drivers/md/dm.c 2021-03-02 19:26:34.000000000 +0100
> >> > @@ -1682,6 +1682,11 @@ static void __split_and_process_bio(stru
> >> > }
> >> > }
> >> >
> >> > + if (ci.poll_cookie != BLK_QC_T_NONE) {
> >> > + while (atomic_read(&ci.io->io_count) > 1 &&
> >> > + blk_poll(ci.poll_queue, ci.poll_cookie, true)) ;
> >> > + }
> >> > +
> >> > /* drop the extra reference count */
> >> > dec_pending(ci.io, errno_to_blk_status(error));
> >> > }
> >>
> >> It seems that the general idea of your design is to
> >> 1) submit *one* split bio
> >> 2) blk_poll(), waiting the previously submitted split bio complets
> >
> > No, I submit all the bios and poll for the last one.
>
> What happens if the last bio completes first? It looks like you will
> call blk_poll with a cookie that already completed, and I'm pretty sure
> that's invalid.
>
> Thanks,
> Jeff
If the last bio completes first, the other bios will use interrupt-driven
endio.
Calling blk_poll with already completed cookie is IMHO legal - it happens
with the current direct-io code too. The direct-io code will check for bio
completion and if the bio is not completed, call blk_poll. The bio may be
completed from an interrupt after the check and before blk_poll - in this
case, we will call blk_poll with already completed cookie.
Mikulas
WARNING: multiple messages have this Message-ID (diff)
From: Mikulas Patocka <mpatocka@redhat.com>
To: Jeff Moyer <jmoyer@redhat.com>
Cc: axboe@kernel.dk, Mike Snitzer <msnitzer@redhat.com>,
Heinz Mauelshagen <heinzm@redhat.com>,
caspar@linux.alibaba.com, hch@lst.de,
linux-block@vger.kernel.org, joseph.qi@linux.alibaba.com,
dm-devel@redhat.com, JeffleXu <jefflexu@linux.alibaba.com>,
io-uring@vger.kernel.org
Subject: Re: [dm-devel] [PATCH 4/4] dm: support I/O polling
Date: Thu, 4 Mar 2021 10:12:39 -0500 (EST) [thread overview]
Message-ID: <alpine.LRH.2.02.2103041008440.31824@file01.intranet.prod.int.rdu2.redhat.com> (raw)
In-Reply-To: <x49o8fzklnx.fsf@segfault.boston.devel.redhat.com>
On Thu, 4 Mar 2021, Jeff Moyer wrote:
> Hi, Mikulas,
>
> Mikulas Patocka <mpatocka@redhat.com> writes:
>
> > On Wed, 3 Mar 2021, JeffleXu wrote:
> >
> >>
> >>
> >> On 3/3/21 3:05 AM, Mikulas Patocka wrote:
> >>
> >> > Support I/O polling if submit_bio_noacct_mq_direct returned non-empty
> >> > cookie.
> >> >
> >> > Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
> >> >
> >> > ---
> >> > drivers/md/dm.c | 5 +++++
> >> > 1 file changed, 5 insertions(+)
> >> >
> >> > Index: linux-2.6/drivers/md/dm.c
> >> > ===================================================================
> >> > --- linux-2.6.orig/drivers/md/dm.c 2021-03-02 19:26:34.000000000 +0100
> >> > +++ linux-2.6/drivers/md/dm.c 2021-03-02 19:26:34.000000000 +0100
> >> > @@ -1682,6 +1682,11 @@ static void __split_and_process_bio(stru
> >> > }
> >> > }
> >> >
> >> > + if (ci.poll_cookie != BLK_QC_T_NONE) {
> >> > + while (atomic_read(&ci.io->io_count) > 1 &&
> >> > + blk_poll(ci.poll_queue, ci.poll_cookie, true)) ;
> >> > + }
> >> > +
> >> > /* drop the extra reference count */
> >> > dec_pending(ci.io, errno_to_blk_status(error));
> >> > }
> >>
> >> It seems that the general idea of your design is to
> >> 1) submit *one* split bio
> >> 2) blk_poll(), waiting the previously submitted split bio complets
> >
> > No, I submit all the bios and poll for the last one.
>
> What happens if the last bio completes first? It looks like you will
> call blk_poll with a cookie that already completed, and I'm pretty sure
> that's invalid.
>
> Thanks,
> Jeff
If the last bio completes first, the other bios will use interrupt-driven
endio.
Calling blk_poll with already completed cookie is IMHO legal - it happens
with the current direct-io code too. The direct-io code will check for bio
completion and if the bio is not completed, call blk_poll. The bio may be
completed from an interrupt after the check and before blk_poll - in this
case, we will call blk_poll with already completed cookie.
Mikulas
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
next prev parent reply other threads:[~2021-03-04 15:15 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-02 19:05 [PATCH 4/4] dm: support I/O polling Mikulas Patocka
2021-03-02 19:05 ` [dm-devel] " Mikulas Patocka
2021-03-03 2:53 ` JeffleXu
2021-03-03 2:53 ` JeffleXu
2021-03-03 10:09 ` Mikulas Patocka
2021-03-03 10:09 ` Mikulas Patocka
2021-03-04 2:57 ` JeffleXu
2021-03-04 2:57 ` JeffleXu
2021-03-04 10:09 ` Mikulas Patocka
2021-03-04 10:09 ` Mikulas Patocka
2021-03-05 18:21 ` Jens Axboe
2021-03-05 18:21 ` Jens Axboe
2021-03-04 15:01 ` Jeff Moyer
2021-03-04 15:01 ` Jeff Moyer
2021-03-04 15:11 ` Mike Snitzer
2021-03-04 15:11 ` [dm-devel] " Mike Snitzer
2021-03-04 15:12 ` Mikulas Patocka [this message]
2021-03-04 15:12 ` Mikulas Patocka
2021-03-05 9:52 ` JeffleXu
2021-03-05 9:52 ` JeffleXu
2021-03-05 17:46 ` Heinz Mauelshagen
2021-03-05 17:46 ` Heinz Mauelshagen
2021-03-05 17:56 ` Heinz Mauelshagen
2021-03-05 17:56 ` Heinz Mauelshagen
2021-03-05 18:09 ` Mike Snitzer
2021-03-05 18:09 ` [dm-devel] " Mike Snitzer
2021-03-05 18:19 ` Heinz Mauelshagen
2021-03-05 18:19 ` Heinz Mauelshagen
2021-03-08 3:54 ` JeffleXu
2021-03-08 3:54 ` JeffleXu
2021-03-08 3:55 ` Jens Axboe
2021-03-08 3:55 ` Jens Axboe
2021-03-09 11:42 ` Heinz Mauelshagen
2021-03-09 11:42 ` Heinz Mauelshagen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LRH.2.02.2103041008440.31824@file01.intranet.prod.int.rdu2.redhat.com \
--to=mpatocka@redhat.com \
--cc=axboe@kernel.dk \
--cc=caspar@linux.alibaba.com \
--cc=dm-devel@redhat.com \
--cc=hch@lst.de \
--cc=heinzm@redhat.com \
--cc=io-uring@vger.kernel.org \
--cc=jefflexu@linux.alibaba.com \
--cc=jmoyer@redhat.com \
--cc=joseph.qi@linux.alibaba.com \
--cc=linux-block@vger.kernel.org \
--cc=msnitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.