* [PATCH] dm-raid: fix KASAN warning in raid5_add_disks
@ 2022-06-29 17:40 ` Mikulas Patocka
0 siblings, 0 replies; 2+ messages in thread
From: Mikulas Patocka @ 2022-06-29 17:40 UTC (permalink / raw)
To: song, Mike Snitzer, Heinz Mauelshagen; +Cc: dm-devel, linux-raid
There's a KASAN warning in raid5_add_disk when running the LVM testsuite.
The warning happens in the test
lvconvert-raid-reshape-linear_to_raid6-single-type.sh. We fix the warning
by verifying that rdev->saved_raid_disk is within limits.
Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
Cc: stable@vger.kernel.org
---
drivers/md/raid5.c | 1 +
1 file changed, 1 insertion(+)
Index: linux-2.6/drivers/md/raid5.c
===================================================================
--- linux-2.6.orig/drivers/md/raid5.c 2022-06-24 18:45:53.000000000 +0200
+++ linux-2.6/drivers/md/raid5.c 2022-06-24 18:46:59.000000000 +0200
@@ -8065,6 +8065,7 @@ static int raid5_add_disk(struct mddev *
*/
if (rdev->saved_raid_disk >= 0 &&
rdev->saved_raid_disk >= first &&
+ rdev->saved_raid_disk <= last &&
conf->disks[rdev->saved_raid_disk].rdev == NULL)
first = rdev->saved_raid_disk;
^ permalink raw reply [flat|nested] 2+ messages in thread
* [dm-devel] [PATCH] dm-raid: fix KASAN warning in raid5_add_disks
@ 2022-06-29 17:40 ` Mikulas Patocka
0 siblings, 0 replies; 2+ messages in thread
From: Mikulas Patocka @ 2022-06-29 17:40 UTC (permalink / raw)
To: song, Mike Snitzer, Heinz Mauelshagen; +Cc: linux-raid, dm-devel
There's a KASAN warning in raid5_add_disk when running the LVM testsuite.
The warning happens in the test
lvconvert-raid-reshape-linear_to_raid6-single-type.sh. We fix the warning
by verifying that rdev->saved_raid_disk is within limits.
Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
Cc: stable@vger.kernel.org
---
drivers/md/raid5.c | 1 +
1 file changed, 1 insertion(+)
Index: linux-2.6/drivers/md/raid5.c
===================================================================
--- linux-2.6.orig/drivers/md/raid5.c 2022-06-24 18:45:53.000000000 +0200
+++ linux-2.6/drivers/md/raid5.c 2022-06-24 18:46:59.000000000 +0200
@@ -8065,6 +8065,7 @@ static int raid5_add_disk(struct mddev *
*/
if (rdev->saved_raid_disk >= 0 &&
rdev->saved_raid_disk >= first &&
+ rdev->saved_raid_disk <= last &&
conf->disks[rdev->saved_raid_disk].rdev == NULL)
first = rdev->saved_raid_disk;
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-06-29 18:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-29 17:40 [PATCH] dm-raid: fix KASAN warning in raid5_add_disks Mikulas Patocka
2022-06-29 17:40 ` [dm-devel] " Mikulas Patocka
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.