* Re: [PATCH] perf scripts python: fix passing arguments to stackcollapse report
[not found] <20200427142327.21172-1-mpetlan@redhat.com>
@ 2021-09-06 14:16 ` Michael Petlan
2021-09-09 12:43 ` Arnaldo Carvalho de Melo
2021-09-09 12:44 ` Arnaldo Carvalho de Melo
1 sibling, 1 reply; 3+ messages in thread
From: Michael Petlan @ 2021-09-06 14:16 UTC (permalink / raw)
To: acme; +Cc: linux-perf-users, jolsa, pbonzini
Hi Arnaldo, could you merge this?
It seems still valid.
Thank you.
Michael
On Mon, 27 Apr 2020, Michael Petlan wrote:
> The '--' prevented arguments from being passed to the script, such as:
>
> $ perf script report stackcollapse -i my_perf.data
>
> Signed-off-by: Michael Petlan <mpetlan@redhat.com>
> ---
> tools/perf/scripts/python/bin/stackcollapse-report | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/scripts/python/bin/stackcollapse-report b/tools/perf/scripts/python/bin/stackcollapse-report
> index 356b9656393d..21a356bd27f6 100755
> --- a/tools/perf/scripts/python/bin/stackcollapse-report
> +++ b/tools/perf/scripts/python/bin/stackcollapse-report
> @@ -1,3 +1,3 @@
> #!/bin/sh
> # description: produce callgraphs in short form for scripting use
> -perf script -s "$PERF_EXEC_PATH"/scripts/python/stackcollapse.py -- "$@"
> +perf script -s "$PERF_EXEC_PATH"/scripts/python/stackcollapse.py "$@"
> --
> 2.18.1
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] perf scripts python: fix passing arguments to stackcollapse report
2021-09-06 14:16 ` [PATCH] perf scripts python: fix passing arguments to stackcollapse report Michael Petlan
@ 2021-09-09 12:43 ` Arnaldo Carvalho de Melo
0 siblings, 0 replies; 3+ messages in thread
From: Arnaldo Carvalho de Melo @ 2021-09-09 12:43 UTC (permalink / raw)
To: Michael Petlan; +Cc: acme, linux-perf-users, jolsa, pbonzini
Em Mon, Sep 06, 2021 at 04:16:21PM +0200, Michael Petlan escreveu:
> Hi Arnaldo, could you merge this?
> It seems still valid.
Next time please reply to the original patch, that way b4 will find it
from the Message-ID from your reply message.
I'm digging it from my inboxes, thanks for resending!
- Arnaldo
> Thank you.
> Michael
>
>
> On Mon, 27 Apr 2020, Michael Petlan wrote:
> > The '--' prevented arguments from being passed to the script, such as:
> >
> > $ perf script report stackcollapse -i my_perf.data
> >
> > Signed-off-by: Michael Petlan <mpetlan@redhat.com>
> > ---
> > tools/perf/scripts/python/bin/stackcollapse-report | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tools/perf/scripts/python/bin/stackcollapse-report b/tools/perf/scripts/python/bin/stackcollapse-report
> > index 356b9656393d..21a356bd27f6 100755
> > --- a/tools/perf/scripts/python/bin/stackcollapse-report
> > +++ b/tools/perf/scripts/python/bin/stackcollapse-report
> > @@ -1,3 +1,3 @@
> > #!/bin/sh
> > # description: produce callgraphs in short form for scripting use
> > -perf script -s "$PERF_EXEC_PATH"/scripts/python/stackcollapse.py -- "$@"
> > +perf script -s "$PERF_EXEC_PATH"/scripts/python/stackcollapse.py "$@"
> > --
> > 2.18.1
> >
> >
--
- Arnaldo
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] perf scripts python: fix passing arguments to stackcollapse report
[not found] <20200427142327.21172-1-mpetlan@redhat.com>
2021-09-06 14:16 ` [PATCH] perf scripts python: fix passing arguments to stackcollapse report Michael Petlan
@ 2021-09-09 12:44 ` Arnaldo Carvalho de Melo
1 sibling, 0 replies; 3+ messages in thread
From: Arnaldo Carvalho de Melo @ 2021-09-09 12:44 UTC (permalink / raw)
To: Michael Petlan; +Cc: linux-perf-users, acme, jolsa, pbonzini
Em Mon, Apr 27, 2020 at 04:23:27PM +0200, Michael Petlan escreveu:
> The '--' prevented arguments from being passed to the script, such as:
>
> $ perf script report stackcollapse -i my_perf.data
Thanks for resending, applied,
- Arnaldo
> Signed-off-by: Michael Petlan <mpetlan@redhat.com>
> ---
> tools/perf/scripts/python/bin/stackcollapse-report | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/scripts/python/bin/stackcollapse-report b/tools/perf/scripts/python/bin/stackcollapse-report
> index 356b9656393d..21a356bd27f6 100755
> --- a/tools/perf/scripts/python/bin/stackcollapse-report
> +++ b/tools/perf/scripts/python/bin/stackcollapse-report
> @@ -1,3 +1,3 @@
> #!/bin/sh
> # description: produce callgraphs in short form for scripting use
> -perf script -s "$PERF_EXEC_PATH"/scripts/python/stackcollapse.py -- "$@"
> +perf script -s "$PERF_EXEC_PATH"/scripts/python/stackcollapse.py "$@"
> --
> 2.18.1
>
--
- Arnaldo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-09-09 13:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20200427142327.21172-1-mpetlan@redhat.com>
2021-09-06 14:16 ` [PATCH] perf scripts python: fix passing arguments to stackcollapse report Michael Petlan
2021-09-09 12:43 ` Arnaldo Carvalho de Melo
2021-09-09 12:44 ` Arnaldo Carvalho de Melo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.