From: James Morris <jmorris@namei.org>
To: David Howells <dhowells@redhat.com>
Cc: keyrings@vger.kernel.org, linux-security-module@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/7] keys: sparse: Fix key_fs[ug]id_changed()
Date: Fri, 24 May 2019 19:38:39 +0000 [thread overview]
Message-ID: <alpine.LRH.2.21.1905250538260.7233@namei.org> (raw)
In-Reply-To: <155856409010.10428.11692778420533145488.stgit@warthog.procyon.org.uk>
On Wed, 22 May 2019, David Howells wrote:
> Sparse warnings are incurred by key_fs[ug]id_changed() due to unprotected
> accesses of tsk->cred, which is marked __rcu.
>
> Fix this by passing the new cred struct to these functions from
> commit_creds() rather than the task pointer.
>
> Signed-off-by: David Howells <dhowells@redhat.com>
Reviewed-by: James Morris <jamorris@linux.microsoft.com>
--
James Morris
<jmorris@namei.org>
WARNING: multiple messages have this Message-ID (diff)
From: James Morris <jmorris@namei.org>
To: David Howells <dhowells@redhat.com>
Cc: keyrings@vger.kernel.org, linux-security-module@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/7] keys: sparse: Fix key_fs[ug]id_changed()
Date: Sat, 25 May 2019 05:38:39 +1000 (AEST) [thread overview]
Message-ID: <alpine.LRH.2.21.1905250538260.7233@namei.org> (raw)
In-Reply-To: <155856409010.10428.11692778420533145488.stgit@warthog.procyon.org.uk>
On Wed, 22 May 2019, David Howells wrote:
> Sparse warnings are incurred by key_fs[ug]id_changed() due to unprotected
> accesses of tsk->cred, which is marked __rcu.
>
> Fix this by passing the new cred struct to these functions from
> commit_creds() rather than the task pointer.
>
> Signed-off-by: David Howells <dhowells@redhat.com>
Reviewed-by: James Morris <jamorris@linux.microsoft.com>
--
James Morris
<jmorris@namei.org>
next prev parent reply other threads:[~2019-05-24 19:38 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-22 22:28 [PATCH 0/7] keys: Miscellany David Howells
2019-05-22 22:28 ` David Howells
2019-05-22 22:28 ` [PATCH 1/7] keys: sparse: Fix key_fs[ug]id_changed() David Howells
2019-05-22 22:28 ` David Howells
2019-05-24 19:38 ` James Morris [this message]
2019-05-24 19:38 ` James Morris
2019-05-22 22:28 ` [PATCH 2/7] keys: sparse: Fix incorrect RCU accesses David Howells
2019-05-22 22:28 ` David Howells
2019-05-25 3:57 ` James Morris
2019-05-25 3:57 ` James Morris
2019-05-22 22:28 ` [PATCH 3/7] keys: sparse: Fix kdoc mismatches David Howells
2019-05-22 22:28 ` David Howells
2019-05-25 3:57 ` James Morris
2019-05-25 3:57 ` James Morris
2019-05-22 22:28 ` [PATCH 4/7] keys: Break bits out of key_unlink() David Howells
2019-05-22 22:28 ` David Howells
2019-05-28 20:41 ` James Morris
2019-05-28 20:41 ` James Morris
2019-05-22 22:28 ` [PATCH 5/7] keys: Make __key_link_begin() handle lockdep nesting David Howells
2019-05-22 22:28 ` David Howells
2019-05-28 20:42 ` James Morris
2019-05-28 20:42 ` James Morris
2019-05-22 22:28 ` [PATCH 6/7] keys: Add a keyctl to move a key between keyrings David Howells
2019-05-22 22:28 ` David Howells
2019-05-28 20:51 ` James Morris
2019-05-28 20:51 ` James Morris
2019-05-29 21:34 ` David Howells
2019-05-29 21:34 ` David Howells
2019-05-29 23:25 ` Eric Biggers
2019-05-29 23:25 ` Eric Biggers
2019-05-30 13:31 ` David Howells
2019-05-30 13:31 ` David Howells
2019-05-22 22:28 ` [PATCH 7/7] keys: Grant Link permission to possessers of request_key auth keys David Howells
2019-05-22 22:28 ` David Howells
2019-05-28 21:01 ` James Morris
2019-05-28 21:01 ` James Morris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LRH.2.21.1905250538260.7233@namei.org \
--to=jmorris@namei.org \
--cc=dhowells@redhat.com \
--cc=keyrings@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.