From: Jiri Kosina <jikos@kernel.org>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Michal Hocko <mhocko@kernel.org>, Toshi Kani <toshi.kani@hp.com>,
joeyli <jlee@suse.com>,
linux-mm@kvack.org, LKML <linux-kernel@vger.kernel.org>,
linux-api@vger.kernel.org
Subject: Re: memory hotplug and force_remove
Date: Thu, 30 Mar 2017 10:47:52 +0200 (CEST) [thread overview]
Message-ID: <alpine.LSU.2.20.1703301046570.31814@cbobk.fhfr.pm> (raw)
In-Reply-To: <2203902.lsAnRkUs2Y@aspire.rjw.lan>
On Tue, 28 Mar 2017, Rafael J. Wysocki wrote:
> > > > we have been chasing the following BUG() triggering during the memory
> > > > hotremove (remove_memory):
> > > > ret = walk_memory_range(PFN_DOWN(start), PFN_UP(start + size - 1), NULL,
> > > > check_memblock_offlined_cb);
> > > > if (ret)
> > > > BUG();
> > > >
> > > > and it took a while to learn that the issue is caused by
> > > > /sys/firmware/acpi/hotplug/force_remove being enabled. I was really
> > > > surprised to see such an option because at least for the memory hotplug
> > > > it cannot work at all. Memory hotplug fails when the memory is still
> > > > in use. Even if we do not BUG() here enforcing the hotplug operation
> > > > will lead to problematic behavior later like crash or a silent memory
> > > > corruption if the memory gets onlined back and reused by somebody else.
> > > >
> > > > I am wondering what was the motivation for introducing this behavior and
> > > > whether there is a way to disallow it for memory hotplug. Or maybe drop
> > > > it completely. What would break in such a case?
> > >
> > > Honestly, I don't remember from the top of my head and I haven't looked at
> > > that code for several months.
> > >
> > > I need some time to recall that.
> >
> > Did you have any chance to look into this?
>
> Well, yes.
>
> It looks like that was added for some people who depended on the old behavior
> at that time.
>
> I guess we can try to drop it and see what happpens. :-)
I'd agree with that; at the same time, udev rule should be submitted to
systemd folks though. I don't think there is anything existing in this
area yet (neither do distros ship their own udev rules for this AFAIK).
Thanks,
--
Jiri Kosina
SUSE Labs
WARNING: multiple messages have this Message-ID (diff)
From: Jiri Kosina <jikos@kernel.org>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Michal Hocko <mhocko@kernel.org>, Toshi Kani <toshi.kani@hp.com>,
joeyli <jlee@suse.com>,
linux-mm@kvack.org, LKML <linux-kernel@vger.kernel.org>,
linux-api@vger.kernel.org
Subject: Re: memory hotplug and force_remove
Date: Thu, 30 Mar 2017 10:47:52 +0200 (CEST) [thread overview]
Message-ID: <alpine.LSU.2.20.1703301046570.31814@cbobk.fhfr.pm> (raw)
In-Reply-To: <2203902.lsAnRkUs2Y@aspire.rjw.lan>
On Tue, 28 Mar 2017, Rafael J. Wysocki wrote:
> > > > we have been chasing the following BUG() triggering during the memory
> > > > hotremove (remove_memory):
> > > > ret = walk_memory_range(PFN_DOWN(start), PFN_UP(start + size - 1), NULL,
> > > > check_memblock_offlined_cb);
> > > > if (ret)
> > > > BUG();
> > > >
> > > > and it took a while to learn that the issue is caused by
> > > > /sys/firmware/acpi/hotplug/force_remove being enabled. I was really
> > > > surprised to see such an option because at least for the memory hotplug
> > > > it cannot work at all. Memory hotplug fails when the memory is still
> > > > in use. Even if we do not BUG() here enforcing the hotplug operation
> > > > will lead to problematic behavior later like crash or a silent memory
> > > > corruption if the memory gets onlined back and reused by somebody else.
> > > >
> > > > I am wondering what was the motivation for introducing this behavior and
> > > > whether there is a way to disallow it for memory hotplug. Or maybe drop
> > > > it completely. What would break in such a case?
> > >
> > > Honestly, I don't remember from the top of my head and I haven't looked at
> > > that code for several months.
> > >
> > > I need some time to recall that.
> >
> > Did you have any chance to look into this?
>
> Well, yes.
>
> It looks like that was added for some people who depended on the old behavior
> at that time.
>
> I guess we can try to drop it and see what happpens. :-)
I'd agree with that; at the same time, udev rule should be submitted to
systemd folks though. I don't think there is anything existing in this
area yet (neither do distros ship their own udev rules for this AFAIK).
Thanks,
--
Jiri Kosina
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-03-30 8:48 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-20 19:29 memory hotplug and force_remove Michal Hocko
2017-03-20 19:29 ` Michal Hocko
2017-03-20 21:24 ` Rafael J. Wysocki
2017-03-20 21:24 ` Rafael J. Wysocki
2017-03-21 16:13 ` joeyli
2017-03-21 16:13 ` joeyli
2017-03-28 7:58 ` Michal Hocko
2017-03-28 7:58 ` Michal Hocko
2017-03-28 15:22 ` Rafael J. Wysocki
2017-03-28 15:22 ` Rafael J. Wysocki
2017-03-30 8:47 ` Jiri Kosina [this message]
2017-03-30 8:47 ` Jiri Kosina
2017-03-30 16:20 ` Michal Hocko
2017-03-30 16:20 ` Michal Hocko
2017-03-30 16:57 ` joeyli
2017-03-30 16:57 ` joeyli
2017-03-30 16:57 ` joeyli
2017-03-30 20:15 ` Rafael J. Wysocki
2017-03-30 20:15 ` Rafael J. Wysocki
2017-03-30 20:15 ` Rafael J. Wysocki
2017-03-31 0:00 ` joeyli
2017-03-31 0:00 ` joeyli
2017-03-31 8:30 ` Michal Hocko
2017-03-31 8:30 ` Michal Hocko
2017-03-31 8:30 ` Michal Hocko
2017-03-31 10:49 ` joeyli
2017-03-31 10:49 ` joeyli
2017-03-31 10:49 ` joeyli
2017-03-31 10:55 ` Michal Hocko
2017-03-31 10:55 ` Michal Hocko
2017-03-31 10:55 ` Michal Hocko
2017-03-31 11:55 ` joeyli
2017-03-31 11:55 ` joeyli
2017-03-31 11:55 ` joeyli
2017-03-31 12:02 ` Michal Hocko
2017-03-31 12:02 ` Michal Hocko
2017-03-31 22:35 ` Rafael J. Wysocki
2017-03-31 22:35 ` Rafael J. Wysocki
2017-03-31 22:35 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LSU.2.20.1703301046570.31814@cbobk.fhfr.pm \
--to=jikos@kernel.org \
--cc=jlee@suse.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=rjw@rjwysocki.net \
--cc=toshi.kani@hp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.