From: Miroslav Benes <mbenes@suse.cz>
To: Sami Tolvanen <samitolvanen@google.com>
Cc: Masahiro Yamada <masahiroy@kernel.org>,
Will Deacon <will@kernel.org>,
Steven Rostedt <rostedt@goodmis.org>,
Peter Zijlstra <peterz@infradead.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Paul E. McKenney" <paulmck@kernel.org>,
Kees Cook <keescook@chromium.org>,
Nick Desaulniers <ndesaulniers@google.com>,
clang-built-linux@googlegroups.com,
kernel-hardening@lists.openwall.com, linux-arch@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-pci@vger.kernel.org, x86@kernel.org, jthierry@redhat.com,
jpoimboe@redhat.com
Subject: Re: [PATCH v4 04/29] objtool: Add a pass for generating __mcount_loc
Date: Thu, 1 Oct 2020 15:17:07 +0200 (CEST) [thread overview]
Message-ID: <alpine.LSU.2.21.2010011504340.6689@pobox.suse.cz> (raw)
In-Reply-To: <20200929214631.3516445-5-samitolvanen@google.com>
Hi Sami,
On Tue, 29 Sep 2020, Sami Tolvanen wrote:
> From: Peter Zijlstra <peterz@infradead.org>
>
> Add the --mcount option for generating __mcount_loc sections
> needed for dynamic ftrace. Using this pass requires the kernel to
> be compiled with -mfentry and CC_USING_NOP_MCOUNT to be defined
> in Makefile.
>
> Link: https://lore.kernel.org/lkml/20200625200235.GQ4781@hirez.programming.kicks-ass.net/
> Signed-off-by: Peter Zijlstra <peterz@infradead.org>
> [Sami: rebased to mainline, dropped config changes, fixed to actually use
> --mcount, and wrote a commit message.]
> Signed-off-by: Sami Tolvanen <samitolvanen@google.com>
> Reviewed-by: Kees Cook <keescook@chromium.org>
I am sorry to reply on v4. Should have been sooner.
Julien has been sending patches to make objtool's check functionality
arch-agnostic as much as possible. So it seems to me that the patch should
be based on the effort
I also wonder about making 'mcount' command separate from 'check'. Similar
to what is 'orc' now. But that could be done later.
See tip-tree/objtool/core for both.
Thanks
Miroslav
WARNING: multiple messages have this Message-ID (diff)
From: Miroslav Benes <mbenes@suse.cz>
To: Sami Tolvanen <samitolvanen@google.com>
Cc: linux-arch@vger.kernel.org, x86@kernel.org,
Kees Cook <keescook@chromium.org>,
"Paul E. McKenney" <paulmck@kernel.org>,
kernel-hardening@lists.openwall.com,
Peter Zijlstra <peterz@infradead.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Masahiro Yamada <masahiroy@kernel.org>,
linux-kbuild@vger.kernel.org,
Nick Desaulniers <ndesaulniers@google.com>,
linux-kernel@vger.kernel.org,
Steven Rostedt <rostedt@goodmis.org>,
clang-built-linux@googlegroups.com, jpoimboe@redhat.com,
linux-pci@vger.kernel.org, Will Deacon <will@kernel.org>,
linux-arm-kernel@lists.infradead.org, jthierry@redhat.com
Subject: Re: [PATCH v4 04/29] objtool: Add a pass for generating __mcount_loc
Date: Thu, 1 Oct 2020 15:17:07 +0200 (CEST) [thread overview]
Message-ID: <alpine.LSU.2.21.2010011504340.6689@pobox.suse.cz> (raw)
In-Reply-To: <20200929214631.3516445-5-samitolvanen@google.com>
Hi Sami,
On Tue, 29 Sep 2020, Sami Tolvanen wrote:
> From: Peter Zijlstra <peterz@infradead.org>
>
> Add the --mcount option for generating __mcount_loc sections
> needed for dynamic ftrace. Using this pass requires the kernel to
> be compiled with -mfentry and CC_USING_NOP_MCOUNT to be defined
> in Makefile.
>
> Link: https://lore.kernel.org/lkml/20200625200235.GQ4781@hirez.programming.kicks-ass.net/
> Signed-off-by: Peter Zijlstra <peterz@infradead.org>
> [Sami: rebased to mainline, dropped config changes, fixed to actually use
> --mcount, and wrote a commit message.]
> Signed-off-by: Sami Tolvanen <samitolvanen@google.com>
> Reviewed-by: Kees Cook <keescook@chromium.org>
I am sorry to reply on v4. Should have been sooner.
Julien has been sending patches to make objtool's check functionality
arch-agnostic as much as possible. So it seems to me that the patch should
be based on the effort
I also wonder about making 'mcount' command separate from 'check'. Similar
to what is 'orc' now. But that could be done later.
See tip-tree/objtool/core for both.
Thanks
Miroslav
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-10-01 13:17 UTC|newest]
Thread overview: 120+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-29 21:46 [PATCH v4 00/29] Add support for Clang LTO Sami Tolvanen
2020-09-29 21:46 ` Sami Tolvanen
2020-09-29 21:46 ` Sami Tolvanen
2020-09-29 21:46 ` [PATCH v4 01/29] RAS/CEC: Fix cec_init() prototype Sami Tolvanen
2020-09-29 21:46 ` Sami Tolvanen
2020-09-29 21:46 ` Sami Tolvanen
2020-09-29 21:46 ` [PATCH v4 02/29] x86/asm: Replace __force_order with memory clobber Sami Tolvanen
2020-09-29 21:46 ` Sami Tolvanen
2020-09-29 21:46 ` Sami Tolvanen
2020-09-29 21:46 ` [PATCH v4 03/29] kbuild: preprocess module linker script Sami Tolvanen
2020-09-29 21:46 ` Sami Tolvanen
2020-09-29 21:46 ` Sami Tolvanen
2020-09-29 21:46 ` [PATCH v4 04/29] objtool: Add a pass for generating __mcount_loc Sami Tolvanen
2020-09-29 21:46 ` Sami Tolvanen
2020-09-29 21:46 ` Sami Tolvanen
2020-10-01 13:17 ` Miroslav Benes [this message]
2020-10-01 13:17 ` Miroslav Benes
2020-10-01 13:17 ` Miroslav Benes
2020-10-01 13:36 ` Peter Zijlstra
2020-10-01 13:36 ` Peter Zijlstra
2020-10-02 14:13 ` Josh Poimboeuf
2020-10-02 14:13 ` Josh Poimboeuf
2020-10-05 7:10 ` Miroslav Benes
2020-10-05 7:10 ` Miroslav Benes
2020-10-05 7:10 ` Miroslav Benes
2020-09-29 21:46 ` [PATCH v4 05/29] objtool: Don't autodetect vmlinux.o Sami Tolvanen
2020-09-29 21:46 ` Sami Tolvanen
2020-09-29 21:46 ` Sami Tolvanen
2020-09-29 21:46 ` [PATCH v4 06/29] tracing: move function tracer options to Kconfig Sami Tolvanen
2020-09-29 21:46 ` Sami Tolvanen
2020-09-29 21:46 ` Sami Tolvanen
2020-09-30 0:12 ` Steven Rostedt
2020-09-30 0:12 ` Steven Rostedt
2020-09-30 16:05 ` Sami Tolvanen
2020-09-30 16:05 ` Sami Tolvanen
2020-09-30 16:05 ` Sami Tolvanen
2020-09-29 21:46 ` [PATCH v4 07/29] tracing: add support for objtool mcount Sami Tolvanen
2020-09-29 21:46 ` Sami Tolvanen
2020-09-29 21:46 ` Sami Tolvanen
2020-09-29 21:46 ` [PATCH v4 08/29] x86, build: use " Sami Tolvanen
2020-09-29 21:46 ` Sami Tolvanen
2020-09-29 21:46 ` Sami Tolvanen
2020-09-29 21:46 ` [PATCH v4 09/29] arm64: disable recordmcount with DYNAMIC_FTRACE_WITH_REGS Sami Tolvanen
2020-09-29 21:46 ` Sami Tolvanen
2020-09-29 21:46 ` Sami Tolvanen
2020-09-30 9:58 ` Mark Rutland
2020-09-30 9:58 ` Mark Rutland
2020-09-30 17:10 ` Sami Tolvanen
2020-09-30 17:10 ` Sami Tolvanen
2020-09-30 17:10 ` Sami Tolvanen
2020-09-29 21:46 ` [PATCH v4 10/29] treewide: remove DISABLE_LTO Sami Tolvanen
2020-09-29 21:46 ` Sami Tolvanen
2020-09-29 21:46 ` Sami Tolvanen
2020-09-30 20:45 ` Kees Cook
2020-09-30 20:45 ` Kees Cook
2020-09-29 21:46 ` [PATCH v4 11/29] kbuild: add support for Clang LTO Sami Tolvanen
2020-09-29 21:46 ` Sami Tolvanen
2020-09-29 21:46 ` Sami Tolvanen
2020-09-29 21:46 ` [PATCH v4 12/29] kbuild: lto: fix module versioning Sami Tolvanen
2020-09-29 21:46 ` Sami Tolvanen
2020-09-29 21:46 ` Sami Tolvanen
2020-09-29 21:46 ` [PATCH v4 13/29] kbuild: lto: postpone objtool Sami Tolvanen
2020-09-29 21:46 ` Sami Tolvanen
2020-09-29 21:46 ` Sami Tolvanen
2020-09-29 21:46 ` [PATCH v4 14/29] kbuild: lto: limit inlining Sami Tolvanen
2020-09-29 21:46 ` Sami Tolvanen
2020-09-29 21:46 ` Sami Tolvanen
2020-09-29 21:46 ` [PATCH v4 15/29] kbuild: lto: merge module sections Sami Tolvanen
2020-09-29 21:46 ` Sami Tolvanen
2020-09-29 21:46 ` Sami Tolvanen
2020-09-29 21:46 ` [PATCH v4 16/29] kbuild: lto: remove duplicate dependencies from .mod files Sami Tolvanen
2020-09-29 21:46 ` Sami Tolvanen
2020-09-29 21:46 ` Sami Tolvanen
2020-09-29 21:46 ` [PATCH v4 17/29] init: lto: ensure initcall ordering Sami Tolvanen
2020-09-29 21:46 ` Sami Tolvanen
2020-09-29 21:46 ` Sami Tolvanen
2020-09-29 21:46 ` [PATCH v4 18/29] init: lto: fix PREL32 relocations Sami Tolvanen
2020-09-29 21:46 ` Sami Tolvanen
2020-09-29 21:46 ` Sami Tolvanen
2020-09-29 21:46 ` [PATCH v4 19/29] PCI: Fix PREL32 relocations for LTO Sami Tolvanen
2020-09-29 21:46 ` Sami Tolvanen
2020-09-29 21:46 ` Sami Tolvanen
2020-09-29 21:46 ` [PATCH v4 20/29] modpost: lto: strip .lto from module names Sami Tolvanen
2020-09-29 21:46 ` Sami Tolvanen
2020-09-29 21:46 ` Sami Tolvanen
2020-09-29 21:46 ` [PATCH v4 21/29] scripts/mod: disable LTO for empty.c Sami Tolvanen
2020-09-29 21:46 ` Sami Tolvanen
2020-09-29 21:46 ` Sami Tolvanen
2020-09-29 21:46 ` [PATCH v4 22/29] efi/libstub: disable LTO Sami Tolvanen
2020-09-29 21:46 ` Sami Tolvanen
2020-09-29 21:46 ` Sami Tolvanen
2020-09-29 21:46 ` [PATCH v4 23/29] drivers/misc/lkdtm: disable LTO for rodata.o Sami Tolvanen
2020-09-29 21:46 ` Sami Tolvanen
2020-09-29 21:46 ` Sami Tolvanen
2020-09-29 21:46 ` [PATCH v4 24/29] arm64: vdso: disable LTO Sami Tolvanen
2020-09-29 21:46 ` Sami Tolvanen
2020-09-29 21:46 ` Sami Tolvanen
2020-09-29 21:46 ` [PATCH v4 25/29] KVM: arm64: disable LTO for the nVHE directory Sami Tolvanen
2020-09-29 21:46 ` Sami Tolvanen
2020-09-29 21:46 ` Sami Tolvanen
2020-09-29 21:46 ` [PATCH v4 26/29] arm64: allow LTO_CLANG and THINLTO to be selected Sami Tolvanen
2020-09-29 21:46 ` Sami Tolvanen
2020-09-29 21:46 ` Sami Tolvanen
2020-09-29 21:46 ` [PATCH v4 27/29] x86, vdso: disable LTO only for vDSO Sami Tolvanen
2020-09-29 21:46 ` Sami Tolvanen
2020-09-29 21:46 ` Sami Tolvanen
2020-09-29 21:46 ` [PATCH v4 28/29] x86, cpu: disable LTO for cpu.c Sami Tolvanen
2020-09-29 21:46 ` Sami Tolvanen
2020-09-29 21:46 ` Sami Tolvanen
2020-09-29 21:46 ` [PATCH v4 29/29] x86, build: allow LTO_CLANG and THINLTO to be selected Sami Tolvanen
2020-09-29 21:46 ` Sami Tolvanen
2020-09-29 21:46 ` Sami Tolvanen
2020-09-30 21:10 ` [PATCH v4 00/29] Add support for Clang LTO Kees Cook
2020-09-30 21:10 ` Kees Cook
2020-09-30 21:58 ` Nick Desaulniers
2020-09-30 21:58 ` Nick Desaulniers
2020-09-30 21:58 ` Nick Desaulniers
2020-09-30 22:12 ` Sami Tolvanen
2020-09-30 22:12 ` Sami Tolvanen
2020-09-30 22:12 ` Sami Tolvanen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LSU.2.21.2010011504340.6689@pobox.suse.cz \
--to=mbenes@suse.cz \
--cc=clang-built-linux@googlegroups.com \
--cc=gregkh@linuxfoundation.org \
--cc=jpoimboe@redhat.com \
--cc=jthierry@redhat.com \
--cc=keescook@chromium.org \
--cc=kernel-hardening@lists.openwall.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=ndesaulniers@google.com \
--cc=paulmck@kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=samitolvanen@google.com \
--cc=will@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.