All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chad Dupuis <chad.dupuis@cavium.com>
To: Hannes Reinecke <hare@suse.de>
Cc: <martin.petersen@oracle.com>, <linux-scsi@vger.kernel.org>,
	<fcoe-devel@open-fcoe.org>, <netdev@vger.kernel.org>,
	<yuval.mintz@cavium.com>, <QLogic-Storage-Upstream@cavium.com>
Subject: Re: [PATCH V2 2/2] qedf: Add QLogic FastLinQ offload FCoE driver framework.
Date: Tue, 31 Jan 2017 13:38:45 -0500	[thread overview]
Message-ID: <alpine.OSX.2.00.1701311333580.1961@administrators-macbook-pro.local> (raw)
In-Reply-To: <28df9087-4eaf-d72c-ccee-89408d3a1b32@suse.de>



On Mon, 30 Jan 2017, 10:34am -0000, Hannes Reinecke wrote:

> On 01/25/2017 09:33 PM, Dupuis, Chad wrote:

> > +static int qedf_request_msix_irq(struct qedf_ctx *qedf)
> > +{
> > +	int i, rc, cpu;
> > +
> > +	cpu = cpumask_first(cpu_online_mask);
> > +	for (i = 0; i < qedf->num_queues; i++) {
> > +		rc = request_irq(qedf->int_info.msix[i].vector,
> > +		    qedf_msix_handler, 0, "qedf", &qedf->fp_array[i]);
> > +
> > +		if (rc) {
> > +			QEDF_WARN(&(qedf->dbg_ctx), "request_irq failed.\n");
> > +			qedf_sync_free_irqs(qedf);
> > +			return rc;
> > +		}
> > +
> > +		qedf->int_info.used_cnt++;
> > +		rc = irq_set_affinity_hint(qedf->int_info.msix[i].vector,
> > +		    get_cpu_mask(cpu));
> > +		cpu = cpumask_next(cpu, cpu_online_mask);
> > +	}
> > +
> > +	return 0;
> > +}
> > +
> Please use pci_alloc_irq_vectors() here; that avoid you having to do SMP
> affinity setting yourself.

This wil be difficult to coordinate with three other drivers (qedi, qede 
and qedr) using the same vector allocation code in the qed module.

> 
> Cheers,
> 
> Hannes
> 

WARNING: multiple messages have this Message-ID (diff)
From: Chad Dupuis <chad.dupuis@cavium.com>
To: Hannes Reinecke <hare@suse.de>
Cc: martin.petersen@oracle.com, linux-scsi@vger.kernel.org,
	fcoe-devel@open-fcoe.org, netdev@vger.kernel.org,
	yuval.mintz@cavium.com, QLogic-Storage-Upstream@cavium.com
Subject: Re: [PATCH V2 2/2] qedf: Add QLogic FastLinQ offload FCoE driver framework.
Date: Tue, 31 Jan 2017 13:38:45 -0500	[thread overview]
Message-ID: <alpine.OSX.2.00.1701311333580.1961@administrators-macbook-pro.local> (raw)
In-Reply-To: <28df9087-4eaf-d72c-ccee-89408d3a1b32@suse.de>



On Mon, 30 Jan 2017, 10:34am -0000, Hannes Reinecke wrote:

> On 01/25/2017 09:33 PM, Dupuis, Chad wrote:

> > +static int qedf_request_msix_irq(struct qedf_ctx *qedf)
> > +{
> > +	int i, rc, cpu;
> > +
> > +	cpu = cpumask_first(cpu_online_mask);
> > +	for (i = 0; i < qedf->num_queues; i++) {
> > +		rc = request_irq(qedf->int_info.msix[i].vector,
> > +		    qedf_msix_handler, 0, "qedf", &qedf->fp_array[i]);
> > +
> > +		if (rc) {
> > +			QEDF_WARN(&(qedf->dbg_ctx), "request_irq failed.\n");
> > +			qedf_sync_free_irqs(qedf);
> > +			return rc;
> > +		}
> > +
> > +		qedf->int_info.used_cnt++;
> > +		rc = irq_set_affinity_hint(qedf->int_info.msix[i].vector,
> > +		    get_cpu_mask(cpu));
> > +		cpu = cpumask_next(cpu, cpu_online_mask);
> > +	}
> > +
> > +	return 0;
> > +}
> > +
> Please use pci_alloc_irq_vectors() here; that avoid you having to do SMP
> affinity setting yourself.

This wil be difficult to coordinate with three other drivers (qedi, qede 
and qedr) using the same vector allocation code in the qed module.

> 
> Cheers,
> 
> Hannes
> 

  parent reply	other threads:[~2017-01-31 18:38 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-25 20:33 [PATCH V2 0/2] Add QLogic FastLinQ FCoE (qedf) driver Dupuis, Chad
2017-01-25 20:33 ` Dupuis, Chad
2017-01-25 20:33 ` [PATCH V2 net-next 1/2] qed: Add support for hardware offloaded FCoE Dupuis, Chad
2017-01-25 20:33   ` Dupuis, Chad
     [not found]   ` <1485376423-18737-2-git-send-email-chad.dupuis-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org>
2017-01-30  9:44     ` Hannes Reinecke
2017-01-30 18:53       ` Arun Easi
2017-01-30 18:53         ` Arun Easi
2017-01-25 20:33 ` [PATCH V2 2/2] qedf: Add QLogic FastLinQ offload FCoE driver framework Dupuis, Chad
2017-01-25 20:33   ` Dupuis, Chad
2017-01-25 21:53   ` kbuild test robot
     [not found]   ` <1485376423-18737-3-git-send-email-chad.dupuis-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org>
2017-01-30 10:34     ` Hannes Reinecke
     [not found]       ` <28df9087-4eaf-d72c-ccee-89408d3a1b32-l3A5Bk7waGM@public.gmane.org>
2017-01-31 17:08         ` Chad Dupuis
     [not found]           ` <alpine.OSX.2.00.1701311156290.1169-nVgGmETfwnIFUnR/tdpssI0aTaFgKE92ACYyPGjX6YU@public.gmane.org>
2017-02-01  7:59             ` Hannes Reinecke
2017-01-31 18:38       ` Chad Dupuis [this message]
2017-01-31 18:38         ` Chad Dupuis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.OSX.2.00.1701311333580.1961@administrators-macbook-pro.local \
    --to=chad.dupuis@cavium.com \
    --cc=QLogic-Storage-Upstream@cavium.com \
    --cc=fcoe-devel@open-fcoe.org \
    --cc=hare@suse.de \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=netdev@vger.kernel.org \
    --cc=yuval.mintz@cavium.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.