All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCHi v2] staging:media:davinci_vpfe: Fixed block comments according to kernel coding style
@ 2016-02-14 11:12 Thaissa Falbo
  2016-02-14 16:20 ` [Outreachy kernel] " Julia Lawall
  0 siblings, 1 reply; 4+ messages in thread
From: Thaissa Falbo @ 2016-02-14 11:12 UTC (permalink / raw)
  To: outreachy-kernel

In v2:
Lined up the *s, according to Julia's instructions

In v1:
Fixed block comments by following the checkpatch warnings

WARNING: Block comments use * on subsequent lines
WARNING: Block comments use a trailing */ on separate line


Signed-off-by: Thaissa Falbo <thaissa.falbo@gmail.com>
---
 .../staging/media/davinci_vpfe/davinci_vpfe_user.h   |  4 ++--
 drivers/staging/media/davinci_vpfe/dm365_ipipe_hw.c  | 12 ++++++++----
 drivers/staging/media/davinci_vpfe/dm365_ipipe_hw.h  |  7 ++++---
 drivers/staging/media/davinci_vpfe/vpfe_mc_capture.c |  6 ++++--
 drivers/staging/media/davinci_vpfe/vpfe_video.c      | 20 ++++++++++++--------
 5 files changed, 30 insertions(+), 19 deletions(-)

diff --git a/drivers/staging/media/davinci_vpfe/davinci_vpfe_user.h b/drivers/staging/media/davinci_vpfe/davinci_vpfe_user.h
index 7b7e7b2..0425a1b 100644
--- a/drivers/staging/media/davinci_vpfe/davinci_vpfe_user.h
+++ b/drivers/staging/media/davinci_vpfe/davinci_vpfe_user.h
@@ -538,8 +538,8 @@ struct vpfe_isif_raw_config {
 };
 
 /**********************************************************************
-      IPIPE API Structures
-**********************************************************************/
+ * IPIPE API Structures
+ **********************************************************************/
 
 /* IPIPE module configurations */
 
diff --git a/drivers/staging/media/davinci_vpfe/dm365_ipipe_hw.c b/drivers/staging/media/davinci_vpfe/dm365_ipipe_hw.c
index b1d5e23..0792fbd 100644
--- a/drivers/staging/media/davinci_vpfe/dm365_ipipe_hw.c
+++ b/drivers/staging/media/davinci_vpfe/dm365_ipipe_hw.c
@@ -682,8 +682,10 @@ ipipe_set_rgb2rgb_regs(void __iomem *base_addr, unsigned int id,
 	ipipe_clock_enable(base_addr);
 
 	if (id == IPIPE_RGB2RGB_2) {
-		/* For second RGB module, gain integer is 3 bits instead
-		of 4, offset has 11 bits insread of 13 */
+		/*
+		 * For second RGB module, gain integer is 3 bits instead
+		 * of 4, offset has 11 bits insread of 13
+		 */
 		offset = RGB2_MUL_BASE;
 		integ_mask = 0x7;
 		offset_mask = RGB2RGB_2_OFST_MASK;
@@ -792,8 +794,10 @@ ipipe_set_3d_lut_regs(void __iomem *base_addr, void __iomem *isp5_base_addr,
 	/* valied table */
 	tbl = lut_3d->table;
 	for (i = 0; i < VPFE_IPIPE_MAX_SIZE_3D_LUT; i++) {
-		/* Each entry has 0-9 (B), 10-19 (G) and
-		20-29 R values */
+		/*
+		 * Each entry has 0-9 (B), 10-19 (G) and
+		 * 20-29 R values
+		 */
 		val = tbl[i].b & D3_LUT_ENTRY_MASK;
 		val |= (tbl[i].g & D3_LUT_ENTRY_MASK) <<
 			 D3_LUT_ENTRY_G_SHIFT;
diff --git a/drivers/staging/media/davinci_vpfe/dm365_ipipe_hw.h b/drivers/staging/media/davinci_vpfe/dm365_ipipe_hw.h
index 2bf2f7a..7ee1572 100644
--- a/drivers/staging/media/davinci_vpfe/dm365_ipipe_hw.h
+++ b/drivers/staging/media/davinci_vpfe/dm365_ipipe_hw.h
@@ -278,9 +278,10 @@
 /* Resizer Rescale Parameters */
 #define RSZ_EN_A		0x58
 #define RSZ_EN_B		0xe8
-/* offset of the registers to be added with base register of
-   either RSZ0 or RSZ1
-*/
+/*
+ * offset of the registers to be added with base register of
+ * either RSZ0 or RSZ1
+ */
 #define RSZ_MODE		0x4
 #define RSZ_420			0x8
 #define RSZ_I_VPS		0xc
diff --git a/drivers/staging/media/davinci_vpfe/vpfe_mc_capture.c b/drivers/staging/media/davinci_vpfe/vpfe_mc_capture.c
index ec46f36..bf077f8 100644
--- a/drivers/staging/media/davinci_vpfe/vpfe_mc_capture.c
+++ b/drivers/staging/media/davinci_vpfe/vpfe_mc_capture.c
@@ -442,8 +442,10 @@ static int vpfe_register_entities(struct vpfe_device *vpfe_dev)
 
 	/* create links now, starting with external(i2c) entities */
 	for (i = 0; i < vpfe_dev->num_ext_subdevs; i++)
-		/* if entity has no pads (ex: amplifier),
-		   cant establish link */
+		/*
+		 * if entity has no pads (ex: amplifier),
+		 * cant establish link
+		 */
 		if (vpfe_dev->sd[i]->entity.num_pads) {
 			ret = media_create_pad_link(&vpfe_dev->sd[i]->entity,
 				0, &vpfe_dev->vpfe_isif.subdev.entity,
diff --git a/drivers/staging/media/davinci_vpfe/vpfe_video.c b/drivers/staging/media/davinci_vpfe/vpfe_video.c
index 3ec7e65..e0658bc 100644
--- a/drivers/staging/media/davinci_vpfe/vpfe_video.c
+++ b/drivers/staging/media/davinci_vpfe/vpfe_video.c
@@ -178,9 +178,10 @@ static int vpfe_update_pipe_state(struct vpfe_video_device *video)
 	if (ret)
 		return ret;
 
-	/* Find out if there is any input video
-	  if yes, it is single shot.
-	*/
+	/*
+	 * Find out if there is any input video
+	 * if yes, it is single shot.
+	 */
 	if (pipe->input_num == 0) {
 		pipe->state = VPFE_PIPELINE_STREAM_CONTINUOUS;
 		ret = vpfe_update_current_ext_subdev(video);
@@ -529,9 +530,10 @@ static int vpfe_release(struct file *file)
 	if (fh->io_allowed) {
 		if (video->started) {
 			vpfe_stop_capture(video);
-			/* mark pipe state as stopped in vpfe_release(),
-			   as app might call streamon() after streamoff()
-			   in which case driver has to start streaming.
+			/*
+			 * mark pipe state as stopped in vpfe_release(),
+			 * as app might call streamon() after streamoff()
+			 * in which case driver has to start streaming.
 			*/
 			video->pipe.state = VPFE_PIPELINE_STREAM_STOPPED;
 			vb2_streamoff(&video->buffer_queue,
@@ -672,8 +674,10 @@ static int vpfe_enum_fmt(struct file *file, void  *priv,
 
 	v4l2_dbg(1, debug, &vpfe_dev->v4l2_dev, "vpfe_enum_fmt\n");
 
-	/* since already subdev pad format is set,
-	only one pixel format is available */
+	/*
+	 * since already subdev pad format is set,
+	 * only one pixel format is available
+	 */
 	if (fmt->index > 0) {
 		v4l2_err(&vpfe_dev->v4l2_dev, "Invalid index\n");
 		return -EINVAL;
-- 
2.1.4



^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [Outreachy kernel] [PATCHi v2] staging:media:davinci_vpfe: Fixed block comments according to kernel coding style
  2016-02-14 11:12 [PATCHi v2] staging:media:davinci_vpfe: Fixed block comments according to kernel coding style Thaissa Falbo
@ 2016-02-14 16:20 ` Julia Lawall
  2016-02-14 23:21   ` Thaissa Falbo
  0 siblings, 1 reply; 4+ messages in thread
From: Julia Lawall @ 2016-02-14 16:20 UTC (permalink / raw)
  To: Thaissa Falbo; +Cc: outreachy-kernel

On Sun, 14 Feb 2016, Thaissa Falbo wrote:

> In v2:
> Lined up the *s, according to Julia's instructions
> 
> In v1:
> Fixed block comments by following the checkpatch warnings

The above information is supposed to go below the ---.  Actually, this 
historical information is not interesting once the patch is applied, 
because only the most recent version is applied.  And the text that is 
below the --- and is not part of the patch disappears when the patch is 
applied.

julia

> WARNING: Block comments use * on subsequent lines
> WARNING: Block comments use a trailing */ on separate line
> 
> 
> Signed-off-by: Thaissa Falbo <thaissa.falbo@gmail.com>
> ---
>  .../staging/media/davinci_vpfe/davinci_vpfe_user.h   |  4 ++--
>  drivers/staging/media/davinci_vpfe/dm365_ipipe_hw.c  | 12 ++++++++----
>  drivers/staging/media/davinci_vpfe/dm365_ipipe_hw.h  |  7 ++++---
>  drivers/staging/media/davinci_vpfe/vpfe_mc_capture.c |  6 ++++--
>  drivers/staging/media/davinci_vpfe/vpfe_video.c      | 20 ++++++++++++--------
>  5 files changed, 30 insertions(+), 19 deletions(-)
> 
> diff --git a/drivers/staging/media/davinci_vpfe/davinci_vpfe_user.h b/drivers/staging/media/davinci_vpfe/davinci_vpfe_user.h
> index 7b7e7b2..0425a1b 100644
> --- a/drivers/staging/media/davinci_vpfe/davinci_vpfe_user.h
> +++ b/drivers/staging/media/davinci_vpfe/davinci_vpfe_user.h
> @@ -538,8 +538,8 @@ struct vpfe_isif_raw_config {
>  };
>  
>  /**********************************************************************
> -      IPIPE API Structures
> -**********************************************************************/
> + * IPIPE API Structures
> + **********************************************************************/
>  
>  /* IPIPE module configurations */
>  
> diff --git a/drivers/staging/media/davinci_vpfe/dm365_ipipe_hw.c b/drivers/staging/media/davinci_vpfe/dm365_ipipe_hw.c
> index b1d5e23..0792fbd 100644
> --- a/drivers/staging/media/davinci_vpfe/dm365_ipipe_hw.c
> +++ b/drivers/staging/media/davinci_vpfe/dm365_ipipe_hw.c
> @@ -682,8 +682,10 @@ ipipe_set_rgb2rgb_regs(void __iomem *base_addr, unsigned int id,
>  	ipipe_clock_enable(base_addr);
>  
>  	if (id == IPIPE_RGB2RGB_2) {
> -		/* For second RGB module, gain integer is 3 bits instead
> -		of 4, offset has 11 bits insread of 13 */
> +		/*
> +		 * For second RGB module, gain integer is 3 bits instead
> +		 * of 4, offset has 11 bits insread of 13
> +		 */
>  		offset = RGB2_MUL_BASE;
>  		integ_mask = 0x7;
>  		offset_mask = RGB2RGB_2_OFST_MASK;
> @@ -792,8 +794,10 @@ ipipe_set_3d_lut_regs(void __iomem *base_addr, void __iomem *isp5_base_addr,
>  	/* valied table */
>  	tbl = lut_3d->table;
>  	for (i = 0; i < VPFE_IPIPE_MAX_SIZE_3D_LUT; i++) {
> -		/* Each entry has 0-9 (B), 10-19 (G) and
> -		20-29 R values */
> +		/*
> +		 * Each entry has 0-9 (B), 10-19 (G) and
> +		 * 20-29 R values
> +		 */
>  		val = tbl[i].b & D3_LUT_ENTRY_MASK;
>  		val |= (tbl[i].g & D3_LUT_ENTRY_MASK) <<
>  			 D3_LUT_ENTRY_G_SHIFT;
> diff --git a/drivers/staging/media/davinci_vpfe/dm365_ipipe_hw.h b/drivers/staging/media/davinci_vpfe/dm365_ipipe_hw.h
> index 2bf2f7a..7ee1572 100644
> --- a/drivers/staging/media/davinci_vpfe/dm365_ipipe_hw.h
> +++ b/drivers/staging/media/davinci_vpfe/dm365_ipipe_hw.h
> @@ -278,9 +278,10 @@
>  /* Resizer Rescale Parameters */
>  #define RSZ_EN_A		0x58
>  #define RSZ_EN_B		0xe8
> -/* offset of the registers to be added with base register of
> -   either RSZ0 or RSZ1
> -*/
> +/*
> + * offset of the registers to be added with base register of
> + * either RSZ0 or RSZ1
> + */
>  #define RSZ_MODE		0x4
>  #define RSZ_420			0x8
>  #define RSZ_I_VPS		0xc
> diff --git a/drivers/staging/media/davinci_vpfe/vpfe_mc_capture.c b/drivers/staging/media/davinci_vpfe/vpfe_mc_capture.c
> index ec46f36..bf077f8 100644
> --- a/drivers/staging/media/davinci_vpfe/vpfe_mc_capture.c
> +++ b/drivers/staging/media/davinci_vpfe/vpfe_mc_capture.c
> @@ -442,8 +442,10 @@ static int vpfe_register_entities(struct vpfe_device *vpfe_dev)
>  
>  	/* create links now, starting with external(i2c) entities */
>  	for (i = 0; i < vpfe_dev->num_ext_subdevs; i++)
> -		/* if entity has no pads (ex: amplifier),
> -		   cant establish link */
> +		/*
> +		 * if entity has no pads (ex: amplifier),
> +		 * cant establish link
> +		 */
>  		if (vpfe_dev->sd[i]->entity.num_pads) {
>  			ret = media_create_pad_link(&vpfe_dev->sd[i]->entity,
>  				0, &vpfe_dev->vpfe_isif.subdev.entity,
> diff --git a/drivers/staging/media/davinci_vpfe/vpfe_video.c b/drivers/staging/media/davinci_vpfe/vpfe_video.c
> index 3ec7e65..e0658bc 100644
> --- a/drivers/staging/media/davinci_vpfe/vpfe_video.c
> +++ b/drivers/staging/media/davinci_vpfe/vpfe_video.c
> @@ -178,9 +178,10 @@ static int vpfe_update_pipe_state(struct vpfe_video_device *video)
>  	if (ret)
>  		return ret;
>  
> -	/* Find out if there is any input video
> -	  if yes, it is single shot.
> -	*/
> +	/*
> +	 * Find out if there is any input video
> +	 * if yes, it is single shot.
> +	 */
>  	if (pipe->input_num == 0) {
>  		pipe->state = VPFE_PIPELINE_STREAM_CONTINUOUS;
>  		ret = vpfe_update_current_ext_subdev(video);
> @@ -529,9 +530,10 @@ static int vpfe_release(struct file *file)
>  	if (fh->io_allowed) {
>  		if (video->started) {
>  			vpfe_stop_capture(video);
> -			/* mark pipe state as stopped in vpfe_release(),
> -			   as app might call streamon() after streamoff()
> -			   in which case driver has to start streaming.
> +			/*
> +			 * mark pipe state as stopped in vpfe_release(),
> +			 * as app might call streamon() after streamoff()
> +			 * in which case driver has to start streaming.
>  			*/
>  			video->pipe.state = VPFE_PIPELINE_STREAM_STOPPED;
>  			vb2_streamoff(&video->buffer_queue,
> @@ -672,8 +674,10 @@ static int vpfe_enum_fmt(struct file *file, void  *priv,
>  
>  	v4l2_dbg(1, debug, &vpfe_dev->v4l2_dev, "vpfe_enum_fmt\n");
>  
> -	/* since already subdev pad format is set,
> -	only one pixel format is available */
> +	/*
> +	 * since already subdev pad format is set,
> +	 * only one pixel format is available
> +	 */
>  	if (fmt->index > 0) {
>  		v4l2_err(&vpfe_dev->v4l2_dev, "Invalid index\n");
>  		return -EINVAL;
> -- 
> 2.1.4
> 
> -- 
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1455448327-4572-1-git-send-email-thaissa.falbo%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
> 


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [Outreachy kernel] [PATCHi v2] staging:media:davinci_vpfe: Fixed block comments according to kernel coding style
  2016-02-14 16:20 ` [Outreachy kernel] " Julia Lawall
@ 2016-02-14 23:21   ` Thaissa Falbo
  2016-02-15  0:33     ` Greg KH
  0 siblings, 1 reply; 4+ messages in thread
From: Thaissa Falbo @ 2016-02-14 23:21 UTC (permalink / raw)
  To: Julia Lawall; +Cc: Thaissa Falbo, outreachy-kernel



On Sun, 14 Feb 2016, Julia Lawall wrote:

> On Sun, 14 Feb 2016, Thaissa Falbo wrote:
>
> > In v2:
> > Lined up the *s, according to Julia's instructions
> >
> > In v1:
> > Fixed block comments by following the checkpatch warnings
>
> The above information is supposed to go below the ---.  Actually, this
> historical information is not interesting once the patch is applied,
> because only the most recent version is applied.  And the text that is
> below the --- and is not part of the patch disappears when the patch is
> applied.
>
> julia
>

Should I send a v3 for that? Or should I just try resend the v2 correctly?

Thaissa

> > WARNING: Block comments use * on subsequent lines
> > WARNING: Block comments use a trailing */ on separate line
> >
> >
> > Signed-off-by: Thaissa Falbo <thaissa.falbo@gmail.com>
> > ---
> >  .../staging/media/davinci_vpfe/davinci_vpfe_user.h   |  4 ++--
> >  drivers/staging/media/davinci_vpfe/dm365_ipipe_hw.c  | 12 ++++++++----
> >  drivers/staging/media/davinci_vpfe/dm365_ipipe_hw.h  |  7 ++++---
> >  drivers/staging/media/davinci_vpfe/vpfe_mc_capture.c |  6 ++++--
> >  drivers/staging/media/davinci_vpfe/vpfe_video.c      | 20 ++++++++++++--------
> >  5 files changed, 30 insertions(+), 19 deletions(-)
> >
> > diff --git a/drivers/staging/media/davinci_vpfe/davinci_vpfe_user.h b/drivers/staging/media/davinci_vpfe/davinci_vpfe_user.h
> > index 7b7e7b2..0425a1b 100644
> > --- a/drivers/staging/media/davinci_vpfe/davinci_vpfe_user.h
> > +++ b/drivers/staging/media/davinci_vpfe/davinci_vpfe_user.h
> > @@ -538,8 +538,8 @@ struct vpfe_isif_raw_config {
> >  };
> >
> >  /**********************************************************************
> > -      IPIPE API Structures
> > -**********************************************************************/
> > + * IPIPE API Structures
> > + **********************************************************************/
> >
> >  /* IPIPE module configurations */
> >
> > diff --git a/drivers/staging/media/davinci_vpfe/dm365_ipipe_hw.c b/drivers/staging/media/davinci_vpfe/dm365_ipipe_hw.c
> > index b1d5e23..0792fbd 100644
> > --- a/drivers/staging/media/davinci_vpfe/dm365_ipipe_hw.c
> > +++ b/drivers/staging/media/davinci_vpfe/dm365_ipipe_hw.c
> > @@ -682,8 +682,10 @@ ipipe_set_rgb2rgb_regs(void __iomem *base_addr, unsigned int id,
> >  	ipipe_clock_enable(base_addr);
> >
> >  	if (id == IPIPE_RGB2RGB_2) {
> > -		/* For second RGB module, gain integer is 3 bits instead
> > -		of 4, offset has 11 bits insread of 13 */
> > +		/*
> > +		 * For second RGB module, gain integer is 3 bits instead
> > +		 * of 4, offset has 11 bits insread of 13
> > +		 */
> >  		offset = RGB2_MUL_BASE;
> >  		integ_mask = 0x7;
> >  		offset_mask = RGB2RGB_2_OFST_MASK;
> > @@ -792,8 +794,10 @@ ipipe_set_3d_lut_regs(void __iomem *base_addr, void __iomem *isp5_base_addr,
> >  	/* valied table */
> >  	tbl = lut_3d->table;
> >  	for (i = 0; i < VPFE_IPIPE_MAX_SIZE_3D_LUT; i++) {
> > -		/* Each entry has 0-9 (B), 10-19 (G) and
> > -		20-29 R values */
> > +		/*
> > +		 * Each entry has 0-9 (B), 10-19 (G) and
> > +		 * 20-29 R values
> > +		 */
> >  		val = tbl[i].b & D3_LUT_ENTRY_MASK;
> >  		val |= (tbl[i].g & D3_LUT_ENTRY_MASK) <<
> >  			 D3_LUT_ENTRY_G_SHIFT;
> > diff --git a/drivers/staging/media/davinci_vpfe/dm365_ipipe_hw.h b/drivers/staging/media/davinci_vpfe/dm365_ipipe_hw.h
> > index 2bf2f7a..7ee1572 100644
> > --- a/drivers/staging/media/davinci_vpfe/dm365_ipipe_hw.h
> > +++ b/drivers/staging/media/davinci_vpfe/dm365_ipipe_hw.h
> > @@ -278,9 +278,10 @@
> >  /* Resizer Rescale Parameters */
> >  #define RSZ_EN_A		0x58
> >  #define RSZ_EN_B		0xe8
> > -/* offset of the registers to be added with base register of
> > -   either RSZ0 or RSZ1
> > -*/
> > +/*
> > + * offset of the registers to be added with base register of
> > + * either RSZ0 or RSZ1
> > + */
> >  #define RSZ_MODE		0x4
> >  #define RSZ_420			0x8
> >  #define RSZ_I_VPS		0xc
> > diff --git a/drivers/staging/media/davinci_vpfe/vpfe_mc_capture.c b/drivers/staging/media/davinci_vpfe/vpfe_mc_capture.c
> > index ec46f36..bf077f8 100644
> > --- a/drivers/staging/media/davinci_vpfe/vpfe_mc_capture.c
> > +++ b/drivers/staging/media/davinci_vpfe/vpfe_mc_capture.c
> > @@ -442,8 +442,10 @@ static int vpfe_register_entities(struct vpfe_device *vpfe_dev)
> >
> >  	/* create links now, starting with external(i2c) entities */
> >  	for (i = 0; i < vpfe_dev->num_ext_subdevs; i++)
> > -		/* if entity has no pads (ex: amplifier),
> > -		   cant establish link */
> > +		/*
> > +		 * if entity has no pads (ex: amplifier),
> > +		 * cant establish link
> > +		 */
> >  		if (vpfe_dev->sd[i]->entity.num_pads) {
> >  			ret = media_create_pad_link(&vpfe_dev->sd[i]->entity,
> >  				0, &vpfe_dev->vpfe_isif.subdev.entity,
> > diff --git a/drivers/staging/media/davinci_vpfe/vpfe_video.c b/drivers/staging/media/davinci_vpfe/vpfe_video.c
> > index 3ec7e65..e0658bc 100644
> > --- a/drivers/staging/media/davinci_vpfe/vpfe_video.c
> > +++ b/drivers/staging/media/davinci_vpfe/vpfe_video.c
> > @@ -178,9 +178,10 @@ static int vpfe_update_pipe_state(struct vpfe_video_device *video)
> >  	if (ret)
> >  		return ret;
> >
> > -	/* Find out if there is any input video
> > -	  if yes, it is single shot.
> > -	*/
> > +	/*
> > +	 * Find out if there is any input video
> > +	 * if yes, it is single shot.
> > +	 */
> >  	if (pipe->input_num == 0) {
> >  		pipe->state = VPFE_PIPELINE_STREAM_CONTINUOUS;
> >  		ret = vpfe_update_current_ext_subdev(video);
> > @@ -529,9 +530,10 @@ static int vpfe_release(struct file *file)
> >  	if (fh->io_allowed) {
> >  		if (video->started) {
> >  			vpfe_stop_capture(video);
> > -			/* mark pipe state as stopped in vpfe_release(),
> > -			   as app might call streamon() after streamoff()
> > -			   in which case driver has to start streaming.
> > +			/*
> > +			 * mark pipe state as stopped in vpfe_release(),
> > +			 * as app might call streamon() after streamoff()
> > +			 * in which case driver has to start streaming.
> >  			*/
> >  			video->pipe.state = VPFE_PIPELINE_STREAM_STOPPED;
> >  			vb2_streamoff(&video->buffer_queue,
> > @@ -672,8 +674,10 @@ static int vpfe_enum_fmt(struct file *file, void  *priv,
> >
> >  	v4l2_dbg(1, debug, &vpfe_dev->v4l2_dev, "vpfe_enum_fmt\n");
> >
> > -	/* since already subdev pad format is set,
> > -	only one pixel format is available */
> > +	/*
> > +	 * since already subdev pad format is set,
> > +	 * only one pixel format is available
> > +	 */
> >  	if (fmt->index > 0) {
> >  		v4l2_err(&vpfe_dev->v4l2_dev, "Invalid index\n");
> >  		return -EINVAL;
> > --
> > 2.1.4
> >
> > --
> > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> > To post to this group, send email to outreachy-kernel@googlegroups.com.
> > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1455448327-4572-1-git-send-email-thaissa.falbo%40gmail.com.
> > For more options, visit https://groups.google.com/d/optout.
> >
>


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [Outreachy kernel] [PATCHi v2] staging:media:davinci_vpfe: Fixed block comments according to kernel coding style
  2016-02-14 23:21   ` Thaissa Falbo
@ 2016-02-15  0:33     ` Greg KH
  0 siblings, 0 replies; 4+ messages in thread
From: Greg KH @ 2016-02-15  0:33 UTC (permalink / raw)
  To: Thaissa Falbo; +Cc: Julia Lawall, outreachy-kernel

On Sun, Feb 14, 2016 at 09:21:51PM -0200, Thaissa Falbo wrote:
> 
> 
> On Sun, 14 Feb 2016, Julia Lawall wrote:
> 
> > On Sun, 14 Feb 2016, Thaissa Falbo wrote:
> >
> > > In v2:
> > > Lined up the *s, according to Julia's instructions
> > >
> > > In v1:
> > > Fixed block comments by following the checkpatch warnings
> >
> > The above information is supposed to go below the ---.  Actually, this
> > historical information is not interesting once the patch is applied,
> > because only the most recent version is applied.  And the text that is
> > below the --- and is not part of the patch disappears when the patch is
> > applied.
> >
> > julia
> >
> 
> Should I send a v3 for that? Or should I just try resend the v2 correctly?

Please send a v3.

thanks,

greg k-h


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2016-02-15  0:33 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-02-14 11:12 [PATCHi v2] staging:media:davinci_vpfe: Fixed block comments according to kernel coding style Thaissa Falbo
2016-02-14 16:20 ` [Outreachy kernel] " Julia Lawall
2016-02-14 23:21   ` Thaissa Falbo
2016-02-15  0:33     ` Greg KH

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.