Re: [MPTCP] [PATCH 2/2] Remove unused variable, causes compile warning

Re: [MPTCP] [PATCH 2/2] Remove unused variable, causes compile warning

[Mat Martineau]

[-- Attachment #1: Type: text/plain, Size: 861 bytes --]

On Wed, 31 Jul 2019, Peter Krystad wrote:

> squashto: Add handling of incoming MP_JOIN requests
>
> Signed-off-by: Peter Krystad <peter.krystad(a)linux.intel.com>
> ---
> net/mptcp/token.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/net/mptcp/token.c b/net/mptcp/token.c
> index 2324a477d513..d5ae77446590 100644
> --- a/net/mptcp/token.c
> +++ b/net/mptcp/token.c
> @@ -77,7 +77,6 @@ static void new_req_token(struct request_sock *req,
> static void new_req_join(struct request_sock *req, struct sock *sk,
> 			 const struct sk_buff *skb)
> {
> -	const struct inet_request_sock *ireq = inet_rsk(req);
> 	struct subflow_request_sock *subflow_req = subflow_rsk(req);
> 	struct mptcp_sock *msk = mptcp_sk(sk);
> 	u8 hmac[MPTCPOPT_HMAC_LEN];
> -- 
> 2.17.2
>

Both patches look good to me, thanks!

--
Mat Martineau
Intel

Re: [MPTCP] [PATCH 2/2] Remove unused variable, causes compile warning

[Matthieu Baerts]

[-- Attachment #1: Type: text/plain, Size: 1565 bytes --]

Hi Peter, Mat,

On 01/08/2019 18:04, Mat Martineau wrote:
> On Wed, 31 Jul 2019, Peter Krystad wrote:
> 
>> squashto: Add handling of incoming MP_JOIN requests

Thank you for the patch and the review!

Now squashed in the two mentioned commits.

c8f8ec21b850: first commit, "squashed"
80abfb72cd32: second commit, "squashed"
846ea3a5258c..1f86b8812c88: results

Regards,
Matt

>>
>> Signed-off-by: Peter Krystad <peter.krystad(a)linux.intel.com>
>> ---
>> net/mptcp/token.c | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/net/mptcp/token.c b/net/mptcp/token.c
>> index 2324a477d513..d5ae77446590 100644
>> --- a/net/mptcp/token.c
>> +++ b/net/mptcp/token.c
>> @@ -77,7 +77,6 @@ static void new_req_token(struct request_sock *req,
>> static void new_req_join(struct request_sock *req, struct sock *sk,
>>              const struct sk_buff *skb)
>> {
>> -    const struct inet_request_sock *ireq = inet_rsk(req);
>>     struct subflow_request_sock *subflow_req = subflow_rsk(req);
>>     struct mptcp_sock *msk = mptcp_sk(sk);
>>     u8 hmac[MPTCPOPT_HMAC_LEN];
>> -- 
>> 2.17.2
>>
> 
> Both patches look good to me, thanks!
> 
> -- 
> Mat Martineau
> Intel
> _______________________________________________
> mptcp mailing list
> mptcp(a)lists.01.org
> https://lists.01.org/mailman/listinfo/mptcp

-- 
Matthieu Baerts | R&D Engineer
matthieu.baerts(a)tessares.net
Tessares SA | Hybrid Access Solutions
www.tessares.net
1 Avenue Jean Monnet, 1348 Louvain-la-Neuve, Belgium

Re: [MPTCP] [PATCH 2/2] Remove unused variable, causes compile warning

[Matthieu Baerts]

[-- Attachment #1: Type: text/plain, Size: 1493 bytes --]

Hi Peter, Mat,

Sorry I was busy with other activities. I will merge the different
pending patches that have been accepted tomorrow before the meeting.

Cheers,
Matt

On 01/08/2019 18:04, Mat Martineau wrote:
> On Wed, 31 Jul 2019, Peter Krystad wrote:
> 
>> squashto: Add handling of incoming MP_JOIN requests
>>
>> Signed-off-by: Peter Krystad <peter.krystad(a)linux.intel.com>
>> ---
>> net/mptcp/token.c | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/net/mptcp/token.c b/net/mptcp/token.c
>> index 2324a477d513..d5ae77446590 100644
>> --- a/net/mptcp/token.c
>> +++ b/net/mptcp/token.c
>> @@ -77,7 +77,6 @@ static void new_req_token(struct request_sock *req,
>> static void new_req_join(struct request_sock *req, struct sock *sk,
>>              const struct sk_buff *skb)
>> {
>> -    const struct inet_request_sock *ireq = inet_rsk(req);
>>     struct subflow_request_sock *subflow_req = subflow_rsk(req);
>>     struct mptcp_sock *msk = mptcp_sk(sk);
>>     u8 hmac[MPTCPOPT_HMAC_LEN];
>> -- 
>> 2.17.2
>>
> 
> Both patches look good to me, thanks!
> 
> -- 
> Mat Martineau
> Intel
> _______________________________________________
> mptcp mailing list
> mptcp(a)lists.01.org
> https://lists.01.org/mailman/listinfo/mptcp

-- 
Matthieu Baerts | R&D Engineer
matthieu.baerts(a)tessares.net
Tessares SA | Hybrid Access Solutions
www.tessares.net
1 Avenue Jean Monnet, 1348 Louvain-la-Neuve, Belgium

[MPTCP] [PATCH 2/2] Remove unused variable, causes compile warning

[Peter Krystad]

[-- Attachment #1: Type: text/plain, Size: 714 bytes --]

squashto: Add handling of incoming MP_JOIN requests

Signed-off-by: Peter Krystad <peter.krystad(a)linux.intel.com>
---
 net/mptcp/token.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/net/mptcp/token.c b/net/mptcp/token.c
index 2324a477d513..d5ae77446590 100644
--- a/net/mptcp/token.c
+++ b/net/mptcp/token.c
@@ -77,7 +77,6 @@ static void new_req_token(struct request_sock *req,
 static void new_req_join(struct request_sock *req, struct sock *sk,
 			 const struct sk_buff *skb)
 {
-	const struct inet_request_sock *ireq = inet_rsk(req);
 	struct subflow_request_sock *subflow_req = subflow_rsk(req);
 	struct mptcp_sock *msk = mptcp_sk(sk);
 	u8 hmac[MPTCPOPT_HMAC_LEN];
-- 
2.17.2