[MPTCP] Re: [PATCH 1/3] MAINTAINERS: Add MPTCP maintainer

[MPTCP] Re: [PATCH 1/3] MAINTAINERS: Add MPTCP maintainer

[Mat Martineau]

[-- Attachment #1: Type: text/plain, Size: 2709 bytes --]


On Fri, 6 Dec 2019, Matthieu Baerts wrote:

> Hi Mat,
>
> On 06/12/2019 00:05, Mat Martineau wrote:
>> When we discussed maintainership in an earlier meeting
>> (https://lists.01.org/hyperkitty/list/mptcp(a)lists.01.org/thread/HCII2622GWZCOMQCBOMQBJKZI247YIH5/)
>> there was a loose consensus that it would be best to have multiple
>> maintainers. I nominate Matthieu Baerts <matthieu.baerts(a)tessares.net>
>> as a co-maintainer, what do you think?
>> 
>> squashto: mptcp: Add MPTCP to skb extensions
>> Signed-off-by: Mat Martineau <mathew.j.martineau(a)linux.intel.com>
>> ---
>>   MAINTAINERS | 6 ++++++
>>   1 file changed, 6 insertions(+)
>> 
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index 8608724835dd..0576b17abd44 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -11538,6 +11538,12 @@ F:	net/ipv6/calipso.c
>>   F:	net/netfilter/xt_CONNSECMARK.c
>>   F:	net/netfilter/xt_SECMARK.c
>>   +NETWORKING [MPTCP]
>> +M:	Mat Martineau <mathew.j.martineau(a)linux.intel.com>
>> +L:	netdev(a)vger.kernel.org
>
> I see that some have two mailing-lists with a note.
>
>  L:	mptcp(a)lists.01.org (moderated for non-subscribers)

I noticed this too. One major issue is that the lists.01.org admins asked 
me to work around their moderation bug by rejecting non-subscribed 
senders.

(There's a bug in the specific version of mailman that prevents list 
owners from approving or rejecting held messages, possibly due to corrupt 
message format in spam. Every time messages are held I have to get a 
sysadmin to log in and fix it)

Given that, I think it's better to monitor netdev for updates. Another 
alternative is to open up the list for non-member senders but given 
current patterns that would forward 1-2 spam messages per week. I'm 
flexible here, I have so far leaned toward keeping spam out.

>
> Can we not do the same?
>
> Should we not also add these ones?
>
>  Q:	https://patchwork.ozlabs.org/project/mptcp/list/
>  W:	https://github.com/multipath-tcp/mptcp_net-next/wiki
>  T:	git git://github.com/multipath-tcp/mptcp_net-next.git
>  B:	https://github.com/multipath-tcp/mptcp_net-next/issues
>
> (not sure about the last one)

We haven't discussed what maintenance of MPTCP will look like after code 
is merged, so for now my assumption is that maintenance fixes would look 
more like TCP and TLS as far as git trees and patch management are 
concerned. I'm

The bug tracker would be a helpful pointer so people aren't trying to look 
up MPTCP bugs in the netdev archives.

>
> Also it is not linked to this but do you think at some points we should add 
> some Documentations?

Definitely!

--
Mat Martineau
Intel

[MPTCP] Re: [PATCH 1/3] MAINTAINERS: Add MPTCP maintainer

[Matthieu Baerts]

[-- Attachment #1: Type: text/plain, Size: 3516 bytes --]

Hi Mat,

Thank you for your reply!

On 06/12/2019 22:38, Mat Martineau wrote:
> 
> On Fri, 6 Dec 2019, Matthieu Baerts wrote:
> 
>> Hi Mat,
>>
>> On 06/12/2019 00:05, Mat Martineau wrote:
>>> When we discussed maintainership in an earlier meeting
>>> (https://lists.01.org/hyperkitty/list/mptcp(a)lists.01.org/thread/HCII2622GWZCOMQCBOMQBJKZI247YIH5/) 
>>>
>>> there was a loose consensus that it would be best to have multiple
>>> maintainers. I nominate Matthieu Baerts <matthieu.baerts(a)tessares.net>
>>> as a co-maintainer, what do you think?
>>>
>>> squashto: mptcp: Add MPTCP to skb extensions
>>> Signed-off-by: Mat Martineau <mathew.j.martineau(a)linux.intel.com>
>>> ---
>>>   MAINTAINERS | 6 ++++++
>>>   1 file changed, 6 insertions(+)
>>>
>>> diff --git a/MAINTAINERS b/MAINTAINERS
>>> index 8608724835dd..0576b17abd44 100644
>>> --- a/MAINTAINERS
>>> +++ b/MAINTAINERS
>>> @@ -11538,6 +11538,12 @@ F:    net/ipv6/calipso.c
>>>   F:    net/netfilter/xt_CONNSECMARK.c
>>>   F:    net/netfilter/xt_SECMARK.c
>>>   +NETWORKING [MPTCP]
>>> +M:    Mat Martineau <mathew.j.martineau(a)linux.intel.com>
>>> +L:    netdev(a)vger.kernel.org
>>
>> I see that some have two mailing-lists with a note.
>>
>>  L:    mptcp(a)lists.01.org (moderated for non-subscribers)
> 
> I noticed this too. One major issue is that the lists.01.org admins 
> asked me to work around their moderation bug by rejecting non-subscribed 
> senders.
> 
> (There's a bug in the specific version of mailman that prevents list 
> owners from approving or rejecting held messages, possibly due to 
> corrupt message format in spam. Every time messages are held I have to 
> get a sysadmin to log in and fix it)
> 
> Given that, I think it's better to monitor netdev for updates. Another 
> alternative is to open up the list for non-member senders but given 
> current patterns that would forward 1-2 spam messages per week. I'm 
> flexible here, I have so far leaned toward keeping spam out.

If they go directly to my spam folder like the ones from netdev, that's 
fine for me.
Or can we reject emails from non-subscribers?

>>
>> Can we not do the same?
>>
>> Should we not also add these ones?
>>
>>  Q:    https://patchwork.ozlabs.org/project/mptcp/list/
>>  W:    https://github.com/multipath-tcp/mptcp_net-next/wiki
>>  T:    git git://github.com/multipath-tcp/mptcp_net-next.git
>>  B:    https://github.com/multipath-tcp/mptcp_net-next/issues
>>
>> (not sure about the last one)
> 
> We haven't discussed what maintenance of MPTCP will look like after code 
> is merged, so for now my assumption is that maintenance fixes would look 
> more like TCP and TLS as far as git trees and patch management are 
> concerned. I'm

That's true. But for the moment, there are still new features to 
develop. So I guess it makes sense to keep Patchwork and the git repo 
for a while. We can remove it later if it no longer makes sense.

> The bug tracker would be a helpful pointer so people aren't trying to 
> look up MPTCP bugs in the netdev archives.

I think that too.

>>
>> Also it is not linked to this but do you think at some points we 
>> should add some Documentations?
> 
> Definitely!

But not urgent :)

Cheers,
Matt
-- 
Matthieu Baerts | R&D Engineer
matthieu.baerts(a)tessares.net
Tessares SA | Hybrid Access Solutions
www.tessares.net
1 Avenue Jean Monnet, 1348 Louvain-la-Neuve, Belgium

[MPTCP] Re: [PATCH 1/3] MAINTAINERS: Add MPTCP maintainer

[Matthieu Baerts]

[-- Attachment #1: Type: text/plain, Size: 1728 bytes --]

Hi Mat,

On 06/12/2019 00:05, Mat Martineau wrote:
> When we discussed maintainership in an earlier meeting
> (https://lists.01.org/hyperkitty/list/mptcp(a)lists.01.org/thread/HCII2622GWZCOMQCBOMQBJKZI247YIH5/)
> there was a loose consensus that it would be best to have multiple
> maintainers. I nominate Matthieu Baerts <matthieu.baerts(a)tessares.net>
> as a co-maintainer, what do you think?
> 
> squashto: mptcp: Add MPTCP to skb extensions
> Signed-off-by: Mat Martineau <mathew.j.martineau(a)linux.intel.com>
> ---
>   MAINTAINERS | 6 ++++++
>   1 file changed, 6 insertions(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 8608724835dd..0576b17abd44 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -11538,6 +11538,12 @@ F:	net/ipv6/calipso.c
>   F:	net/netfilter/xt_CONNSECMARK.c
>   F:	net/netfilter/xt_SECMARK.c
>   
> +NETWORKING [MPTCP]
> +M:	Mat Martineau <mathew.j.martineau(a)linux.intel.com>
> +L:	netdev(a)vger.kernel.org

I see that some have two mailing-lists with a note.

   L:	mptcp(a)lists.01.org (moderated for non-subscribers)

Can we not do the same?

Should we not also add these ones?

   Q:	https://patchwork.ozlabs.org/project/mptcp/list/
   W:	https://github.com/multipath-tcp/mptcp_net-next/wiki
   T:	git git://github.com/multipath-tcp/mptcp_net-next.git
   B:	https://github.com/multipath-tcp/mptcp_net-next/issues

(not sure about the last one)

Also it is not linked to this but do you think at some points we should 
add some Documentations?

Cheers,
Matt
-- 
Matthieu Baerts | R&D Engineer
matthieu.baerts(a)tessares.net
Tessares SA | Hybrid Access Solutions
www.tessares.net
1 Avenue Jean Monnet, 1348 Louvain-la-Neuve, Belgium

[MPTCP] Re: [PATCH 1/3] MAINTAINERS: Add MPTCP maintainer

[Mat Martineau]

[-- Attachment #1: Type: text/plain, Size: 989 bytes --]

On Fri, 6 Dec 2019, Davide Caratti wrote:

> On Thu, 2019-12-05 at 15:05 -0800, Mat Martineau wrote:
>> When we discussed maintainership in an earlier meeting
>> (https://lists.01.org/hyperkitty/list/mptcp(a)lists.01.org/thread/HCII2622GWZCOMQCBOMQBJKZI247YIH5/)
>> there was a loose consensus that it would be best to have multiple
>> maintainers. I nominate Matthieu Baerts <matthieu.baerts(a)tessares.net>
>> as a co-maintainer, what do you think?
>>
>> squashto: mptcp: Add MPTCP to skb extensions
>> Signed-off-by: Mat Martineau <mathew.j.martineau(a)linux.intel.com>
>> ---
>>  MAINTAINERS | 6 ++++++
>>  1 file changed, 6 insertions(+)
>
> hello Mat,
>
> I think that the "maintainership" also applies to the UAPI bits, so
> probably we should add
>
> include/uapi/linux/mptcp.h
>
> correct?
>

Thanks for pointing this out, I'll send another patch for uapi. I missed 
that one because I only looked at the "part 1 & 2" commits.

--
Mat Martineau
Intel

[MPTCP] Re: [PATCH 1/3] MAINTAINERS: Add MPTCP maintainer

[Matthieu Baerts]

[-- Attachment #1: Type: text/plain, Size: 654 bytes --]

Hi Mat,

On 06/12/2019 00:05, Mat Martineau wrote:
> When we discussed maintainership in an earlier meeting
> (https://lists.01.org/hyperkitty/list/mptcp(a)lists.01.org/thread/HCII2622GWZCOMQCBOMQBJKZI247YIH5/)
> there was a loose consensus that it would be best to have multiple
> maintainers. I nominate Matthieu Baerts <matthieu.baerts(a)tessares.net>
> as a co-maintainer, what do you think?

I would be happy to! Thank you for looking at this!

Cheers,
Matt
-- 
Matthieu Baerts | R&D Engineer
matthieu.baerts(a)tessares.net
Tessares SA | Hybrid Access Solutions
www.tessares.net
1 Avenue Jean Monnet, 1348 Louvain-la-Neuve, Belgium

[MPTCP] Re: [PATCH 1/3] MAINTAINERS: Add MPTCP maintainer

[Davide Caratti]

[-- Attachment #1: Type: text/plain, Size: 777 bytes --]

On Thu, 2019-12-05 at 15:05 -0800, Mat Martineau wrote:
> When we discussed maintainership in an earlier meeting
> (https://lists.01.org/hyperkitty/list/mptcp(a)lists.01.org/thread/HCII2622GWZCOMQCBOMQBJKZI247YIH5/)
> there was a loose consensus that it would be best to have multiple
> maintainers. I nominate Matthieu Baerts <matthieu.baerts(a)tessares.net>
> as a co-maintainer, what do you think?
> 
> squashto: mptcp: Add MPTCP to skb extensions
> Signed-off-by: Mat Martineau <mathew.j.martineau(a)linux.intel.com>
> ---
>  MAINTAINERS | 6 ++++++
>  1 file changed, 6 insertions(+)

hello Mat,

I think that the "maintainership" also applies to the UAPI bits, so
probably we should add

include/uapi/linux/mptcp.h

correct?

thanks!
-- 
davide