* [MPTCP] Re: [PATCH 00/11] Multipath TCP part 1: Prerequisites
@ 2019-12-13 21:54 Mat Martineau
0 siblings, 0 replies; 6+ messages in thread
From: Mat Martineau @ 2019-12-13 21:54 UTC (permalink / raw)
To: mptcp
[-- Attachment #1: Type: text/plain, Size: 1753 bytes --]
On Fri, 13 Dec 2019, Matthieu Baerts wrote:
> Hi Mat,
>
> On 13/12/2019 21:53, Mat Martineau wrote:
>>
>> On Fri, 13 Dec 2019, Matthieu Baerts wrote:
>>
>>> The MPTCP upstreaming community has been collaborating on an
>>> upstreamable MPTCP implementation that complies with RFC 8684. A minimal
>>> set of features to comply with the specification involves a sizeable set
>>> of code changes, so David requested that we split this work in to
>>> multiple, smaller patch sets to build up MPTCP infrastructure.
>>>
>>> The minimal MPTCP feature set we are proposing for the v5.6 timeframe is
>>> split in to these parts for review:
>>
>> For sending to netdev, I plan to tag as [PATCH net-next x/y] and replace
>> the above sentence with "The minimal MPTCP feature set we are proposing for
>> review in the v5.6 timeframe begins with these parts:"
>
> Good idea to add net-next!
>
> For the sentence, I was suggesting this on another thread but better to
> continue here:
>
> Yes, sounds good but what about keeping this sentence and add this at the end
> instead of part 3:
>
> More commits are in preparation to add multiple subflow support, path
> management, active backup support and more but this will come later when
> these 3 previous parts are reviewed and applied.
>
> I hope it is clear that we don't have to wait for any part 4
Ok, I'll add something to that effect.
>
> And also:
>
> The part 2 is coming later today and part 3 over the next week.
>
I was trying to not get too specific about the timing for two reasons: in
case something unexpected arises, and so that people go ahead and review
earlier parts without worrying about what comes after.
--
Mat Martineau
Intel
^ permalink raw reply [flat|nested] 6+ messages in thread
* [MPTCP] Re: [PATCH 00/11] Multipath TCP part 1: Prerequisites
@ 2019-12-13 21:58 Matthieu Baerts
0 siblings, 0 replies; 6+ messages in thread
From: Matthieu Baerts @ 2019-12-13 21:58 UTC (permalink / raw)
To: mptcp
[-- Attachment #1: Type: text/plain, Size: 2211 bytes --]
Hi Mat,
On 13/12/2019 22:54, Mat Martineau wrote:
> On Fri, 13 Dec 2019, Matthieu Baerts wrote:
>
>> Hi Mat,
>>
>> On 13/12/2019 21:53, Mat Martineau wrote:
>>>
>>> On Fri, 13 Dec 2019, Matthieu Baerts wrote:
>>>
>>>> The MPTCP upstreaming community has been collaborating on an
>>>> upstreamable MPTCP implementation that complies with RFC 8684. A
>>>> minimal
>>>> set of features to comply with the specification involves a sizeable
>>>> set
>>>> of code changes, so David requested that we split this work in to
>>>> multiple, smaller patch sets to build up MPTCP infrastructure.
>>>>
>>>> The minimal MPTCP feature set we are proposing for the v5.6
>>>> timeframe is
>>>> split in to these parts for review:
>>>
>>> For sending to netdev, I plan to tag as [PATCH net-next x/y] and
>>> replace the above sentence with "The minimal MPTCP feature set we are
>>> proposing for review in the v5.6 timeframe begins with these parts:"
>>
>> Good idea to add net-next!
>>
>> For the sentence, I was suggesting this on another thread but better
>> to continue here:
>>
>> Yes, sounds good but what about keeping this sentence and add this at
>> the end instead of part 3:
>>
>> More commits are in preparation to add multiple subflow support, path
>> management, active backup support and more but this will come later
>> when these 3 previous parts are reviewed and applied.
>>
>> I hope it is clear that we don't have to wait for any part 4
>
> Ok, I'll add something to that effect.
>
>>
>> And also:
>>
>> The part 2 is coming later today and part 3 over the next week.
>>
>
> I was trying to not get too specific about the timing for two reasons:
> in case something unexpected arises, and so that people go ahead and
> review earlier parts without worrying about what comes after.
Good point but I think it is still good to say that they are coming soon
I think :)
Especially for part 2 because it is hard to judge part 1 without it :)
Cheers,
Matt
--
Matthieu Baerts | R&D Engineer
matthieu.baerts(a)tessares.net
Tessares SA | Hybrid Access Solutions
www.tessares.net
1 Avenue Jean Monnet, 1348 Louvain-la-Neuve, Belgium
^ permalink raw reply [flat|nested] 6+ messages in thread
* [MPTCP] Re: [PATCH 00/11] Multipath TCP part 1: Prerequisites
@ 2019-12-13 21:39 Peter Krystad
0 siblings, 0 replies; 6+ messages in thread
From: Peter Krystad @ 2019-12-13 21:39 UTC (permalink / raw)
To: mptcp
[-- Attachment #1: Type: text/plain, Size: 2852 bytes --]
Other than my one comment on 8/11 these look good to go.
Peter.
On Fri, 2019-12-13 at 21:48 +0100, Matthieu Baerts wrote:
> The MPTCP upstreaming community has been collaborating on an
> upstreamable MPTCP implementation that complies with RFC 8684. A minimal
> set of features to comply with the specification involves a sizeable set
> of code changes, so David requested that we split this work in to
> multiple, smaller patch sets to build up MPTCP infrastructure.
>
> The minimal MPTCP feature set we are proposing for the v5.6 timeframe is
> split in to these parts for review:
>
> Part 1 (this patch set): MPTCP prerequisites. Introduce some MPTCP
> definitions, additional ULP and skb extension features, TCP option space
> checking, and a few exported symbols.
>
> Part 2: Single subflow implementation and self tests.
>
> Part 3: Switch from MPTCP v0 (RFC 6824) to MPTCP v1 (new RFC 8684,
> publication expected in the next few days).
>
> Clone/fetch:
> https://github.com/multipath-tcp/mptcp_net-next.git (tag: netdev-v1-part1)
>
> Browse:
> https://github.com/multipath-tcp/mptcp_net-next/tree/netdev-v1-part1
>
> Thank your for your review. You can find us at mptcp(a)lists.01.org and
> https://is.gd/mptcp_upstream
>
> Mat Martineau (9):
> net: Make sock protocol value checks more specific
> sock: Make sk_protocol a 16-bit value
> tcp: Define IPPROTO_MPTCP
> tcp: Add MPTCP option number
> tcp, ulp: Add clone operation to tcp_ulp_ops
> mptcp: Add MPTCP to skb extensions
> tcp: Prevent coalesce/collapse when skb has MPTCP extensions
> tcp: Export TCP functions and ops struct
> tcp: Check for filled TCP option space before SACK
>
> Paolo Abeni (2):
> tcp: clean ext on tx recycle
> skb: add helpers to allocate ext independently from sk_buff
>
> MAINTAINERS | 10 ++++++++
> include/linux/skbuff.h | 6 +++++
> include/net/mptcp.h | 43 +++++++++++++++++++++++++++++++++
> include/net/sock.h | 6 ++---
> include/net/tcp.h | 22 +++++++++++++++++
> include/trace/events/sock.h | 5 ++--
> include/uapi/linux/in.h | 2 ++
> net/ax25/af_ax25.c | 2 +-
> net/core/skbuff.c | 42 ++++++++++++++++++++++++++++++--
> net/decnet/af_decnet.c | 2 +-
> net/ipv4/inet_connection_sock.c | 2 ++
> net/ipv4/tcp.c | 6 ++---
> net/ipv4/tcp_input.c | 10 ++++++--
> net/ipv4/tcp_ipv4.c | 2 +-
> net/ipv4/tcp_output.c | 5 +++-
> net/ipv4/tcp_ulp.c | 12 +++++++++
> net/ipv6/tcp_ipv6.c | 6 ++---
> tools/include/uapi/linux/in.h | 2 ++
> 18 files changed, 166 insertions(+), 19 deletions(-)
> create mode 100644 include/net/mptcp.h
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [MPTCP] Re: [PATCH 00/11] Multipath TCP part 1: Prerequisites
@ 2019-12-13 21:38 Matthieu Baerts
0 siblings, 0 replies; 6+ messages in thread
From: Matthieu Baerts @ 2019-12-13 21:38 UTC (permalink / raw)
To: mptcp
[-- Attachment #1: Type: text/plain, Size: 422 bytes --]
Hi Mat
On 13/12/2019 21:48, Matthieu Baerts wrote:
[...]
> Thank your for your review. You can find us at mptcp(a)lists.01.org and
> https://is.gd/mptcp_upstream
I see I copy-pasted without checking: s/Thank your/Thank you/ ;-)
--
Matthieu Baerts | R&D Engineer
matthieu.baerts(a)tessares.net
Tessares SA | Hybrid Access Solutions
www.tessares.net
1 Avenue Jean Monnet, 1348 Louvain-la-Neuve, Belgium
^ permalink raw reply [flat|nested] 6+ messages in thread
* [MPTCP] Re: [PATCH 00/11] Multipath TCP part 1: Prerequisites
@ 2019-12-13 21:11 Matthieu Baerts
0 siblings, 0 replies; 6+ messages in thread
From: Matthieu Baerts @ 2019-12-13 21:11 UTC (permalink / raw)
To: mptcp
[-- Attachment #1: Type: text/plain, Size: 1573 bytes --]
Hi Mat,
On 13/12/2019 21:53, Mat Martineau wrote:
>
> On Fri, 13 Dec 2019, Matthieu Baerts wrote:
>
>> The MPTCP upstreaming community has been collaborating on an
>> upstreamable MPTCP implementation that complies with RFC 8684. A minimal
>> set of features to comply with the specification involves a sizeable set
>> of code changes, so David requested that we split this work in to
>> multiple, smaller patch sets to build up MPTCP infrastructure.
>>
>> The minimal MPTCP feature set we are proposing for the v5.6 timeframe is
>> split in to these parts for review:
>
> For sending to netdev, I plan to tag as [PATCH net-next x/y] and replace
> the above sentence with "The minimal MPTCP feature set we are proposing
> for review in the v5.6 timeframe begins with these parts:"
Good idea to add net-next!
For the sentence, I was suggesting this on another thread but better to
continue here:
Yes, sounds good but what about keeping this sentence and add this at
the end instead of part 3:
More commits are in preparation to add multiple subflow support, path
management, active backup support and more but this will come later when
these 3 previous parts are reviewed and applied.
I hope it is clear that we don't have to wait for any part 4
And also:
The part 2 is coming later today and part 3 over the next week.
Cheers,
Matt
--
Matthieu Baerts | R&D Engineer
matthieu.baerts(a)tessares.net
Tessares SA | Hybrid Access Solutions
www.tessares.net
1 Avenue Jean Monnet, 1348 Louvain-la-Neuve, Belgium
^ permalink raw reply [flat|nested] 6+ messages in thread
* [MPTCP] Re: [PATCH 00/11] Multipath TCP part 1: Prerequisites
@ 2019-12-13 20:53 Mat Martineau
0 siblings, 0 replies; 6+ messages in thread
From: Mat Martineau @ 2019-12-13 20:53 UTC (permalink / raw)
To: mptcp
[-- Attachment #1: Type: text/plain, Size: 2991 bytes --]
On Fri, 13 Dec 2019, Matthieu Baerts wrote:
> The MPTCP upstreaming community has been collaborating on an
> upstreamable MPTCP implementation that complies with RFC 8684. A minimal
> set of features to comply with the specification involves a sizeable set
> of code changes, so David requested that we split this work in to
> multiple, smaller patch sets to build up MPTCP infrastructure.
>
> The minimal MPTCP feature set we are proposing for the v5.6 timeframe is
> split in to these parts for review:
For sending to netdev, I plan to tag as [PATCH net-next x/y] and replace
the above sentence with "The minimal MPTCP feature set we are proposing
for review in the v5.6 timeframe begins with these parts:"
Mat
>
> Part 1 (this patch set): MPTCP prerequisites. Introduce some MPTCP
> definitions, additional ULP and skb extension features, TCP option space
> checking, and a few exported symbols.
>
> Part 2: Single subflow implementation and self tests.
>
> Part 3: Switch from MPTCP v0 (RFC 6824) to MPTCP v1 (new RFC 8684,
> publication expected in the next few days).
>
> Clone/fetch:
> https://github.com/multipath-tcp/mptcp_net-next.git (tag: netdev-v1-part1)
>
> Browse:
> https://github.com/multipath-tcp/mptcp_net-next/tree/netdev-v1-part1
>
> Thank your for your review. You can find us at mptcp(a)lists.01.org and
> https://is.gd/mptcp_upstream
>
> Mat Martineau (9):
> net: Make sock protocol value checks more specific
> sock: Make sk_protocol a 16-bit value
> tcp: Define IPPROTO_MPTCP
> tcp: Add MPTCP option number
> tcp, ulp: Add clone operation to tcp_ulp_ops
> mptcp: Add MPTCP to skb extensions
> tcp: Prevent coalesce/collapse when skb has MPTCP extensions
> tcp: Export TCP functions and ops struct
> tcp: Check for filled TCP option space before SACK
>
> Paolo Abeni (2):
> tcp: clean ext on tx recycle
> skb: add helpers to allocate ext independently from sk_buff
>
> MAINTAINERS | 10 ++++++++
> include/linux/skbuff.h | 6 +++++
> include/net/mptcp.h | 43 +++++++++++++++++++++++++++++++++
> include/net/sock.h | 6 ++---
> include/net/tcp.h | 22 +++++++++++++++++
> include/trace/events/sock.h | 5 ++--
> include/uapi/linux/in.h | 2 ++
> net/ax25/af_ax25.c | 2 +-
> net/core/skbuff.c | 42 ++++++++++++++++++++++++++++++--
> net/decnet/af_decnet.c | 2 +-
> net/ipv4/inet_connection_sock.c | 2 ++
> net/ipv4/tcp.c | 6 ++---
> net/ipv4/tcp_input.c | 10 ++++++--
> net/ipv4/tcp_ipv4.c | 2 +-
> net/ipv4/tcp_output.c | 5 +++-
> net/ipv4/tcp_ulp.c | 12 +++++++++
> net/ipv6/tcp_ipv6.c | 6 ++---
> tools/include/uapi/linux/in.h | 2 ++
> 18 files changed, 166 insertions(+), 19 deletions(-)
> create mode 100644 include/net/mptcp.h
>
> --
> 2.24.0
--
Mat Martineau
Intel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-12-13 21:58 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-13 21:54 [MPTCP] Re: [PATCH 00/11] Multipath TCP part 1: Prerequisites Mat Martineau
-- strict thread matches above, loose matches on Subject: below --
2019-12-13 21:58 Matthieu Baerts
2019-12-13 21:39 Peter Krystad
2019-12-13 21:38 Matthieu Baerts
2019-12-13 21:11 Matthieu Baerts
2019-12-13 20:53 Mat Martineau
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.