From: Mat Martineau <mathew.j.martineau at linux.intel.com>
To: mptcp at lists.01.org
Subject: [MPTCP] Re: [PATCH net] mptcp: sendmsg: reset iter on error
Date: Fri, 14 Aug 2020 12:48:17 -0700 [thread overview]
Message-ID: <alpine.OSX.2.23.453.2008141245480.20141@cakenne1-mobl1.amr.corp.intel.com> (raw)
In-Reply-To: 20200814135634.12996-1-fw@strlen.de
[-- Attachment #1: Type: text/plain, Size: 726 bytes --]
On Fri, 14 Aug 2020, Florian Westphal wrote:
> Once we've copied data from the iterator we need to revert in case we
> end up not sending any data.
>
> This bug doesn't trigger with normal 'poll' based tests, because
> we only feed a small chunk of data to kernel after poll indicated
> POLLOUT. With blocking IO and large writes this triggers. Receiver
> ends up with less data than it should get.
>
> Fixes: 72511aab95c94d ("mptcp: avoid blocking in tcp_sendpages")
> Signed-off-by: Florian Westphal <fw(a)strlen.de>
> ---
> net/mptcp/protocol.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
Reviewed-by: Mat Martineau <mathew.j.martineau(a)linux.intel.com>
--
Mat Martineau
Intel
WARNING: multiple messages have this Message-ID (diff)
From: Mat Martineau <mathew.j.martineau@linux.intel.com>
To: Florian Westphal <fw@strlen.de>
Cc: netdev@vger.kernel.org, matthieu.baerts@tessares.net, mptcp@lists.01.org
Subject: Re: [PATCH net] mptcp: sendmsg: reset iter on error
Date: Fri, 14 Aug 2020 12:48:17 -0700 (PDT) [thread overview]
Message-ID: <alpine.OSX.2.23.453.2008141245480.20141@cakenne1-mobl1.amr.corp.intel.com> (raw)
In-Reply-To: <20200814135634.12996-1-fw@strlen.de>
On Fri, 14 Aug 2020, Florian Westphal wrote:
> Once we've copied data from the iterator we need to revert in case we
> end up not sending any data.
>
> This bug doesn't trigger with normal 'poll' based tests, because
> we only feed a small chunk of data to kernel after poll indicated
> POLLOUT. With blocking IO and large writes this triggers. Receiver
> ends up with less data than it should get.
>
> Fixes: 72511aab95c94d ("mptcp: avoid blocking in tcp_sendpages")
> Signed-off-by: Florian Westphal <fw@strlen.de>
> ---
> net/mptcp/protocol.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
Reviewed-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
--
Mat Martineau
Intel
next reply other threads:[~2020-08-14 19:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-14 19:48 Mat Martineau [this message]
2020-08-14 19:48 ` [PATCH net] mptcp: sendmsg: reset iter on error Mat Martineau
-- strict thread matches above, loose matches on Subject: below --
2020-08-14 21:12 [MPTCP] " David Miller
2020-08-14 21:12 ` David Miller
2020-08-14 13:56 [MPTCP] " Florian Westphal
2020-08-14 13:56 ` Florian Westphal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.OSX.2.23.453.2008141245480.20141@cakenne1-mobl1.amr.corp.intel.com \
--to=unknown@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.