* [PATCH] e1000: fix sparse warning
@ 2011-02-23 18:12 Stephen Hemminger
2011-02-23 18:24 ` Brandeburg, Jesse
2011-02-24 0:03 ` Jeff Kirsher
0 siblings, 2 replies; 3+ messages in thread
From: Stephen Hemminger @ 2011-02-23 18:12 UTC (permalink / raw)
To: Jeff Kirsher, Jesse Brandeburg; +Cc: e1000-devel, netdev
Sparse complains because the e1000 driver is calling ioread on a pointer
not tagged as __iomem.
Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
--- a/drivers/net/e1000/e1000_osdep.h 2011-02-23 10:00:31.496097384 -0800
+++ b/drivers/net/e1000/e1000_osdep.h 2011-02-23 10:00:47.740287665 -0800
@@ -42,7 +42,8 @@
#define GBE_CONFIG_RAM_BASE \
((unsigned int)(CONFIG_RAM_BASE + GBE_CONFIG_OFFSET))
-#define GBE_CONFIG_BASE_VIRT phys_to_virt(GBE_CONFIG_RAM_BASE)
+#define GBE_CONFIG_BASE_VIRT \
+ ((void __iomem *)phys_to_virt(GBE_CONFIG_RAM_BASE))
#define GBE_CONFIG_FLASH_WRITE(base, offset, count, data) \
(iowrite16_rep(base + offset, data, count))
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] e1000: fix sparse warning
2011-02-23 18:12 [PATCH] e1000: fix sparse warning Stephen Hemminger
@ 2011-02-23 18:24 ` Brandeburg, Jesse
2011-02-24 0:03 ` Jeff Kirsher
1 sibling, 0 replies; 3+ messages in thread
From: Brandeburg, Jesse @ 2011-02-23 18:24 UTC (permalink / raw)
To: Stephen Hemminger
Cc: Kirsher, Jeffrey T, Jesse Brandeburg, e1000-devel, netdev
On Wed, 23 Feb 2011, Stephen Hemminger wrote:
> Sparse complains because the e1000 driver is calling ioread on a pointer
> not tagged as __iomem.
>
> Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Seems fine, thanks Stephen.
Reviewed-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] e1000: fix sparse warning
2011-02-23 18:12 [PATCH] e1000: fix sparse warning Stephen Hemminger
2011-02-23 18:24 ` Brandeburg, Jesse
@ 2011-02-24 0:03 ` Jeff Kirsher
1 sibling, 0 replies; 3+ messages in thread
From: Jeff Kirsher @ 2011-02-24 0:03 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: Jesse Brandeburg, e1000-devel, netdev
[-- Attachment #1: Type: text/plain, Size: 305 bytes --]
On Wed, 2011-02-23 at 10:12 -0800, Stephen Hemminger wrote:
> Sparse complains because the e1000 driver is calling ioread on a
> pointer
> not tagged as __iomem.
>
> Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Thanks Stephen! I have added this patch to my queue of e1000 patches.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 490 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-02-24 0:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-02-23 18:12 [PATCH] e1000: fix sparse warning Stephen Hemminger
2011-02-23 18:24 ` Brandeburg, Jesse
2011-02-24 0:03 ` Jeff Kirsher
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.