From: Mark Brown <broonie@kernel.org> To: Tiezhu Yang <yangtiezhu@loongson.cn> Cc: linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, Mark Brown <broonie@kernel.org> Subject: Applied "spi: spidev_test: Use perror() only if errno is not 0" to the spi tree Date: Thu, 13 Feb 2020 13:32:29 +0000 [thread overview] Message-ID: <applied-1581567368-8055-3-git-send-email-yangtiezhu@loongson.cn> (raw) In-Reply-To: <1581567368-8055-3-git-send-email-yangtiezhu@loongson.cn> The patch spi: spidev_test: Use perror() only if errno is not 0 has been applied to the spi tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-5.7 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark From 470a072e12200576788dc622d58894609feae2d7 Mon Sep 17 00:00:00 2001 From: Tiezhu Yang <yangtiezhu@loongson.cn> Date: Thu, 13 Feb 2020 12:16:07 +0800 Subject: [PATCH] spi: spidev_test: Use perror() only if errno is not 0 It is better to use perror() only if errno is not 0, it should use printf() when errno is 0, otherwise there exists redudant ": Success". E.g. without this patch: $ ./spidev_test -p 1234 --input test.bin only one of -p and --input may be selected: Success Aborted (core dumped) With this patch: $ ./spidev_test -p 1234 --input test.bin only one of -p and --input may be selected Aborted (core dumped) Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Link: https://lore.kernel.org/r/1581567368-8055-3-git-send-email-yangtiezhu@loongson.cn Signed-off-by: Mark Brown <broonie@kernel.org> --- tools/spi/spidev_test.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/tools/spi/spidev_test.c b/tools/spi/spidev_test.c index 5866178cdcc9..27967dd90f8f 100644 --- a/tools/spi/spidev_test.c +++ b/tools/spi/spidev_test.c @@ -13,6 +13,7 @@ #include <stdio.h> #include <stdlib.h> #include <string.h> +#include <errno.h> #include <getopt.h> #include <fcntl.h> #include <time.h> @@ -26,7 +27,11 @@ static void pabort(const char *s) { - perror(s); + if (errno != 0) + perror(s); + else + printf("%s\n", s); + abort(); } -- 2.20.1
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org> To: Tiezhu Yang <yangtiezhu@loongson.cn> Cc: linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, Mark Brown <broonie@kernel.org> Subject: Applied "spi: spidev_test: Use perror() only if errno is not 0" to the spi tree Date: Thu, 13 Feb 2020 13:32:29 +0000 [thread overview] Message-ID: <applied-1581567368-8055-3-git-send-email-yangtiezhu@loongson.cn> (raw) In-Reply-To: <1581567368-8055-3-git-send-email-yangtiezhu@loongson.cn> The patch spi: spidev_test: Use perror() only if errno is not 0 has been applied to the spi tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-5.7 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark >From 470a072e12200576788dc622d58894609feae2d7 Mon Sep 17 00:00:00 2001 From: Tiezhu Yang <yangtiezhu@loongson.cn> Date: Thu, 13 Feb 2020 12:16:07 +0800 Subject: [PATCH] spi: spidev_test: Use perror() only if errno is not 0 It is better to use perror() only if errno is not 0, it should use printf() when errno is 0, otherwise there exists redudant ": Success". E.g. without this patch: $ ./spidev_test -p 1234 --input test.bin only one of -p and --input may be selected: Success Aborted (core dumped) With this patch: $ ./spidev_test -p 1234 --input test.bin only one of -p and --input may be selected Aborted (core dumped) Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Link: https://lore.kernel.org/r/1581567368-8055-3-git-send-email-yangtiezhu@loongson.cn Signed-off-by: Mark Brown <broonie@kernel.org> --- tools/spi/spidev_test.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/tools/spi/spidev_test.c b/tools/spi/spidev_test.c index 5866178cdcc9..27967dd90f8f 100644 --- a/tools/spi/spidev_test.c +++ b/tools/spi/spidev_test.c @@ -13,6 +13,7 @@ #include <stdio.h> #include <stdlib.h> #include <string.h> +#include <errno.h> #include <getopt.h> #include <fcntl.h> #include <time.h> @@ -26,7 +27,11 @@ static void pabort(const char *s) { - perror(s); + if (errno != 0) + perror(s); + else + printf("%s\n", s); + abort(); } -- 2.20.1
next prev parent reply other threads:[~2020-02-13 13:32 UTC|newest] Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-02-13 4:16 [PATCH 1/4] spi: spidev_test: Remove break after exit statement Tiezhu Yang 2020-02-13 4:16 ` [PATCH 2/4] spi: spidev_test: Check input_tx and input_file first after parse options Tiezhu Yang 2020-02-13 8:26 ` Geert Uytterhoeven 2020-02-13 8:26 ` Geert Uytterhoeven 2020-02-13 13:32 ` Applied "spi: spidev_test: Check input_tx and input_file first after parse options" to the spi tree Mark Brown 2020-02-13 13:32 ` Mark Brown 2020-02-13 4:16 ` [PATCH 3/4] spi: spidev_test: Use perror() only if errno is not 0 Tiezhu Yang 2020-02-13 8:27 ` Geert Uytterhoeven 2020-02-13 8:27 ` Geert Uytterhoeven 2020-02-13 13:32 ` Mark Brown [this message] 2020-02-13 13:32 ` Applied "spi: spidev_test: Use perror() only if errno is not 0" to the spi tree Mark Brown 2020-02-13 4:16 ` [PATCH 4/4] spi: spidev_test: Remove the whole "include" directory when make clean Tiezhu Yang 2020-02-13 4:16 ` Tiezhu Yang 2020-02-13 13:32 ` Applied "spi: spidev_test: Remove the whole "include" directory when make clean" to the spi tree Mark Brown 2020-02-13 13:32 ` Mark Brown 2020-02-13 8:23 ` [PATCH 1/4] spi: spidev_test: Remove break after exit statement Geert Uytterhoeven 2020-02-13 8:23 ` Geert Uytterhoeven 2020-02-13 13:32 ` Applied "spi: spidev_test: Remove break after exit statement" to the spi tree Mark Brown 2020-02-13 13:32 ` Mark Brown
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=applied-1581567368-8055-3-git-send-email-yangtiezhu@loongson.cn \ --to=broonie@kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-spi@vger.kernel.org \ --cc=yangtiezhu@loongson.cn \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.