[PATCH 2/2] ASoC: rt5682: remove noisy debug messages

[PATCH 2/2] ASoC: rt5682: remove noisy debug messages

[shumingf]

From: Shuming Fan <shumingf@realtek.com>

Some debug messages are too noisy.
This patch removes it.

Signed-off-by: Shuming Fan <shumingf@realtek.com>
---
 sound/soc/codecs/rt5682.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/sound/soc/codecs/rt5682.c b/sound/soc/codecs/rt5682.c
index 023bc672274b..2ee01e782fe0 100644
--- a/sound/soc/codecs/rt5682.c
+++ b/sound/soc/codecs/rt5682.c
@@ -1197,11 +1197,11 @@ static int rt5682_div_sel(struct rt5682_priv *rt5682,
 	}
 
 	for (i = 0; i < size - 1; i++) {
-		pr_info("div[%d]=%d\n", i, div[i]);
+		dev_dbg(rt5682->component->dev, "div[%d]=%d\n", i, div[i]);
 		if (target * div[i] == rt5682->sysclk)
 			return i;
 		if (target * div[i + 1] > rt5682->sysclk) {
-			pr_err("can't find div for sysclk %d\n",
+			dev_dbg(rt5682->component->dev, "can't find div for sysclk %d\n",
 				rt5682->sysclk);
 			return i;
 		}
-- 
2.25.1

Re: [PATCH 2/2] ASoC: rt5682: remove noisy debug messages

[Tzung-Bi Shih]

On Tue, Mar 17, 2020 at 3:35 PM <shumingf@realtek.com> wrote:
> Some debug messages are too noisy.
> This patch removes it.

Suggest to use other words.  For example, title: "ASoC: rt5682: make
output message less verbose"; message: "Makes output message less
verbose by reducing the log severity".

>         for (i = 0; i < size - 1; i++) {
> -               pr_info("div[%d]=%d\n", i, div[i]);
> +               dev_dbg(rt5682->component->dev, "div[%d]=%d\n", i, div[i]);
>                 if (target * div[i] == rt5682->sysclk)
>                         return i;
>                 if (target * div[i + 1] > rt5682->sysclk) {
> -                       pr_err("can't find div for sysclk %d\n",
> +                       dev_dbg(rt5682->component->dev, "can't find div for sysclk %d\n",
>                                 rt5682->sysclk);

Looking at around of the file, use pr_debug( ) here could be more consistent.

Re: [PATCH 2/2] ASoC: rt5682: remove noisy debug messages

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 416 bytes --]

On Wed, Mar 18, 2020 at 11:22:47PM +0800, Tzung-Bi Shih wrote:
> On Tue, Mar 17, 2020 at 3:35 PM <shumingf@realtek.com> wrote:

> > +                       dev_dbg(rt5682->component->dev, "can't find div for sysclk %d\n",
> >                                 rt5682->sysclk);

> Looking at around of the file, use pr_debug( ) here could be more consistent.

It'd be better convert those pr_debug() to dev_dbg()s TBH.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Applied "ASoC: rt5682: remove noisy debug messages" to the asoc tree

[Mark Brown]

The patch

   ASoC: rt5682: remove noisy debug messages

has been applied to the asoc tree at

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git 

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.  

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

From 243de01deb545e9c288459458e28e5ff0656ca1f Mon Sep 17 00:00:00 2001
From: Shuming Fan <shumingf@realtek.com>
Date: Tue, 17 Mar 2020 15:33:21 +0800
Subject: [PATCH] ASoC: rt5682: remove noisy debug messages

Some debug messages are too noisy.
This patch removes it.

Signed-off-by: Shuming Fan <shumingf@realtek.com>
Link: https://lore.kernel.org/r/20200317073321.12660-1-shumingf@realtek.com
Signed-off-by: Mark Brown <broonie@kernel.org>
---
 sound/soc/codecs/rt5682.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/sound/soc/codecs/rt5682.c b/sound/soc/codecs/rt5682.c
index 7ca02a5e52e9..513429478d27 100644
--- a/sound/soc/codecs/rt5682.c
+++ b/sound/soc/codecs/rt5682.c
@@ -1197,11 +1197,11 @@ static int rt5682_div_sel(struct rt5682_priv *rt5682,
 	}
 
 	for (i = 0; i < size - 1; i++) {
-		pr_info("div[%d]=%d\n", i, div[i]);
+		dev_dbg(rt5682->component->dev, "div[%d]=%d\n", i, div[i]);
 		if (target * div[i] == rt5682->sysclk)
 			return i;
 		if (target * div[i + 1] > rt5682->sysclk) {
-			pr_err("can't find div for sysclk %d\n",
+			dev_dbg(rt5682->component->dev, "can't find div for sysclk %d\n",
 				rt5682->sysclk);
 			return i;
 		}
-- 
2.20.1