* [PATCH net-next] selftests: vxlan_mdb: Avoid duplicate test names
@ 2024-02-27 17:04 Ido Schimmel
2024-02-29 4:20 ` patchwork-bot+netdevbpf
2024-02-29 8:28 ` Liu, Yujie
0 siblings, 2 replies; 3+ messages in thread
From: Ido Schimmel @ 2024-02-27 17:04 UTC (permalink / raw)
To: netdev, linux-kselftest
Cc: davem, kuba, pabeni, edumazet, shuah, yujie.liu, Ido Schimmel
Rename some test cases to avoid overlapping test names which is
problematic for the kernel test robot. No changes in the test's logic.
Suggested-by: Yujie Liu <yujie.liu@intel.com>
Signed-off-by: Ido Schimmel <idosch@nvidia.com>
---
Yujie Liu, please verify this works for you.
---
tools/testing/selftests/net/test_vxlan_mdb.sh | 36 +++++++++----------
1 file changed, 18 insertions(+), 18 deletions(-)
diff --git a/tools/testing/selftests/net/test_vxlan_mdb.sh b/tools/testing/selftests/net/test_vxlan_mdb.sh
index 84a05a9e46d8..74ff9fb2a6f0 100755
--- a/tools/testing/selftests/net/test_vxlan_mdb.sh
+++ b/tools/testing/selftests/net/test_vxlan_mdb.sh
@@ -1014,10 +1014,10 @@ flush()
run_cmd "bridge -n $ns1_v4 mdb flush dev vx0 port vx0"
run_cmd "bridge -n $ns1_v4 -d -s mdb get dev vx0 grp 239.1.1.1 src_vni 10010"
- log_test $? 254 "Flush by port"
+ log_test $? 254 "Flush by port - matching"
run_cmd "bridge -n $ns1_v4 mdb flush dev vx0 port veth0"
- log_test $? 255 "Flush by wrong port"
+ log_test $? 255 "Flush by port - non-matching"
# Check that when flushing by source VNI only entries programmed with
# the specified source VNI are flushed and the rest are not.
@@ -1030,9 +1030,9 @@ flush()
run_cmd "bridge -n $ns1_v4 mdb flush dev vx0 src_vni 10010"
run_cmd "bridge -n $ns1_v4 -d -s mdb get dev vx0 grp 239.1.1.1 src_vni 10010"
- log_test $? 254 "Flush by specified source VNI"
+ log_test $? 254 "Flush by source VNI - matching"
run_cmd "bridge -n $ns1_v4 -d -s mdb get dev vx0 grp 239.1.1.1 src_vni 10011"
- log_test $? 0 "Flush by unspecified source VNI"
+ log_test $? 0 "Flush by source VNI - non-matching"
run_cmd "bridge -n $ns1_v4 mdb flush dev vx0"
@@ -1058,9 +1058,9 @@ flush()
run_cmd "bridge -n $ns1_v4 mdb flush dev vx0 proto bgp"
run_cmd "bridge -n $ns1_v4 -d -s mdb get dev vx0 grp 239.1.1.1 src_vni 10010 | grep \"proto bgp\""
- log_test $? 1 "Flush by specified routing protocol"
+ log_test $? 1 "Flush by routing protocol - matching"
run_cmd "bridge -n $ns1_v4 -d -s mdb get dev vx0 grp 239.1.1.1 src_vni 10010 | grep \"proto zebra\""
- log_test $? 0 "Flush by unspecified routing protocol"
+ log_test $? 0 "Flush by routing protocol - non-matching"
run_cmd "bridge -n $ns1_v4 mdb flush dev vx0"
@@ -1075,9 +1075,9 @@ flush()
run_cmd "bridge -n $ns1_v4 mdb flush dev vx0 dst 198.51.100.2"
run_cmd "bridge -n $ns1_v4 -d -s mdb get dev vx0 grp 239.1.1.1 src_vni 10010 | grep 198.51.100.2"
- log_test $? 1 "Flush by specified destination IP - IPv4"
+ log_test $? 1 "Flush by IPv4 destination IP - matching"
run_cmd "bridge -n $ns1_v4 -d -s mdb get dev vx0 grp 239.1.1.1 src_vni 10010 | grep 198.51.100.1"
- log_test $? 0 "Flush by unspecified destination IP - IPv4"
+ log_test $? 0 "Flush by IPv4 destination IP - non-matching"
run_cmd "bridge -n $ns1_v4 mdb flush dev vx0"
@@ -1089,9 +1089,9 @@ flush()
run_cmd "bridge -n $ns1_v4 mdb flush dev vx0 dst 2001:db8:1000::2"
run_cmd "bridge -n $ns1_v4 -d -s mdb get dev vx0 grp 239.1.1.1 src_vni 10010 | grep 2001:db8:1000::2"
- log_test $? 1 "Flush by specified destination IP - IPv6"
+ log_test $? 1 "Flush by IPv6 destination IP - matching"
run_cmd "bridge -n $ns1_v4 -d -s mdb get dev vx0 grp 239.1.1.1 src_vni 10010 | grep 2001:db8:1000::1"
- log_test $? 0 "Flush by unspecified destination IP - IPv6"
+ log_test $? 0 "Flush by IPv6 destination IP - non-matching"
run_cmd "bridge -n $ns1_v4 mdb flush dev vx0"
@@ -1104,9 +1104,9 @@ flush()
run_cmd "bridge -n $ns1_v4 mdb flush dev vx0 dst_port 11111"
run_cmd "bridge -n $ns1_v4 -d -s mdb get dev vx0 grp 239.1.1.1 src_vni 10010 | grep \"dst_port 11111\""
- log_test $? 1 "Flush by specified UDP destination port"
+ log_test $? 1 "Flush by UDP destination port - matching"
run_cmd "bridge -n $ns1_v4 -d -s mdb get dev vx0 grp 239.1.1.1 src_vni 10010 | grep \"dst_port 22222\""
- log_test $? 0 "Flush by unspecified UDP destination port"
+ log_test $? 0 "Flush by UDP destination port - non-matching"
run_cmd "bridge -n $ns1_v4 mdb flush dev vx0"
@@ -1121,9 +1121,9 @@ flush()
run_cmd "bridge -n $ns1_v4 mdb flush dev vx0 dst_port 4789"
run_cmd "bridge -n $ns1_v4 -d -s mdb get dev vx0 grp 239.1.1.1 src_vni 10010 | grep 198.51.100.1"
- log_test $? 1 "Flush by device's UDP destination port"
+ log_test $? 1 "Flush by device's UDP destination port - matching"
run_cmd "bridge -n $ns1_v4 -d -s mdb get dev vx0 grp 239.1.1.1 src_vni 10010 | grep 198.51.100.2"
- log_test $? 0 "Flush by unspecified UDP destination port"
+ log_test $? 0 "Flush by device's UDP destination port - non-matching"
run_cmd "bridge -n $ns1_v4 mdb flush dev vx0"
@@ -1136,9 +1136,9 @@ flush()
run_cmd "bridge -n $ns1_v4 mdb flush dev vx0 vni 20010"
run_cmd "bridge -n $ns1_v4 -d -s mdb get dev vx0 grp 239.1.1.1 src_vni 10010 | grep \" vni 20010\""
- log_test $? 1 "Flush by specified destination VNI"
+ log_test $? 1 "Flush by destination VNI - matching"
run_cmd "bridge -n $ns1_v4 -d -s mdb get dev vx0 grp 239.1.1.1 src_vni 10010 | grep \" vni 20011\""
- log_test $? 0 "Flush by unspecified destination VNI"
+ log_test $? 0 "Flush by destination VNI - non-matching"
run_cmd "bridge -n $ns1_v4 mdb flush dev vx0"
@@ -1153,9 +1153,9 @@ flush()
run_cmd "bridge -n $ns1_v4 mdb flush dev vx0 vni 10010"
run_cmd "bridge -n $ns1_v4 -d -s mdb get dev vx0 grp 239.1.1.1 src_vni 10010 | grep 198.51.100.1"
- log_test $? 1 "Flush by destination VNI equal to source VNI"
+ log_test $? 1 "Flush by destination VNI equal to source VNI - matching"
run_cmd "bridge -n $ns1_v4 -d -s mdb get dev vx0 grp 239.1.1.1 src_vni 10010 | grep 198.51.100.2"
- log_test $? 0 "Flush by unspecified destination VNI"
+ log_test $? 0 "Flush by destination VNI equal to source VNI - non-matching"
run_cmd "bridge -n $ns1_v4 mdb flush dev vx0"
--
2.43.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] selftests: vxlan_mdb: Avoid duplicate test names
2024-02-27 17:04 [PATCH net-next] selftests: vxlan_mdb: Avoid duplicate test names Ido Schimmel
@ 2024-02-29 4:20 ` patchwork-bot+netdevbpf
2024-02-29 8:28 ` Liu, Yujie
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2024-02-29 4:20 UTC (permalink / raw)
To: Ido Schimmel
Cc: netdev, linux-kselftest, davem, kuba, pabeni, edumazet, shuah, yujie.liu
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Tue, 27 Feb 2024 19:04:18 +0200 you wrote:
> Rename some test cases to avoid overlapping test names which is
> problematic for the kernel test robot. No changes in the test's logic.
>
> Suggested-by: Yujie Liu <yujie.liu@intel.com>
> Signed-off-by: Ido Schimmel <idosch@nvidia.com>
> ---
> Yujie Liu, please verify this works for you.
>
> [...]
Here is the summary with links:
- [net-next] selftests: vxlan_mdb: Avoid duplicate test names
https://git.kernel.org/netdev/net-next/c/8a7746982ed7
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] selftests: vxlan_mdb: Avoid duplicate test names
2024-02-27 17:04 [PATCH net-next] selftests: vxlan_mdb: Avoid duplicate test names Ido Schimmel
2024-02-29 4:20 ` patchwork-bot+netdevbpf
@ 2024-02-29 8:28 ` Liu, Yujie
1 sibling, 0 replies; 3+ messages in thread
From: Liu, Yujie @ 2024-02-29 8:28 UTC (permalink / raw)
To: idosch, netdev, linux-kselftest; +Cc: shuah, edumazet, davem, kuba, pabeni
Hi Ido,
On Tue, 2024-02-27 at 19:04 +0200, Ido Schimmel wrote:
> Rename some test cases to avoid overlapping test names which is
> problematic for the kernel test robot. No changes in the test's
> logic.
>
> Suggested-by: Yujie Liu <yujie.liu@intel.com>
> Signed-off-by: Ido Schimmel <idosch@nvidia.com>
> ---
> Yujie Liu, please verify this works for you.
This patch works well in the kernel test robot. Now there is no problem
of overlapping test names. Thanks.
Tested-by: Yujie Liu <yujie.liu@intel.com>
# Control path: Flush
# -------------------
# TEST: Flush all [ OK ]
# TEST: Flush by port - matching [ OK ]
# TEST: Flush by port - non-matching [ OK ]
# TEST: Flush by source VNI - matching [ OK ]
# TEST: Flush by source VNI - non-matching [ OK ]
# TEST: Flush by "permanent" state [ OK ]
# TEST: Flush by "nopermanent" state [ OK ]
# TEST: Flush by routing protocol - matching [ OK ]
# TEST: Flush by routing protocol - non-matching [ OK ]
# TEST: Flush by IPv4 destination IP - matching [ OK ]
# TEST: Flush by IPv4 destination IP - non-matching [ OK ]
# TEST: Flush by IPv6 destination IP - matching [ OK ]
# TEST: Flush by IPv6 destination IP - non-matching [ OK ]
# TEST: Flush by UDP destination port - matching [ OK ]
# TEST: Flush by UDP destination port - non-matching [ OK ]
# TEST: Flush by device's UDP destination port - matching [ OK ]
# TEST: Flush by device's UDP destination port - non-matching [ OK ]
# TEST: Flush by destination VNI - matching [ OK ]
# TEST: Flush by destination VNI - non-matching [ OK ]
# TEST: Flush by destination VNI equal to source VNI - matching [ OK ]
# TEST: Flush by destination VNI equal to source VNI - non-matching [ OK ]
# TEST: Flush by VLAN ID [ OK ]
> ---
> tools/testing/selftests/net/test_vxlan_mdb.sh | 36 +++++++++----------
> 1 file changed, 18 insertions(+), 18 deletions(-)
>
> diff --git a/tools/testing/selftests/net/test_vxlan_mdb.sh b/tools/testing/selftests/net/test_vxlan_mdb.sh
> index 84a05a9e46d8..74ff9fb2a6f0 100755
> --- a/tools/testing/selftests/net/test_vxlan_mdb.sh
> +++ b/tools/testing/selftests/net/test_vxlan_mdb.sh
> @@ -1014,10 +1014,10 @@ flush()
>
> run_cmd "bridge -n $ns1_v4 mdb flush dev vx0 port vx0"
> run_cmd "bridge -n $ns1_v4 -d -s mdb get dev vx0 grp 239.1.1.1 src_vni 10010"
> - log_test $? 254 "Flush by port"
> + log_test $? 254 "Flush by port - matching"
>
> run_cmd "bridge -n $ns1_v4 mdb flush dev vx0 port veth0"
> - log_test $? 255 "Flush by wrong port"
> + log_test $? 255 "Flush by port - non-matching"
>
> # Check that when flushing by source VNI only entries programmed with
> # the specified source VNI are flushed and the rest are not.
> @@ -1030,9 +1030,9 @@ flush()
> run_cmd "bridge -n $ns1_v4 mdb flush dev vx0 src_vni 10010"
>
> run_cmd "bridge -n $ns1_v4 -d -s mdb get dev vx0 grp 239.1.1.1 src_vni 10010"
> - log_test $? 254 "Flush by specified source VNI"
> + log_test $? 254 "Flush by source VNI - matching"
> run_cmd "bridge -n $ns1_v4 -d -s mdb get dev vx0 grp 239.1.1.1 src_vni 10011"
> - log_test $? 0 "Flush by unspecified source VNI"
> + log_test $? 0 "Flush by source VNI - non-matching"
>
> run_cmd "bridge -n $ns1_v4 mdb flush dev vx0"
>
> @@ -1058,9 +1058,9 @@ flush()
> run_cmd "bridge -n $ns1_v4 mdb flush dev vx0 proto bgp"
>
> run_cmd "bridge -n $ns1_v4 -d -s mdb get dev vx0 grp 239.1.1.1 src_vni 10010 | grep \"proto bgp\""
> - log_test $? 1 "Flush by specified routing protocol"
> + log_test $? 1 "Flush by routing protocol - matching"
> run_cmd "bridge -n $ns1_v4 -d -s mdb get dev vx0 grp 239.1.1.1 src_vni 10010 | grep \"proto zebra\""
> - log_test $? 0 "Flush by unspecified routing protocol"
> + log_test $? 0 "Flush by routing protocol - non-matching"
>
> run_cmd "bridge -n $ns1_v4 mdb flush dev vx0"
>
> @@ -1075,9 +1075,9 @@ flush()
> run_cmd "bridge -n $ns1_v4 mdb flush dev vx0 dst 198.51.100.2"
>
> run_cmd "bridge -n $ns1_v4 -d -s mdb get dev vx0 grp 239.1.1.1 src_vni 10010 | grep 198.51.100.2"
> - log_test $? 1 "Flush by specified destination IP - IPv4"
> + log_test $? 1 "Flush by IPv4 destination IP - matching"
> run_cmd "bridge -n $ns1_v4 -d -s mdb get dev vx0 grp 239.1.1.1 src_vni 10010 | grep 198.51.100.1"
> - log_test $? 0 "Flush by unspecified destination IP - IPv4"
> + log_test $? 0 "Flush by IPv4 destination IP - non-matching"
>
> run_cmd "bridge -n $ns1_v4 mdb flush dev vx0"
>
> @@ -1089,9 +1089,9 @@ flush()
> run_cmd "bridge -n $ns1_v4 mdb flush dev vx0 dst 2001:db8:1000::2"
>
> run_cmd "bridge -n $ns1_v4 -d -s mdb get dev vx0 grp 239.1.1.1 src_vni 10010 | grep 2001:db8:1000::2"
> - log_test $? 1 "Flush by specified destination IP - IPv6"
> + log_test $? 1 "Flush by IPv6 destination IP - matching"
> run_cmd "bridge -n $ns1_v4 -d -s mdb get dev vx0 grp 239.1.1.1 src_vni 10010 | grep 2001:db8:1000::1"
> - log_test $? 0 "Flush by unspecified destination IP - IPv6"
> + log_test $? 0 "Flush by IPv6 destination IP - non-matching"
>
> run_cmd "bridge -n $ns1_v4 mdb flush dev vx0"
>
> @@ -1104,9 +1104,9 @@ flush()
> run_cmd "bridge -n $ns1_v4 mdb flush dev vx0 dst_port 11111"
>
> run_cmd "bridge -n $ns1_v4 -d -s mdb get dev vx0 grp 239.1.1.1 src_vni 10010 | grep \"dst_port 11111\""
> - log_test $? 1 "Flush by specified UDP destination port"
> + log_test $? 1 "Flush by UDP destination port - matching"
> run_cmd "bridge -n $ns1_v4 -d -s mdb get dev vx0 grp 239.1.1.1 src_vni 10010 | grep \"dst_port 22222\""
> - log_test $? 0 "Flush by unspecified UDP destination port"
> + log_test $? 0 "Flush by UDP destination port - non-matching"
>
> run_cmd "bridge -n $ns1_v4 mdb flush dev vx0"
>
> @@ -1121,9 +1121,9 @@ flush()
> run_cmd "bridge -n $ns1_v4 mdb flush dev vx0 dst_port 4789"
>
> run_cmd "bridge -n $ns1_v4 -d -s mdb get dev vx0 grp 239.1.1.1 src_vni 10010 | grep 198.51.100.1"
> - log_test $? 1 "Flush by device's UDP destination port"
> + log_test $? 1 "Flush by device's UDP destination port - matching"
> run_cmd "bridge -n $ns1_v4 -d -s mdb get dev vx0 grp 239.1.1.1 src_vni 10010 | grep 198.51.100.2"
> - log_test $? 0 "Flush by unspecified UDP destination port"
> + log_test $? 0 "Flush by device's UDP destination port - non-matching"
>
> run_cmd "bridge -n $ns1_v4 mdb flush dev vx0"
>
> @@ -1136,9 +1136,9 @@ flush()
> run_cmd "bridge -n $ns1_v4 mdb flush dev vx0 vni 20010"
>
> run_cmd "bridge -n $ns1_v4 -d -s mdb get dev vx0 grp 239.1.1.1 src_vni 10010 | grep \" vni 20010\""
> - log_test $? 1 "Flush by specified destination VNI"
> + log_test $? 1 "Flush by destination VNI - matching"
> run_cmd "bridge -n $ns1_v4 -d -s mdb get dev vx0 grp 239.1.1.1 src_vni 10010 | grep \" vni 20011\""
> - log_test $? 0 "Flush by unspecified destination VNI"
> + log_test $? 0 "Flush by destination VNI - non-matching"
>
> run_cmd "bridge -n $ns1_v4 mdb flush dev vx0"
>
> @@ -1153,9 +1153,9 @@ flush()
> run_cmd "bridge -n $ns1_v4 mdb flush dev vx0 vni 10010"
>
> run_cmd "bridge -n $ns1_v4 -d -s mdb get dev vx0 grp 239.1.1.1 src_vni 10010 | grep 198.51.100.1"
> - log_test $? 1 "Flush by destination VNI equal to source VNI"
> + log_test $? 1 "Flush by destination VNI equal to source VNI - matching"
> run_cmd "bridge -n $ns1_v4 -d -s mdb get dev vx0 grp 239.1.1.1 src_vni 10010 | grep 198.51.100.2"
> - log_test $? 0 "Flush by unspecified destination VNI"
> + log_test $? 0 "Flush by destination VNI equal to source VNI - non-matching"
>
> run_cmd "bridge -n $ns1_v4 mdb flush dev vx0"
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-02-29 8:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-02-27 17:04 [PATCH net-next] selftests: vxlan_mdb: Avoid duplicate test names Ido Schimmel
2024-02-29 4:20 ` patchwork-bot+netdevbpf
2024-02-29 8:28 ` Liu, Yujie
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.