All of lore.kernel.org
 help / color / mirror / Atom feed
* [V2] drm/amdgpu: Fix documentaion for dm_dmub_outbox1_low_irq
@ 2021-07-20 14:30 Anson Jacob
  2021-07-20 14:49 ` Alex Deucher
  2021-07-20 20:52 ` Harry Wentland
  0 siblings, 2 replies; 3+ messages in thread
From: Anson Jacob @ 2021-07-20 14:30 UTC (permalink / raw)
  To: amd-gfx; +Cc: Anson Jacob, Harry Wentland

Fix make htmldocs complaint:
./drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c:628: warning: Excess function parameter 'interrupt_params' description in 'DMUB_TRACE_MAX_READ'

v2:
Moved DMUB_TRACE_MAX_READ macro above function documentation

Signed-off-by: Anson Jacob <Anson.Jacob@amd.com>
CC: Harry Wentland <harry.wentland@amd.com>
---
 drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
index 7ed104e3756b..829d31e04f09 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
@@ -618,6 +618,7 @@ static void dm_dcn_vertical_interrupt0_high_irq(void *interrupt_params)
 }
 #endif
 
+#define DMUB_TRACE_MAX_READ 64
 /**
  * dm_dmub_outbox1_low_irq() - Handles Outbox interrupt
  * @interrupt_params: used for determining the Outbox instance
@@ -625,7 +626,6 @@ static void dm_dcn_vertical_interrupt0_high_irq(void *interrupt_params)
  * Handles the Outbox Interrupt
  * event handler.
  */
-#define DMUB_TRACE_MAX_READ 64
 static void dm_dmub_outbox1_low_irq(void *interrupt_params)
 {
 	struct dmub_notification notify;
-- 
2.25.1

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [V2] drm/amdgpu: Fix documentaion for dm_dmub_outbox1_low_irq
  2021-07-20 14:30 [V2] drm/amdgpu: Fix documentaion for dm_dmub_outbox1_low_irq Anson Jacob
@ 2021-07-20 14:49 ` Alex Deucher
  2021-07-20 20:52 ` Harry Wentland
  1 sibling, 0 replies; 3+ messages in thread
From: Alex Deucher @ 2021-07-20 14:49 UTC (permalink / raw)
  To: Anson Jacob; +Cc: Harry Wentland, amd-gfx list

On Tue, Jul 20, 2021 at 10:30 AM Anson Jacob <Anson.Jacob@amd.com> wrote:
>
> Fix make htmldocs complaint:
> ./drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c:628: warning: Excess function parameter 'interrupt_params' description in 'DMUB_TRACE_MAX_READ'
>
> v2:
> Moved DMUB_TRACE_MAX_READ macro above function documentation
>
> Signed-off-by: Anson Jacob <Anson.Jacob@amd.com>
> CC: Harry Wentland <harry.wentland@amd.com>

Acked-by: Alex Deucher <alexander.deucher@amd.com>

> ---
>  drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> index 7ed104e3756b..829d31e04f09 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> @@ -618,6 +618,7 @@ static void dm_dcn_vertical_interrupt0_high_irq(void *interrupt_params)
>  }
>  #endif
>
> +#define DMUB_TRACE_MAX_READ 64
>  /**
>   * dm_dmub_outbox1_low_irq() - Handles Outbox interrupt
>   * @interrupt_params: used for determining the Outbox instance
> @@ -625,7 +626,6 @@ static void dm_dcn_vertical_interrupt0_high_irq(void *interrupt_params)
>   * Handles the Outbox Interrupt
>   * event handler.
>   */
> -#define DMUB_TRACE_MAX_READ 64
>  static void dm_dmub_outbox1_low_irq(void *interrupt_params)
>  {
>         struct dmub_notification notify;
> --
> 2.25.1
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [V2] drm/amdgpu: Fix documentaion for dm_dmub_outbox1_low_irq
  2021-07-20 14:30 [V2] drm/amdgpu: Fix documentaion for dm_dmub_outbox1_low_irq Anson Jacob
  2021-07-20 14:49 ` Alex Deucher
@ 2021-07-20 20:52 ` Harry Wentland
  1 sibling, 0 replies; 3+ messages in thread
From: Harry Wentland @ 2021-07-20 20:52 UTC (permalink / raw)
  To: Anson Jacob, amd-gfx

On 2021-07-20 10:30 a.m., Anson Jacob wrote:
> Fix make htmldocs complaint:
> ./drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c:628: warning: Excess function parameter 'interrupt_params' description in 'DMUB_TRACE_MAX_READ'
> 
> v2:
> Moved DMUB_TRACE_MAX_READ macro above function documentation
> 
> Signed-off-by: Anson Jacob <Anson.Jacob@amd.com>
> CC: Harry Wentland <harry.wentland@amd.com>

Reviewed-by: Harry Wentland <harry.wentland@amd.com>

Harry

> ---
>  drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> index 7ed104e3756b..829d31e04f09 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> @@ -618,6 +618,7 @@ static void dm_dcn_vertical_interrupt0_high_irq(void *interrupt_params)
>  }
>  #endif
>  
> +#define DMUB_TRACE_MAX_READ 64
>  /**
>   * dm_dmub_outbox1_low_irq() - Handles Outbox interrupt
>   * @interrupt_params: used for determining the Outbox instance
> @@ -625,7 +626,6 @@ static void dm_dcn_vertical_interrupt0_high_irq(void *interrupt_params)
>   * Handles the Outbox Interrupt
>   * event handler.
>   */
> -#define DMUB_TRACE_MAX_READ 64
>  static void dm_dmub_outbox1_low_irq(void *interrupt_params)
>  {
>  	struct dmub_notification notify;
> 

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-07-20 20:52 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-20 14:30 [V2] drm/amdgpu: Fix documentaion for dm_dmub_outbox1_low_irq Anson Jacob
2021-07-20 14:49 ` Alex Deucher
2021-07-20 20:52 ` Harry Wentland

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.