[PATCH 1/2] manuals: SYSTEMD_SERVICE allows multiple services

[PATCH 1/2] manuals: SYSTEMD_SERVICE allows multiple services

[Paulo Neves]

State that SYSTEMD_SERVICE allows for multiple space
separated systemd services
---
 documentation/ref-manual/variables.rst | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/documentation/ref-manual/variables.rst b/documentation/ref-manual/variables.rst
index 367b4674e..ed52c3508 100644
--- a/documentation/ref-manual/variables.rst
+++ b/documentation/ref-manual/variables.rst
@@ -7656,6 +7656,8 @@ system and gives an overview of their function and contents.
       When inheriting the :ref:`systemd <ref-classes-systemd>` class,
       this variable specifies the systemd service name for a package.
 
+      Multiple services can be specified with each one separated by a space.
+
       When you specify this file in your recipe, use a package name
       override to indicate the package to which the value applies. Here is
       an example from the connman recipe::
-- 
2.25.1

[PATCH 2/2] manuals: SYSTEMD_SERVICE overrides depend on SYSTEMD_PACKAGES

[Paulo Neves]

Add detail that package overrides are only available if
specified in SYSTEMD_PACKAGES.
---
 documentation/ref-manual/variables.rst | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/documentation/ref-manual/variables.rst b/documentation/ref-manual/variables.rst
index ed52c3508..6e2919474 100644
--- a/documentation/ref-manual/variables.rst
+++ b/documentation/ref-manual/variables.rst
@@ -7664,6 +7664,10 @@ system and gives an overview of their function and contents.
 
          SYSTEMD_SERVICE:${PN} = "connman.service"
 
+      The package overrides that can be specified are directly related to the value of
+      term: SYSTEMD_PACKAGES. Overrides not included in term: SYSTEMD_PACKAGES
+      will be silently ignored.
+
    :term:`SYSVINIT_ENABLED_GETTYS`
       When using
       :ref:`SysVinit <dev-manual/common-tasks:enabling system services>`,
-- 
2.25.1

Re: [yocto] [PATCH 1/2] manuals: SYSTEMD_SERVICE allows multiple services

[Michael Opdenacker]

Hi Paulo

Thanks for the patches!

On 6/3/22 18:35, Paulo Neves wrote:
> State that SYSTEMD_SERVICE allows for multiple space
> separated systemd services
> ---
>  documentation/ref-manual/variables.rst | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/documentation/ref-manual/variables.rst b/documentation/ref-manual/variables.rst
> index 367b4674e..ed52c3508 100644
> --- a/documentation/ref-manual/variables.rst
> +++ b/documentation/ref-manual/variables.rst
> @@ -7656,6 +7656,8 @@ system and gives an overview of their function and contents.
>        When inheriting the :ref:`systemd <ref-classes-systemd>` class,
>        this variable specifies the systemd service name for a package.
>  
> +      Multiple services can be specified with each one separated by a space.


I'd propose a slightly simpler sentence:
"... can be specified, each one separated ..."

Would you mind sending the patch again to docs@lists.yoctoproject.org,
and this time with "Signed-off-by" information (from "git commit -s"),
please?
I was going to accept your patch directly, but this is required.

Thanks in advance
Michael.

-- 
Michael Opdenacker, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

Re: [yocto] [PATCH 2/2] manuals: SYSTEMD_SERVICE overrides depend on SYSTEMD_PACKAGES

[Michael Opdenacker]

Hi again Paulo,

On 6/3/22 18:35, Paulo Neves wrote:
> Add detail that package overrides are only available if
> specified in SYSTEMD_PACKAGES.
> ---
>  documentation/ref-manual/variables.rst | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/documentation/ref-manual/variables.rst b/documentation/ref-manual/variables.rst
> index ed52c3508..6e2919474 100644
> --- a/documentation/ref-manual/variables.rst
> +++ b/documentation/ref-manual/variables.rst
> @@ -7664,6 +7664,10 @@ system and gives an overview of their function and contents.
>  
>           SYSTEMD_SERVICE:${PN} = "connman.service"
>  
> +      The package overrides that can be specified are directly related to the value of
> +      term: SYSTEMD_PACKAGES. Overrides not included in term: SYSTEMD_PACKAGES
> +      will be silently ignored.


You should use instead:
:term:`SYSTEMD_PACKAGES`

Would you mind sending an update to docs@lists.yoctoproject.org with
your "Signed-off-by" information, please?

Thanks in advance
Michael.

-- 
Michael Opdenacker, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

Re: [yocto] [PATCH 1/2] manuals: SYSTEMD_SERVICE allows multiple services

[Michael Opdenacker]

Hi again Paulo and developers,

On 6/3/22 18:35, Paulo Neves wrote:
> State that SYSTEMD_SERVICE allows for multiple space
> separated systemd services
> ---
>  documentation/ref-manual/variables.rst | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/documentation/ref-manual/variables.rst b/documentation/ref-manual/variables.rst
> index 367b4674e..ed52c3508 100644
> --- a/documentation/ref-manual/variables.rst
> +++ b/documentation/ref-manual/variables.rst
> @@ -7656,6 +7656,8 @@ system and gives an overview of their function and contents.
>        When inheriting the :ref:`systemd <ref-classes-systemd>` class,
>        this variable specifies the systemd service name for a package.
>  
> +      Multiple services can be specified with each one separated by a space.


Wouldn't it make more sense to call the variable "SYSTEMD_SERVICES" instead?
We could add a new variable and deprecate the old one.

What do you think? Would it be worth the trouble?

Cheers
Michael.

-- 
Michael Opdenacker, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

Re: [yocto] [PATCH 1/2] manuals: SYSTEMD_SERVICE allows multiple services

[Paulo Neves]

I think so, given we have a deprecation mechanism enforced in code.
The confusion definitely came up, and this is why a documentation 
clarification was needed.

Paulo Neves

On 6/6/22 18:47, Michael Opdenacker wrote:
> Hi again Paulo and developers,
>
> On 6/3/22 18:35, Paulo Neves wrote:
>> State that SYSTEMD_SERVICE allows for multiple space
>> separated systemd services
>> ---
>>   documentation/ref-manual/variables.rst | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/documentation/ref-manual/variables.rst b/documentation/ref-manual/variables.rst
>> index 367b4674e..ed52c3508 100644
>> --- a/documentation/ref-manual/variables.rst
>> +++ b/documentation/ref-manual/variables.rst
>> @@ -7656,6 +7656,8 @@ system and gives an overview of their function and contents.
>>         When inheriting the :ref:`systemd <ref-classes-systemd>` class,
>>         this variable specifies the systemd service name for a package.
>>   
>> +      Multiple services can be specified with each one separated by a space.
>
> Wouldn't it make more sense to call the variable "SYSTEMD_SERVICES" instead?
> We could add a new variable and deprecate the old one.
>
> What do you think? Would it be worth the trouble?
>
> Cheers
> Michael.
>

[PATCH v2 1/2] manuals: SYSTEMD_SERVICE allows multiple services

[Paulo Neves]

State that SYSTEMD_SERVICE allows for multiple space
separated systemd services

Signed-off-by: Paulo Neves <ptsneves@gmail.com>
---
 documentation/ref-manual/variables.rst | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/documentation/ref-manual/variables.rst b/documentation/ref-manual/variables.rst
index 367b4674e..42178d556 100644
--- a/documentation/ref-manual/variables.rst
+++ b/documentation/ref-manual/variables.rst
@@ -7656,6 +7656,8 @@ system and gives an overview of their function and contents.
       When inheriting the :ref:`systemd <ref-classes-systemd>` class,
       this variable specifies the systemd service name for a package.
 
+      Multiple services can be specified, each one separated by a space.
+
       When you specify this file in your recipe, use a package name
       override to indicate the package to which the value applies. Here is
       an example from the connman recipe::
-- 
2.25.1

[PATCH v2 2/2] manuals: SYSTEMD_SERVICE overrides depend on SYSTEMD_PACKAGES

[Paulo Neves]

Add detail that package overrides are only available if
specified in SYSTEMD_PACKAGES.

Signed-off-by: Paulo Neves <ptsneves@gmail.com>
---
 documentation/ref-manual/variables.rst | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/documentation/ref-manual/variables.rst b/documentation/ref-manual/variables.rst
index 42178d556..e31f0ed88 100644
--- a/documentation/ref-manual/variables.rst
+++ b/documentation/ref-manual/variables.rst
@@ -7664,6 +7664,10 @@ system and gives an overview of their function and contents.
 
          SYSTEMD_SERVICE:${PN} = "connman.service"
 
+      The package overrides that can be specified are directly related to the value of
+      term:`SYSTEMD_PACKAGES`. Overrides not included in term:`SYSTEMD_PACKAGES`
+      will be silently ignored.
+
    :term:`SYSVINIT_ENABLED_GETTYS`
       When using
       :ref:`SysVinit <dev-manual/common-tasks:enabling system services>`,
-- 
2.25.1

Re: [yocto] [PATCH v2 2/2] manuals: SYSTEMD_SERVICE overrides depend on SYSTEMD_PACKAGES

[Michael Opdenacker]

Hi Paulo

On 6/7/22 10:42, Paulo Neves wrote:
> Add detail that package overrides are only available if
> specified in SYSTEMD_PACKAGES.
>
> Signed-off-by: Paulo Neves <ptsneves@gmail.com>
> ---
>  documentation/ref-manual/variables.rst | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/documentation/ref-manual/variables.rst b/documentation/ref-manual/variables.rst
> index 42178d556..e31f0ed88 100644
> --- a/documentation/ref-manual/variables.rst
> +++ b/documentation/ref-manual/variables.rst
> @@ -7664,6 +7664,10 @@ system and gives an overview of their function and contents.
>  
>           SYSTEMD_SERVICE:${PN} = "connman.service"
>  
> +      The package overrides that can be specified are directly related to the value of
> +      term:`SYSTEMD_PACKAGES`. Overrides not included in term:`SYSTEMD_PACKAGES`
> +      will be silently ignored.
> +
>     :term:`SYSVINIT_ENABLED_GETTYS`
>        When using
>        :ref:`SysVinit <dev-manual/common-tasks:enabling system services>`,

Thanks for the patch. Merged into yocto-docs' master-next

Don't forget to copy the docs@lists.yoctoproject.org mailing list next time.

Thanks again

Michael.

-- 
Michael Opdenacker, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

Re: [yocto] [PATCH v2 1/2] manuals: SYSTEMD_SERVICE allows multiple services

[Michael Opdenacker]

On 6/7/22 10:42, Paulo Neves wrote:
> State that SYSTEMD_SERVICE allows for multiple space
> separated systemd services
>
> Signed-off-by: Paulo Neves <ptsneves@gmail.com>
> ---
>  documentation/ref-manual/variables.rst | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/documentation/ref-manual/variables.rst b/documentation/ref-manual/variables.rst
> index 367b4674e..42178d556 100644
> --- a/documentation/ref-manual/variables.rst
> +++ b/documentation/ref-manual/variables.rst
> @@ -7656,6 +7656,8 @@ system and gives an overview of their function and contents.
>        When inheriting the :ref:`systemd <ref-classes-systemd>` class,
>        this variable specifies the systemd service name for a package.
>  
> +      Multiple services can be specified, each one separated by a space.
> +
>        When you specify this file in your recipe, use a package name
>        override to indicate the package to which the value applies. Here is
>        an example from the connman recipe::


Merged into master-next too.
Thanks!
Michael.

-- 
Michael Opdenacker, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

Re: [yocto] [PATCH v2 2/2] manuals: SYSTEMD_SERVICE overrides depend on SYSTEMD_PACKAGES

[Paulo Neves]

Hi Michael,

My sincere apologies. Will try to improve next time

Paulo Neves

On 6/7/22 10:53, Michael Opdenacker wrote:
> Hi Paulo
>
> On 6/7/22 10:42, Paulo Neves wrote:
>> Add detail that package overrides are only available if
>> specified in SYSTEMD_PACKAGES.
>>
>> Signed-off-by: Paulo Neves <ptsneves@gmail.com>
>> ---
>>   documentation/ref-manual/variables.rst | 4 ++++
>>   1 file changed, 4 insertions(+)
>>
>> diff --git a/documentation/ref-manual/variables.rst b/documentation/ref-manual/variables.rst
>> index 42178d556..e31f0ed88 100644
>> --- a/documentation/ref-manual/variables.rst
>> +++ b/documentation/ref-manual/variables.rst
>> @@ -7664,6 +7664,10 @@ system and gives an overview of their function and contents.
>>   
>>            SYSTEMD_SERVICE:${PN} = "connman.service"
>>   
>> +      The package overrides that can be specified are directly related to the value of
>> +      term:`SYSTEMD_PACKAGES`. Overrides not included in term:`SYSTEMD_PACKAGES`
>> +      will be silently ignored.
>> +
>>      :term:`SYSVINIT_ENABLED_GETTYS`
>>         When using
>>         :ref:`SysVinit <dev-manual/common-tasks:enabling system services>`,
> Thanks for the patch. Merged into yocto-docs' master-next
>
> Don't forget to copy the docs@lists.yoctoproject.org mailing list next time.
>
> Thanks again
>
> Michael.
>

Re: [yocto] [PATCH 1/2] manuals: SYSTEMD_SERVICE allows multiple services

[Michael Opdenacker]

Hi Paulo

On 6/7/22 10:33, Paulo Neves wrote:
> I think so, given we have a deprecation mechanism enforced in code.
> The confusion definitely came up, and this is why a documentation
> clarification was needed.


That's done on the documentation side. Then, what about proposing a
patch to openembedded-core to introduce a new SYSTEMD_SERVICES variable
and deprecate SYSTEMD_SERVICE?
Cheers
Michael.

-- 
Michael Opdenacker, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com