From: Robin Murphy <robin.murphy@arm.com>
To: Marek Szyprowski <m.szyprowski@samsung.com>,
Thierry Reding <thierry.reding@gmail.com>,
Will Deacon <will@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Cc: iommu@lists.linux-foundation.org,
Jon Hunter <jonathanh@nvidia.com>,
Nicolin Chen <nicolinc@nvidia.com>,
linux-tegra@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 3/9] iommu/arm-smmu: Implement ->probe_finalize()
Date: Tue, 15 Jun 2021 19:08:34 +0100 [thread overview]
Message-ID: <b070bca8-f8e8-8f58-5b3c-2b587e93d9e5@arm.com> (raw)
In-Reply-To: <46e65ade-49cb-5437-5863-1f11ccc2205e@samsung.com>
On 2021-06-15 19:01, Marek Szyprowski wrote:
> Hi,
>
> On 03.06.2021 18:46, Thierry Reding wrote:
>> From: Thierry Reding <treding@nvidia.com>
>>
>> Implement a ->probe_finalize() callback that can be used by vendor
>> implementations to perform extra programming necessary after devices
>> have been attached to the SMMU.
>>
>> Signed-off-by: Thierry Reding <treding@nvidia.com>
>
> This patch landed recently in linux-next as commit 0d97174aeadf
> ("iommu/arm-smmu: Implement ->probe_finalize()"). It causes the
> following issue on ARM Juno R1 board:
[...]
>> +static void arm_smmu_probe_finalize(struct device *dev)
>> +{
>> + struct arm_smmu_master_cfg *cfg;
>> + struct arm_smmu_device *smmu;
>> +
>> + cfg = dev_iommu_priv_get(dev);
>> + smmu = cfg->smmu;
>> +
>> + if (smmu->impl->probe_finalize)
Oops, indeed that needs to check smmu->impl first.
Robin.
>> + smmu->impl->probe_finalize(smmu, dev);
>> +}
>> +
WARNING: multiple messages have this Message-ID (diff)
From: Robin Murphy <robin.murphy@arm.com>
To: Marek Szyprowski <m.szyprowski@samsung.com>,
Thierry Reding <thierry.reding@gmail.com>,
Will Deacon <will@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Cc: linux-tegra@vger.kernel.org, iommu@lists.linux-foundation.org,
Nicolin Chen <nicolinc@nvidia.com>,
linux-arm-kernel@lists.infradead.org,
Jon Hunter <jonathanh@nvidia.com>
Subject: Re: [PATCH v3 3/9] iommu/arm-smmu: Implement ->probe_finalize()
Date: Tue, 15 Jun 2021 19:08:34 +0100 [thread overview]
Message-ID: <b070bca8-f8e8-8f58-5b3c-2b587e93d9e5@arm.com> (raw)
In-Reply-To: <46e65ade-49cb-5437-5863-1f11ccc2205e@samsung.com>
On 2021-06-15 19:01, Marek Szyprowski wrote:
> Hi,
>
> On 03.06.2021 18:46, Thierry Reding wrote:
>> From: Thierry Reding <treding@nvidia.com>
>>
>> Implement a ->probe_finalize() callback that can be used by vendor
>> implementations to perform extra programming necessary after devices
>> have been attached to the SMMU.
>>
>> Signed-off-by: Thierry Reding <treding@nvidia.com>
>
> This patch landed recently in linux-next as commit 0d97174aeadf
> ("iommu/arm-smmu: Implement ->probe_finalize()"). It causes the
> following issue on ARM Juno R1 board:
[...]
>> +static void arm_smmu_probe_finalize(struct device *dev)
>> +{
>> + struct arm_smmu_master_cfg *cfg;
>> + struct arm_smmu_device *smmu;
>> +
>> + cfg = dev_iommu_priv_get(dev);
>> + smmu = cfg->smmu;
>> +
>> + if (smmu->impl->probe_finalize)
Oops, indeed that needs to check smmu->impl first.
Robin.
>> + smmu->impl->probe_finalize(smmu, dev);
>> +}
>> +
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
WARNING: multiple messages have this Message-ID (diff)
From: Robin Murphy <robin.murphy@arm.com>
To: Marek Szyprowski <m.szyprowski@samsung.com>,
Thierry Reding <thierry.reding@gmail.com>,
Will Deacon <will@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Cc: iommu@lists.linux-foundation.org,
Jon Hunter <jonathanh@nvidia.com>,
Nicolin Chen <nicolinc@nvidia.com>,
linux-tegra@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 3/9] iommu/arm-smmu: Implement ->probe_finalize()
Date: Tue, 15 Jun 2021 19:08:34 +0100 [thread overview]
Message-ID: <b070bca8-f8e8-8f58-5b3c-2b587e93d9e5@arm.com> (raw)
In-Reply-To: <46e65ade-49cb-5437-5863-1f11ccc2205e@samsung.com>
On 2021-06-15 19:01, Marek Szyprowski wrote:
> Hi,
>
> On 03.06.2021 18:46, Thierry Reding wrote:
>> From: Thierry Reding <treding@nvidia.com>
>>
>> Implement a ->probe_finalize() callback that can be used by vendor
>> implementations to perform extra programming necessary after devices
>> have been attached to the SMMU.
>>
>> Signed-off-by: Thierry Reding <treding@nvidia.com>
>
> This patch landed recently in linux-next as commit 0d97174aeadf
> ("iommu/arm-smmu: Implement ->probe_finalize()"). It causes the
> following issue on ARM Juno R1 board:
[...]
>> +static void arm_smmu_probe_finalize(struct device *dev)
>> +{
>> + struct arm_smmu_master_cfg *cfg;
>> + struct arm_smmu_device *smmu;
>> +
>> + cfg = dev_iommu_priv_get(dev);
>> + smmu = cfg->smmu;
>> +
>> + if (smmu->impl->probe_finalize)
Oops, indeed that needs to check smmu->impl first.
Robin.
>> + smmu->impl->probe_finalize(smmu, dev);
>> +}
>> +
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-06-15 18:08 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-03 16:46 [PATCH v3 0/9] arm64: tegra: Prevent early SMMU faults Thierry Reding
2021-06-03 16:46 ` Thierry Reding
2021-06-03 16:46 ` Thierry Reding
2021-06-03 16:46 ` [PATCH v3 1/9] memory: tegra: Implement SID override programming Thierry Reding
2021-06-03 16:46 ` Thierry Reding
2021-06-03 16:46 ` Thierry Reding
2021-06-03 16:46 ` [PATCH v3 2/9] dt-bindings: arm-smmu: Add Tegra186 compatible string Thierry Reding
2021-06-03 16:46 ` Thierry Reding
2021-06-03 16:46 ` Thierry Reding
2021-06-18 19:47 ` Rob Herring
2021-06-18 19:47 ` Rob Herring
2021-06-18 19:47 ` Rob Herring
2021-06-21 6:46 ` Krzysztof Kozlowski
2021-06-21 6:46 ` Krzysztof Kozlowski
2021-06-21 6:46 ` Krzysztof Kozlowski
2021-06-21 14:11 ` Thierry Reding
2021-06-21 14:11 ` Thierry Reding
2021-06-21 14:11 ` Thierry Reding
2021-06-21 15:54 ` Will Deacon
2021-06-21 15:54 ` Will Deacon
2021-06-21 15:54 ` Will Deacon
2021-06-21 16:03 ` Thierry Reding
2021-06-21 16:03 ` Thierry Reding
2021-06-21 16:03 ` Thierry Reding
2021-06-03 16:46 ` [PATCH v3 3/9] iommu/arm-smmu: Implement ->probe_finalize() Thierry Reding
2021-06-03 16:46 ` Thierry Reding
2021-06-03 16:46 ` Thierry Reding
[not found] ` <CGME20210615180133eucas1p2563c2a173eca1fb5a1c5ccf654c23778@eucas1p2.samsung.com>
2021-06-15 18:01 ` Marek Szyprowski
2021-06-15 18:01 ` Marek Szyprowski
2021-06-15 18:01 ` Marek Szyprowski
2021-06-15 18:08 ` Robin Murphy [this message]
2021-06-15 18:08 ` Robin Murphy
2021-06-15 18:08 ` Robin Murphy
2021-06-15 18:12 ` Krishna Reddy
2021-06-15 18:12 ` Krishna Reddy
2021-06-15 18:12 ` Krishna Reddy
2021-06-15 18:21 ` Will Deacon
2021-06-15 18:21 ` Will Deacon
2021-06-15 18:21 ` Will Deacon
2021-06-15 19:50 ` Will Deacon
2021-06-15 19:50 ` Will Deacon
2021-06-15 19:50 ` Will Deacon
2021-06-03 16:46 ` [PATCH v3 4/9] iommu/arm-smmu: tegra: Detect number of instances at runtime Thierry Reding
2021-06-03 16:46 ` Thierry Reding
2021-06-03 16:46 ` Thierry Reding
2021-06-03 16:46 ` [PATCH v3 5/9] iommu/arm-smmu: tegra: Implement SID override programming Thierry Reding
2021-06-03 16:46 ` Thierry Reding
2021-06-03 16:46 ` Thierry Reding
2021-06-03 16:46 ` [PATCH v3 6/9] iommu/arm-smmu: Use Tegra implementation on Tegra186 Thierry Reding
2021-06-03 16:46 ` Thierry Reding
2021-06-03 16:46 ` Thierry Reding
2021-06-03 16:46 ` [PATCH v3 7/9] arm64: tegra: Use correct compatible string for Tegra186 SMMU Thierry Reding
2021-06-03 16:46 ` Thierry Reding
2021-06-03 16:46 ` Thierry Reding
2021-06-03 16:46 ` [PATCH v3 8/9] arm64: tegra: Hook up memory controller to SMMU on Tegra186 Thierry Reding
2021-06-03 16:46 ` Thierry Reding
2021-06-03 16:46 ` Thierry Reding
2021-06-03 16:46 ` [PATCH v3 9/9] arm64: tegra: Enable SMMU support on Tegra194 Thierry Reding
2021-06-03 16:46 ` Thierry Reding
2021-06-03 16:46 ` Thierry Reding
2021-06-03 19:51 ` (subset) [PATCH v3 0/9] arm64: tegra: Prevent early SMMU faults Krzysztof Kozlowski
2021-06-03 19:51 ` Krzysztof Kozlowski
2021-06-03 19:51 ` Krzysztof Kozlowski
2021-06-11 6:48 ` Krzysztof Kozlowski
2021-06-11 6:48 ` Krzysztof Kozlowski
2021-06-11 6:48 ` Krzysztof Kozlowski
2021-06-11 12:05 ` Thierry Reding
2021-06-11 12:05 ` Thierry Reding
2021-06-11 12:05 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b070bca8-f8e8-8f58-5b3c-2b587e93d9e5@arm.com \
--to=robin.murphy@arm.com \
--cc=iommu@lists.linux-foundation.org \
--cc=jonathanh@nvidia.com \
--cc=krzysztof.kozlowski@canonical.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-tegra@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=nicolinc@nvidia.com \
--cc=thierry.reding@gmail.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.