From: Frieder Schrempf <frieder.schrempf@kontron.de>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: u-boot@lists.denx.de, "NXP i.MX U-Boot Team" <uboot-imx@nxp.com>,
Fabio Estevam <festevam@gmail.com>,
Manuel Traut <manuel.traut@mt.com>,
Stefano Babic <sbabic@denx.de>
Subject: Re: [PATCH v2] imx: imx8mm: Add suppoer for Mettler-Toledo snowflake board.
Date: Tue, 28 Mar 2023 11:34:42 +0200 [thread overview]
Message-ID: <b0b6925a-e43a-64e0-487e-5f656e6afcb2@kontron.de> (raw)
In-Reply-To: <20230328093013.sCzkQX3l@linutronix.de>
On 28.03.23 11:30, Sebastian Andrzej Siewior wrote:
> On 2023-03-28 09:53:28 [+0200], Frieder Schrempf wrote:
>> On 28.03.23 09:47, Sebastian Andrzej Siewior wrote:
>>> The board is similar to "Kontron SL i.MX8M Mini" SoM. There are two variants.
>>> Snowflake_v2 has an external SDCard Interface. LEIG is the same, but without
>>> display and without external SDCard Interface. Both variants support
>>> only 1GiB of main memory.
>>>
>>> Signed-off-by: Manuel Traut <manuel.traut@mt.com>
>>> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
>>> ---
>>> v1…v2:
>>> - Clarify details about the board and whether or not there is an
>>> external SD-card interface.
>>
>> What about my other review comments to v1?
>
> I update the Name to "Kontron SL i.MX8M Mini" SoM in the description but
> forgot to add it to the changelog. Was there something else missed?
You can easily answer that yourself, by looking at the comments I made
in [1]. There are comments for the DT compatible, the PMIC node, the
I2C1 pinctrl node and the DDR init code you haven't responded to.
[1]
https://patchwork.ozlabs.org/project/uboot/patch/20230310135021.kRabfq7r@linutronix.de/#3078257
next prev parent reply other threads:[~2023-03-28 9:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-10 13:50 [PATCH] imx: imx8mm: Add suppoer for Mettler-Toledo snowflake board Sebastian Andrzej Siewior
2023-03-16 10:33 ` Frieder Schrempf
2023-03-16 10:37 ` Frieder Schrempf
2023-03-28 7:47 ` [PATCH v2] " Sebastian Andrzej Siewior
2023-03-28 7:53 ` Frieder Schrempf
2023-03-28 9:30 ` Sebastian Andrzej Siewior
2023-03-28 9:34 ` Frieder Schrempf [this message]
2023-03-28 9:37 ` Sebastian Andrzej Siewior
2023-03-28 9:40 ` Frieder Schrempf
2023-03-16 14:48 ` EXTERNAL - [PATCH] " Manuel Traut
2023-03-31 14:12 ` Sebastian Andrzej Siewior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b0b6925a-e43a-64e0-487e-5f656e6afcb2@kontron.de \
--to=frieder.schrempf@kontron.de \
--cc=bigeasy@linutronix.de \
--cc=festevam@gmail.com \
--cc=manuel.traut@mt.com \
--cc=sbabic@denx.de \
--cc=u-boot@lists.denx.de \
--cc=uboot-imx@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.