All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jacek Anaszewski <jacek.anaszewski@gmail.com>
To: Takashi Iwai <tiwai@suse.de>, Pavel Machek <pavel@ucw.cz>
Cc: linux-leds@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
	dtor@google.com, robh@kernel.org,
	Jaroslav Kysela <perex@perex.cz>,
	linux@roeck-us.net, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 01/26] ALSA: line6: Avoid polluting led_* namespace
Date: Thu, 18 Apr 2019 19:12:13 +0200	[thread overview]
Message-ID: <b0d841c4-f027-d99d-ab76-721fba4a2a1e@gmail.com> (raw)
In-Reply-To: <s5htvevh56y.wl-tiwai@suse.de>

On 4/18/19 2:24 PM, Takashi Iwai wrote:
> On Thu, 18 Apr 2019 14:21:35 +0200,
> Pavel Machek wrote:
>>
>> On Thu 2019-04-18 07:17:54, Takashi Iwai wrote:
>>> On Wed, 17 Apr 2019 22:54:14 +0200,
>>> Jacek Anaszewski wrote:
>>>>
>>>> led_colors clashes with the array of the same name being added
>>>> to the LED class. Do the following amendments to fix this issue
>>>> and the other prospective one.
>>>>
>>>> led_colors -> toneport_led_colors
>>>> led_init_vals -> toneport_led_init_vals
>>>>
>>>> Fixes: f44edd7b2bbed ("ALSA: line6/toneport: Implement LED controls via LED class")
>>>> Signed-off-by: Jacek Anaszewski <jacek.anaszewski@gmail.com>
>>>> Cc: Jaroslav Kysela <perex@perex.cz>
>>>> Cc: Takashi Iwai <tiwai@suse.com>
>>>> Cc: Arnd Bergmann <arnd@arndb.de>
>>>
>>> Looks good.
>>>
>>> Feel free to take my ack:
>>>    Reviewed-by: Takashi Iwai <tiwai@suse.de>

Thanks.

>> I guess this is independend of pretty much everything, and should be
>> taken through the sound tree?
> 
> I don't mind either way.  If it's easier for you to take through sound
> tree, just let me know.

I prefer to take it via LED tree as this patch is needed
by the LED naming set.

-- 
Best regards,
Jacek Anaszewski

  reply	other threads:[~2019-04-18 17:12 UTC|newest]

Thread overview: 75+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-17 20:54 [PATCH v4 00/26] Add generic support for composing LED class device name Jacek Anaszewski
2019-04-17 20:54 ` [PATCH v4 01/26] ALSA: line6: Avoid polluting led_* namespace Jacek Anaszewski
2019-04-18  5:17   ` Takashi Iwai
2019-04-18  5:17     ` Takashi Iwai
2019-04-18 12:21     ` Pavel Machek
2019-04-18 12:24       ` Takashi Iwai
2019-04-18 17:12         ` Jacek Anaszewski [this message]
2019-04-18 18:46           ` Jacek Anaszewski
2019-04-17 20:54 ` [PATCH v4 02/26] leds: class: Improve LED and LED flash class registration API Jacek Anaszewski
2019-04-24 13:46   ` Pavel Machek
2019-04-24 18:04     ` Jacek Anaszewski
2019-04-24 18:25       ` Pavel Machek
2019-04-24 18:56         ` Jacek Anaszewski
2019-04-17 20:54 ` [PATCH v4 03/26] dt-bindings: leds: Add LED_FUNCTION definitions Jacek Anaszewski
2019-04-26 18:47   ` Rob Herring
2019-04-26 18:47     ` Rob Herring
2019-04-17 20:54 ` [PATCH v4 04/26] dt-bindings: leds: Add LED_COLOR_ID definitions Jacek Anaszewski
2019-04-24 13:49   ` Pavel Machek
2019-04-24 18:14     ` Jacek Anaszewski
2019-04-26 18:47   ` Rob Herring
2019-04-26 18:47     ` Rob Herring
2019-04-17 20:54 ` [PATCH v4 05/26] dt-bindings: leds: Add properties for LED name construction Jacek Anaszewski
2019-04-26 18:58   ` Rob Herring
2019-04-26 18:58     ` Rob Herring
2019-04-17 20:54 ` [PATCH v4 06/26] leds: core: Add support for composing LED class device names Jacek Anaszewski
2019-04-17 20:54 ` [PATCH v4 07/26] dt-bindings: sc27xx-blt: Add function and color properties Jacek Anaszewski
2019-04-26 18:58   ` Rob Herring
2019-04-26 18:58     ` Rob Herring
2019-04-17 20:54 ` [PATCH v4 08/26] leds: sc27xx-blt: Use generic support for composing LED names Jacek Anaszewski
2019-04-17 20:54 ` [PATCH v4 09/26] dt-bindings: lt3593: Add function and color properties Jacek Anaszewski
2019-04-26 18:58   ` Rob Herring
2019-04-26 18:58     ` Rob Herring
2019-04-17 20:54 ` [PATCH v4 10/26] leds: lt3593: Use generic support for composing LED names Jacek Anaszewski
2019-04-17 20:54 ` [PATCH v4 11/26] dt-bindings: lp8860: Add function and color properties Jacek Anaszewski
2019-04-18 12:28   ` Dan Murphy
2019-04-18 12:28     ` Dan Murphy
2019-04-18 17:18     ` Jacek Anaszewski
2019-04-26 18:59   ` Rob Herring
2019-04-26 18:59     ` Rob Herring
2019-04-17 20:54 ` [PATCH v4 12/26] leds: lp8860: Use generic support for composing LED names Jacek Anaszewski
2019-04-17 20:54 ` [PATCH v4 13/26] dt-bindings: lm3692x: Add function and color properties Jacek Anaszewski
2019-04-26 19:21   ` Rob Herring
2019-04-26 19:21     ` Rob Herring
2019-04-17 20:54 ` [PATCH v4 14/26] leds: lm3692x: Use generic support for composing LED names Jacek Anaszewski
2019-04-17 20:54 ` [PATCH v4 15/26] dt-bindings: lm36010: Add function and color properties Jacek Anaszewski
2019-04-26 19:21   ` Rob Herring
2019-04-26 19:21     ` Rob Herring
2019-04-17 20:54 ` [PATCH v4 16/26] leds: lm3601x: Use generic support for composing LED names Jacek Anaszewski
2019-04-17 20:54 ` [PATCH v4 17/26] dt-bindings: cr0014114: Add function and color properties Jacek Anaszewski
2019-04-26 19:22   ` Rob Herring
2019-04-26 19:22     ` Rob Herring
2019-04-17 20:54 ` [PATCH v4 18/26] leds: cr0014114: Use generic support for composing LED names Jacek Anaszewski
2019-04-17 20:54 ` [PATCH v4 19/26] dt-bindings: aat1290: Add function and color properties Jacek Anaszewski
2019-04-26 19:22   ` Rob Herring
2019-04-26 19:22     ` Rob Herring
2019-04-17 20:54 ` [PATCH v4 20/26] leds: aat1290: Use generic support for composing LED names Jacek Anaszewski
2019-04-24 13:57   ` Pavel Machek
2019-04-24 18:16     ` Jacek Anaszewski
2019-04-17 20:54 ` [PATCH v4 21/26] dt-bindings: as3645a: Add function and color properties Jacek Anaszewski
2019-04-26 19:23   ` Rob Herring
2019-04-26 19:23     ` Rob Herring
2019-04-17 20:54 ` [PATCH v4 22/26] leds: as3645a: Use generic support for composing LED names Jacek Anaszewski
2019-04-24 14:01   ` Pavel Machek
2019-04-24 18:18     ` Jacek Anaszewski
2019-04-17 20:54 ` [PATCH v4 23/26] dt-bindings: leds-gpio: Add function and color properties Jacek Anaszewski
2019-04-26 19:23   ` Rob Herring
2019-04-26 19:23     ` Rob Herring
2019-04-17 20:54 ` [PATCH v4 24/26] leds: gpio: Use generic support for composing LED names Jacek Anaszewski
2019-04-24 14:04   ` Pavel Machek
2019-04-24 19:02     ` Jacek Anaszewski
2019-04-17 20:54 ` [PATCH v4 25/26] dt-bindings: an30259a: Add function and color properties Jacek Anaszewski
2019-04-26 19:23   ` Rob Herring
2019-04-26 19:23     ` Rob Herring
2019-04-17 20:54 ` [PATCH v4 26/26] leds: an30259a: Use generic support for composing LED names Jacek Anaszewski
2019-04-24 14:05   ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b0d841c4-f027-d99d-ab76-721fba4a2a1e@gmail.com \
    --to=jacek.anaszewski@gmail.com \
    --cc=arnd@arndb.de \
    --cc=devicetree@vger.kernel.org \
    --cc=dtor@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=pavel@ucw.cz \
    --cc=perex@perex.cz \
    --cc=robh@kernel.org \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.